Re: [PATCH v2 2/5] scsi: megaraid: Return SCSI_MLQUEUE_HOST_BUSY instead of 1

[John Garry <john.g.garry@oracle.com>]

On 15/01/2026 21:03, Bart Van Assche wrote:
> .queuecommand() implementations are expected to return a SCSI_MLQUEUE_*
> value. Return SCSI_MLQUEUE_HOST_BUSY from megaraid_queue_lck() instead of
> 1. This patch doesn't change any functionality since scsi_dispatch_cmd()
> converts all return values other than SCSI_MLQUEUE_* into
> SCSI_MLQUEUE_HOST_BUSY.
> 
> Cc: Kashyap Desai <kashyap.desai@broadcom.com>
> Cc: Sumit Saxena <sumit.saxena@broadcom.com>
> Cc: Shivasharan S <shivasharan.srikanteshwara@broadcom.com>
> Cc: Chandrakanth patil <chandrakanth.patil@broadcom.com>
> Cc: megaraidlinux.pdl@broadcom.com
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> ---
>   drivers/scsi/megaraid.c | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/scsi/megaraid.c b/drivers/scsi/megaraid.c
> index a00622c0c526..54ed0ba3f48a 100644
> --- a/drivers/scsi/megaraid.c
> +++ b/drivers/scsi/megaraid.c
> @@ -640,7 +640,7 @@ mega_build_cmd(adapter_t *adapter, struct scsi_cmnd *cmd, int *busy)
>   			}
>   
>   			if(!(scb = mega_allocate_scb(adapter, cmd))) {
> -				*busy = 1;
> +				*busy = SCSI_MLQUEUE_HOST_BUSY;
>   				return NULL;
>   			}
>   
> @@ -688,7 +688,7 @@ mega_build_cmd(adapter_t *adapter, struct scsi_cmnd *cmd, int *busy)

should @busy still be a pointer to an int?

>   
>   			/* Allocate a SCB and initialize passthru */
>   			if(!(scb = mega_allocate_scb(adapter, cmd))) {
> -				*busy = 1;
> +				*busy = SCSI_MLQUEUE_HOST_BUSY;
>   				return NULL;
>   			}
>   			pthru = scb->pthru;
> @@ -730,7 +730,7 @@ mega_build_cmd(adapter_t *adapter, struct scsi_cmnd *cmd, int *busy)
>   
>   			/* Allocate a SCB and initialize mailbox */
>   			if(!(scb = mega_allocate_scb(adapter, cmd))) {
> -				*busy = 1;
> +				*busy = SCSI_MLQUEUE_HOST_BUSY;
>   				return NULL;
>   			}
>   			mbox = (mbox_t *)scb->raw_mbox;
> @@ -870,7 +870,7 @@ mega_build_cmd(adapter_t *adapter, struct scsi_cmnd *cmd, int *busy)
>   
>   			/* Allocate a SCB and initialize mailbox */
>   			if(!(scb = mega_allocate_scb(adapter, cmd))) {
> -				*busy = 1;
> +				*busy = SCSI_MLQUEUE_HOST_BUSY;
>   				return NULL;
>   			}
>   
> @@ -898,7 +898,7 @@ mega_build_cmd(adapter_t *adapter, struct scsi_cmnd *cmd, int *busy)
>   	else {
>   		/* Allocate a SCB and initialize passthru */
>   		if(!(scb = mega_allocate_scb(adapter, cmd))) {
> -			*busy = 1;
> +			*busy = SCSI_MLQUEUE_HOST_BUSY;
>   			return NULL;
>   		}
>