Re: [PATCH 1/4] scsi: Rename .slave_alloc() and .slave_destroy()

[Bart Van Assche <bvanassche@acm.org>]

On 9/30/24 1:58 PM, Matthew Wilcox wrote:
> On Mon, Sep 30, 2024 at 01:18:47PM -0700, Bart Van Assche wrote:
>> There is agreement that the word "slave" should not be used in Linux
>> kernel source code. Hence this patch that renames .slave_alloc() into
>> .device_alloc() and .slave_destroy() into .device_destroy() in the SCSI
>> core, SCSI drivers, ATA drivers and also in the SCSI documentation.
>> Do not modify Documentation/scsi/ChangeLog.lpfc. No functionality has
>> been changed.
>>
>> This patch has been created as follows:
>> * Change the text "slave_alloc" into "device_alloc" in all source files
>>    except in the LPFC driver changelog.
>> * Change the text "slave_destroy" into "device_destroy" in all source
>>    files except in the LPFC driver changelog.
> 
> I still like my names better:
> 
> https://lore.kernel.org/linux-scsi/20200706193920.6897-1-willy@infradead.org/

The names used in this patch series are the names proposed by Christoph
Hellwig. Christoph, do you agree with the names proposed by Matthew?
 From his cover letter:

   scsi: Rename slave_alloc to sdev_prep
   scsi: Rename slave_destroy to sdev_destroy
   scsi: Rename slave_configure to sdev_configure

Thanks,

Bart.