Re: [PATCH 1/4] scsi: Rename .slave_alloc() and .slave_destroy()

[Damien Le Moal <dlemoal@kernel.org>]

On 10/3/24 05:23, Bart Van Assche wrote:
> On 9/30/24 5:10 PM, Damien Le Moal wrote:
>> On 10/1/24 05:18, Bart Van Assche wrote:
>>> diff --git a/include/linux/libata.h b/include/linux/libata.h
>>> index 9b4a6ff03235..e04184b6d79b 100644
>>> --- a/include/linux/libata.h
>>> +++ b/include/linux/libata.h
>>> @@ -1201,10 +1201,10 @@ extern int ata_std_bios_param(struct scsi_device *sdev,
>>>   			      struct block_device *bdev,
>>>   			      sector_t capacity, int geom[]);
>>>   extern void ata_scsi_unlock_native_capacity(struct scsi_device *sdev);
>>> -extern int ata_scsi_slave_alloc(struct scsi_device *sdev);
>>> +extern int ata_scsi_device_alloc(struct scsi_device *sdev);
>>
>> While at it, drop the extern.
>>
>>>   int ata_scsi_device_configure(struct scsi_device *sdev,
>>>   		struct queue_limits *lim);
>>> -extern void ata_scsi_slave_destroy(struct scsi_device *sdev);
>>> +extern void ata_scsi_device_destroy(struct scsi_device *sdev);
>>
>> Here too.
> 
> Hi Damien,
> 
> Can I declare removing superfluous "extern" keywords as out-of-scope for
> this patch series? There are plenty of superfluous "extern" keywords in
> many Linux .h files. Removing the superfluous "extern" keyword for the
> functions renamed by this patch series only probably won't make much of
> a difference.

That is fine.

> 
> Thanks,
> 
> Bart.
> 


-- 
Damien Le Moal
Western Digital Research