Re: [PATCH 2/4] scsi: Convert SCSI drivers to .device_configure()

[Leon Romanovsky <leon@kernel.org>]

On Mon, Sep 30, 2024 at 01:18:48PM -0700, Bart Van Assche wrote:
> There is agreement that the word "slave" should not be used in Linux
> kernel source code. 

I think that "there is agreement" is over-statement. It is good thing to
avoid using "slave" in the new code, but it is not a universally agreed
to change old code to new naming.

> Hence this patch that converts all SCSI drivers from
> .slave_configure() to .device_configure(). No functionality has been
> changed.
> 
> Cc: Damien Le Moal <dlemoal@kernel.org>
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> ---
>  drivers/infiniband/ulp/srp/ib_srp.c         |  5 +++--

Because of such small changes in RDMA, I'm not going to object for this
patch, but my opinion is that this type of patches do more harm than
benefit (for example backporting to older kernels).

Thanks

>  drivers/message/fusion/mptfc.c              |  2 +-
>  drivers/message/fusion/mptsas.c             |  6 +++---
>  drivers/message/fusion/mptscsih.c           |  4 ++--
>  drivers/message/fusion/mptscsih.h           |  3 ++-
>  drivers/message/fusion/mptspi.c             |  7 ++++---
>  drivers/net/ethernet/allwinner/sun4i-emac.c |  4 ++--
>  drivers/s390/scsi/zfcp_scsi.c               |  5 +++--
>  drivers/scsi/3w-9xxx.c                      |  7 ++++---
>  drivers/scsi/3w-sas.c                       |  7 ++++---
>  drivers/scsi/3w-xxxx.c                      |  9 ++++----
>  drivers/scsi/53c700.c                       |  7 ++++---
>  drivers/scsi/BusLogic.c                     |  7 ++++---
>  drivers/scsi/BusLogic.h                     |  3 ++-
>  drivers/scsi/aacraid/linit.c                |  8 ++++---
>  drivers/scsi/advansys.c                     | 23 +++++++++++----------
>  drivers/scsi/aic7xxx/aic79xx_osm.c          |  4 ++--
>  drivers/scsi/aic7xxx/aic7xxx_osm.c          |  4 ++--
>  drivers/scsi/arcmsr/arcmsr_hba.c            |  8 ++++---
>  drivers/scsi/bfa/bfad_im.c                  |  6 +++---
>  drivers/scsi/bnx2fc/bnx2fc_fcoe.c           |  5 +++--
>  drivers/scsi/csiostor/csio_scsi.c           |  6 +++---
>  drivers/scsi/esp_scsi.c                     |  7 ++++---
>  drivers/scsi/hpsa.c                         |  8 ++++---
>  drivers/scsi/ibmvscsi/ibmvfc.c              |  7 ++++---
>  drivers/scsi/ibmvscsi/ibmvscsi.c            |  8 ++++---
>  drivers/scsi/ips.c                          |  6 +++---
>  drivers/scsi/ips.h                          |  3 ++-
>  drivers/scsi/lpfc/lpfc_scsi.c               | 21 ++++++++++++-------
>  drivers/scsi/mvumi.c                        |  5 +++--
>  drivers/scsi/myrb.c                         |  5 +++--
>  drivers/scsi/myrs.c                         |  5 +++--
>  drivers/scsi/ncr53c8xx.c                    |  5 +++--
>  drivers/scsi/ps3rom.c                       |  5 +++--
>  drivers/scsi/qedf/qedf_main.c               |  5 +++--
>  drivers/scsi/qla1280.c                      |  6 +++---
>  drivers/scsi/qla2xxx/qla_os.c               |  4 ++--
>  drivers/scsi/qlogicpti.c                    |  5 +++--
>  drivers/scsi/scsi_debug.c                   |  7 ++++---
>  drivers/scsi/scsi_scan.c                    |  2 +-
>  drivers/scsi/smartpqi/smartpqi_init.c       |  5 +++--
>  drivers/scsi/snic/snic_main.c               |  6 +++---
>  drivers/scsi/stex.c                         |  4 ++--
>  drivers/scsi/storvsc_drv.c                  |  5 +++--
>  drivers/scsi/sym53c8xx_2/sym_glue.c         |  5 +++--
>  drivers/scsi/xen-scsifront.c                |  7 ++++---
>  drivers/staging/rts5208/rtsx.c              |  4 ++--
>  47 files changed, 166 insertions(+), 124 deletions(-)