From: Bart Van Assche <bvanassche@acm.org>
To: "Martin K . Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, Bart Van Assche <bvanassche@acm.org>,
Damien Le Moal <dlemoal@kernel.org>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>
Subject: [PATCH 3/4] scsi: core: Remove .slave_configure()
Date: Mon, 30 Sep 2024 13:18:49 -0700 [thread overview]
Message-ID: <20240930201937.2020129-4-bvanassche@acm.org> (raw)
In-Reply-To: <20240930201937.2020129-1-bvanassche@acm.org>
Now that all SCSI drivers have been converted from .slave_configure() to
.device_configure(), remove support for .slave_configure() from the SCSI
core. Change all references to .slave_configure() in the SCSI documentation
into references to .device_configure().
Cc: Damien Le Moal <dlemoal@kernel.org>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
drivers/scsi/scsi_scan.c | 4 +---
include/scsi/scsi_host.h | 10 +++-------
2 files changed, 4 insertions(+), 10 deletions(-)
diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c
index 05ea1e781d21..bb4ebb744b69 100644
--- a/drivers/scsi/scsi_scan.c
+++ b/drivers/scsi/scsi_scan.c
@@ -1076,8 +1076,6 @@ static int scsi_add_lun(struct scsi_device *sdev, unsigned char *inq_result,
if (hostt->device_configure)
ret = hostt->device_configure(sdev, &lim);
- else if (hostt->slave_configure)
- ret = hostt->slave_configure(sdev);
if (ret) {
queue_limits_cancel_update(sdev->request_queue);
/*
@@ -1102,7 +1100,7 @@ static int scsi_add_lun(struct scsi_device *sdev, unsigned char *inq_result,
* Set up budget map again since memory consumption of the map depends
* on actual queue depth.
*/
- if (hostt->device_configure || hostt->slave_configure)
+ if (hostt->device_configure)
scsi_realloc_sdev_budget_map(sdev, sdev->queue_depth);
if (sdev->scsi_level >= SCSI_3)
diff --git a/include/scsi/scsi_host.h b/include/scsi/scsi_host.h
index 934aae4254c3..28df2bd7af46 100644
--- a/include/scsi/scsi_host.h
+++ b/include/scsi/scsi_host.h
@@ -169,11 +169,11 @@ struct scsi_host_template {
*
* Deallocation: If we didn't find any devices at this ID, you will
* get an immediate call to device_destroy(). If we find something
- * here then you will get a call to slave_configure(), then the
+ * here then you will get a call to device_configure(), then the
* device will be used for however long it is kept around, then when
* the device is removed from the system (or * possibly at reboot
* time), you will then get a call to device_destroy(). This is
- * assuming you implement slave_configure and device_destroy.
+ * assuming you implement device_configure and device_destroy.
* However, if you allocate memory and hang it off the device struct,
* then you must implement the device_destroy() routine at a minimum
* in order to avoid leaking memory
@@ -211,19 +211,15 @@ struct scsi_host_template {
* up after yourself before returning non-0
*
* Status: OPTIONAL
- *
- * Note: slave_configure is the legacy version, use device_configure for
- * all new code. A driver must never define both.
*/
int (* device_configure)(struct scsi_device *, struct queue_limits *lim);
- int (* slave_configure)(struct scsi_device *);
/*
* Immediately prior to deallocating the device and after all activity
* has ceased the mid layer calls this point so that the low level
* driver may completely detach itself from the scsi device and vice
* versa. The low level driver is responsible for freeing any memory
- * it allocated in the device_alloc or slave_configure calls.
+ * it allocated in the device_alloc or device_configure calls.
*
* Status: OPTIONAL
*/
next prev parent reply other threads:[~2024-09-30 20:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-30 20:18 [PATCH 0/4] Do not use "slave" in function names Bart Van Assche
2024-09-30 20:18 ` [PATCH 1/4] scsi: Rename .slave_alloc() and .slave_destroy() Bart Van Assche
2024-09-30 20:58 ` Matthew Wilcox
2024-09-30 21:10 ` Bart Van Assche
2024-10-01 0:10 ` Damien Le Moal
2024-10-02 20:23 ` Bart Van Assche
2024-10-02 22:26 ` Damien Le Moal
2024-10-01 3:26 ` Randy Dunlap
2024-10-01 4:43 ` Randy Dunlap
2024-10-01 20:15 ` Bart Van Assche
2024-09-30 20:18 ` [PATCH 2/4] scsi: Convert SCSI drivers to .device_configure() Bart Van Assche
2024-10-01 6:11 ` Leon Romanovsky
2024-10-02 9:02 ` Geoff Levand
2024-10-02 15:19 ` Khalid Aziz
2024-09-30 20:18 ` Bart Van Assche [this message]
2024-09-30 20:18 ` [PATCH 4/4] scsi: core: Update .slave_configure() references in the documentation Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240930201937.2020129-4-bvanassche@acm.org \
--to=bvanassche@acm.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=dlemoal@kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox