* [PATCH] clean up drivers/scsi/scsi.h
@ 2005-02-14 10:57 Rolf Eike Beer
2005-02-14 11:09 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Rolf Eike Beer @ 2005-02-14 10:57 UTC (permalink / raw)
To: SCSI Mailing List
Hi,
this patch removes some useless struct declarations from drivers/scsi/scsi.h.
All this structs are already defined in the header files included above
except Scsi_Host, for which we now directly include <scsi/scsi_host.h>
Signed-off-by: Rolf Eike Beer <eike-kernel@sf-tec.de>
--- linux-2.6.10/drivers/scsi/scsi.h 2004-12-24 22:34:27.000000000 +0100
+++ linux-2.6.10/drivers/scsi/scsi.h-new 2005-02-14 11:45:54.000000000 +0100
@@ -28,6 +28,7 @@
#include <scsi/scsi_eh.h>
#include <scsi/scsi_request.h>
#include <scsi/scsi_tcq.h>
+#include <scsi/scsi_host.h>
#include <scsi/scsi.h>
/*
@@ -40,12 +41,6 @@
#define FALSE 0
#endif
-struct Scsi_Host;
-struct scsi_cmnd;
-struct scsi_device;
-struct scsi_target;
-struct scatterlist;
-
/*
* Legacy dma direction interfaces.
*
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] clean up drivers/scsi/scsi.h
2005-02-14 10:57 [PATCH] clean up drivers/scsi/scsi.h Rolf Eike Beer
@ 2005-02-14 11:09 ` Christoph Hellwig
2005-02-14 11:32 ` Rolf Eike Beer
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2005-02-14 11:09 UTC (permalink / raw)
To: Rolf Eike Beer; +Cc: SCSI Mailing List
On Mon, Feb 14, 2005 at 11:57:29AM +0100, Rolf Eike Beer wrote:
> Hi,
>
> this patch removes some useless struct declarations from drivers/scsi/scsi.h.
> All this structs are already defined in the header files included above
> except Scsi_Host, for which we now directly include <scsi/scsi_host.h>
No, this is totally wrong. If you only use pointers to structs always
use forward declarations instead of pulling in a full header.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] clean up drivers/scsi/scsi.h
2005-02-14 11:09 ` Christoph Hellwig
@ 2005-02-14 11:32 ` Rolf Eike Beer
0 siblings, 0 replies; 3+ messages in thread
From: Rolf Eike Beer @ 2005-02-14 11:32 UTC (permalink / raw)
To: SCSI Mailing List
Am Montag, 14. Februar 2005 12:09 schrieb Christoph Hellwig:
> On Mon, Feb 14, 2005 at 11:57:29AM +0100, Rolf Eike Beer wrote:
> > Hi,
> >
> > this patch removes some useless struct declarations from
> > drivers/scsi/scsi.h. All this structs are already defined in the header
> > files included above except Scsi_Host, for which we now directly include
> > <scsi/scsi_host.h>
>
> No, this is totally wrong. If you only use pointers to structs always
> use forward declarations instead of pulling in a full header.
Ok, this time without include scsi/scsi_host.h. The rest remains untouched,
"struct Scsi_Host;" is also in scsi/scsi_device.h. The header files for all
other structs are already included so no need do declare them again.
Signed-off-by: Rolf Eike Beer <eike-kernel@sf-tec.de>
--- linux-2.6.10/drivers/scsi/scsi.h 2004-12-24 22:34:27.000000000 +0100
+++ linux-2.6.10/drivers/scsi/scsi.h-new 2005-02-14 11:45:54.000000000 +0100
@@ -40,12 +40,6 @@
#define FALSE 0
#endif
-struct Scsi_Host;
-struct scsi_cmnd;
-struct scsi_device;
-struct scsi_target;
-struct scatterlist;
-
/*
* Legacy dma direction interfaces.
*
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-02-14 11:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-02-14 10:57 [PATCH] clean up drivers/scsi/scsi.h Rolf Eike Beer
2005-02-14 11:09 ` Christoph Hellwig
2005-02-14 11:32 ` Rolf Eike Beer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox