public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Don Brace <don.brace@pmcs.com>
To: scott.teel@pmcs.com, Kevin.Barnett@pmcs.com,
	james.bottomley@parallels.com, hch@infradead.org,
	Justin.Lindley@pmcs.com, brace@pmcs.com
Cc: linux-scsi@vger.kernel.org
Subject: [PATCH v5 08/42] hpsa: make function names consistent
Date: Thu, 23 Apr 2015 09:32:27 -0500	[thread overview]
Message-ID: <20150423143227.18832.47653.stgit@brunhilda> (raw)
In-Reply-To: <20150423141637.18832.35621.stgit@brunhilda>

From: Robert Elliott <elliott@hp.com>

make function names more consistent and meaningful

Reviewed-by: Scott Teel <scott.teel@pmcs.com>
Reviewed-by: Kevin Barnett <kevin.barnett@pmcs.com>
Reviewed-by: Tomas Henzl <thenzl@redhat.com>
Reviewed-by: Hannes Reinecke <hare@Suse.de>
Signed-off-by: Robert Elliott <elliott@hp.com>
Signed-off-by: Don Brace <don.brace@pmcs.com>
---
 drivers/scsi/hpsa.c |   14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 26e5988..427dbd5 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -6772,7 +6772,7 @@ out_disable:
 	return rc;
 }
 
-static int hpsa_allocate_cmd_pool(struct ctlr_info *h)
+static int hpsa_alloc_cmd_pool(struct ctlr_info *h)
 {
 	h->cmd_pool_bits = kzalloc(
 		DIV_ROUND_UP(h->nr_cmds, BITS_PER_LONG) *
@@ -7301,7 +7301,7 @@ reinit_after_soft_reset:
 	dev_info(&pdev->dev, "%s: <0x%x> at IRQ %d%s using DAC\n",
 	       h->devname, pdev->device,
 	       h->intr[h->intr_mode], dac ? "" : " not");
-	rc = hpsa_allocate_cmd_pool(h);
+	rc = hpsa_alloc_cmd_pool(h);
 	if (rc)
 		goto clean2_and_free_irqs;
 	if (hpsa_allocate_sg_chain_blocks(h))
@@ -7748,7 +7748,8 @@ static int hpsa_enter_performant_mode(struct ctlr_info *h, u32 trans_support)
 	return 0;
 }
 
-static int hpsa_alloc_ioaccel_cmd_and_bft(struct ctlr_info *h)
+/* Allocate ioaccel1 mode command blocks and block fetch table */
+static int hpsa_alloc_ioaccel1_cmd_and_bft(struct ctlr_info *h)
 {
 	h->ioaccel_maxsg =
 		readl(&(h->cfgtable->io_accel_max_embedded_sg_count));
@@ -7787,7 +7788,8 @@ clean_up:
 	return 1;
 }
 
-static int ioaccel2_alloc_cmds_and_bft(struct ctlr_info *h)
+/* Allocate ioaccel2 mode command blocks and block fetch table */
+static int hpsa_alloc_ioaccel2_cmd_and_bft(struct ctlr_info *h)
 {
 	/* Allocate ioaccel2 mode command blocks and block fetch table */
 
@@ -7842,13 +7844,13 @@ static void hpsa_put_ctlr_into_performant_mode(struct ctlr_info *h)
 	if (trans_support & CFGTBL_Trans_io_accel1) {
 		transMethod |= CFGTBL_Trans_io_accel1 |
 				CFGTBL_Trans_enable_directed_msix;
-		if (hpsa_alloc_ioaccel_cmd_and_bft(h))
+		if (hpsa_alloc_ioaccel1_cmd_and_bft(h))
 			goto clean_up;
 	} else {
 		if (trans_support & CFGTBL_Trans_io_accel2) {
 				transMethod |= CFGTBL_Trans_io_accel2 |
 				CFGTBL_Trans_enable_directed_msix;
-		if (ioaccel2_alloc_cmds_and_bft(h))
+		if (hpsa_alloc_ioaccel2_cmd_and_bft(h))
 			goto clean_up;
 		}
 	}


  parent reply	other threads:[~2015-04-23 14:33 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-23 14:31 [PATCH v5 00/42] hpsa updates Don Brace
2015-04-23 14:31 ` [PATCH v5 01/42] hpsa: add masked physical devices into h->dev[] array Don Brace
2015-04-23 14:31 ` [PATCH v5 02/42] hpsa: clean up host, channel, target, lun prints Don Brace
2015-04-23 14:32 ` [PATCH v5 03/42] hpsa: rework controller command submission Don Brace
2015-04-23 14:32 ` [PATCH v5 04/42] hpsa: clean up aborts Don Brace
2015-04-23 14:32 ` [PATCH v5 05/42] hpsa: decrement h->commands_outstanding in fail_all_outstanding_cmds Don Brace
2015-04-23 14:32 ` [PATCH v5 06/42] hpsa: hpsa decode sense data for io and tmf Don Brace
2015-04-23 14:32 ` [PATCH v5 07/42] hpsa: allow lockup detected to be viewed via sysfs Don Brace
2015-04-23 14:32 ` Don Brace [this message]
2015-04-23 14:32 ` [PATCH v5 09/42] hpsa: factor out hpsa_init_cmd function Don Brace
2015-04-23 14:32 ` [PATCH v5 10/42] hpsa: do not ignore return value of hpsa_register_scsi Don Brace
2015-04-23 14:32 ` [PATCH v5 11/42] hpsa: try resubmitting down raid path on task set full Don Brace
2015-04-23 14:32 ` [PATCH v5 12/42] hpsa: factor out hpsa_ioaccel_submit function Don Brace
2015-04-23 14:32 ` [PATCH v5 13/42] hpsa: print accurate SSD Smart Path Enabled status Don Brace
2015-04-23 14:32 ` [PATCH v5 14/42] hpsa: use ioaccel2 path to submit IOs to physical drives in HBA mode Don Brace
2015-04-23 14:33 ` [PATCH v5 15/42] hpsa: Get queue depth from identify physical bmic for physical disks Don Brace
2015-04-23 14:33 ` [PATCH v5 16/42] hpsa: break hpsa_free_irqs_and_disable_msix into two functions Don Brace
2015-04-23 14:33 ` [PATCH v5 17/42] hpsa: clean up error handling Don Brace
2015-04-23 14:33 ` [PATCH v5 18/42] hpsa: refactor freeing of resources into more logical functions Don Brace
2015-04-23 14:33 ` [PATCH v5 19/42] hpsa: add ioaccel sg chaining for the ioaccel2 path Don Brace
2015-04-23 14:33 ` [PATCH v5 20/42] hpsa: add more ioaccel2 error handling, including underrun statuses Don Brace
2015-04-23 14:33 ` [PATCH v5 21/42] hpsa: do not check cmd_alloc return value - it cannnot return NULL Don Brace
2015-04-23 14:33 ` [PATCH v5 22/42] hpsa: correct return values from driver functions Don Brace
2015-04-23 14:33 ` [PATCH v5 23/42] hpsa: clean up driver init Don Brace
2015-04-23 14:33 ` [PATCH v5 24/42] hpsa: clean up some error reporting output in abort handler Don Brace
2015-04-23 14:34 ` [PATCH v5 25/42] hpsa: do not print ioaccel2 warning messages about unusual completions Don Brace
2015-04-23 14:34 ` [PATCH v5 26/42] hpsa: add support sending aborts to physical devices via the ioaccel2 path Don Brace
2015-04-23 14:34 ` [PATCH v5 27/42] hpsa: use helper routines for finishing commands Don Brace
2015-04-23 14:34 ` [PATCH v5 28/42] hpsa: don't return abort request until target is complete Don Brace
2015-04-23 14:34 ` [PATCH v5 29/42] hpsa: refactor and rework support for sending TEST_UNIT_READY Don Brace
2015-04-23 14:34 ` [PATCH v5 30/42] hpsa: performance tweak for hpsa_scatter_gather() Don Brace
2015-04-23 14:34 ` [PATCH v5 31/42] hpsa: call pci_release_regions after pci_disable_device Don Brace
2015-04-23 14:34 ` [PATCH v5 32/42] hpsa: skip free_irq calls if irqs are not allocated Don Brace
2015-04-23 14:34 ` [PATCH v5 33/42] hpsa: cleanup for init_one step 2 in kdump Don Brace
2015-04-23 14:34 ` [PATCH v5 34/42] hpsa: fix try_soft_reset error handling Don Brace
2015-04-23 14:34 ` [PATCH v5 35/42] hpsa: create workqueue after the driver is ready for use Don Brace
2015-04-23 14:34 ` [PATCH v5 36/42] hpsa: add interrupt number to /proc/interrupts interrupt name Don Brace
2015-04-23 14:35 ` [PATCH v5 37/42] hpsa: use block layer tag for command allocation Don Brace
2015-04-23 14:35 ` [PATCH v5 38/42] hpsa: use scsi host_no as hpsa controller number Don Brace
2015-04-23 14:35 ` [PATCH v5 39/42] hpsa: propagate the error code in hpsa_kdump_soft_reset Don Brace
2015-04-23 14:35 ` [PATCH v5 40/42] hpsa: cleanup reset Don Brace
2015-04-23 14:35 ` [PATCH v5 41/42] hpsa: add in new controller id Don Brace
2015-04-23 14:35 ` [PATCH v5 42/42] hpsa: change driver version Don Brace
2015-05-11  9:13 ` [PATCH v5 00/42] hpsa updates Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150423143227.18832.47653.stgit@brunhilda \
    --to=don.brace@pmcs.com \
    --cc=Justin.Lindley@pmcs.com \
    --cc=Kevin.Barnett@pmcs.com \
    --cc=brace@pmcs.com \
    --cc=hch@infradead.org \
    --cc=james.bottomley@parallels.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=scott.teel@pmcs.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox