Re: [PATCH 20/37] scsi: leapraid: use 16-bits defined sense codes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [High] The driver synthesizes a CHECK_CONDITION for REPORT_LUNS when a data underrun occurs but fails to update `scmd->result`.
--

commit 909befd157ab89fe2f70728b01ba29158ee9d0b5
Author: Damien Le Moal <dlemoal@kernel.org>

scsi: leapraid: use 16-bits defined sense codes

This refactors the leapraid driver to use the 16-bit sense_code field
of struct scsi_sense_hdr and replaces all hard-coded additional sense
codes with enum values. It deletes the locally defined macros for ASC
and ASCQ values in favor of standard definitions.

> diff --git a/drivers/scsi/leapraid/leapraid_os.c b/drivers/scsi/leapraid/leapraid_os.c
> index ee3242779dfdf..eb8b114399231 100644
> --- a/drivers/scsi/leapraid/leapraid_os.c
> +++ b/drivers/scsi/leapraid/leapraid_os.c
[ ... ]
> @@ -382,9 +382,8 @@ static void leapraid_handle_data_underrun(
>  	} else if (!xfer_cnt && scmd->cmnd[0] == REPORT_LUNS) {
>  		scsiio_rep->scsi_state = LEAPRAID_SCSI_STATE_AUTOSENSE_VALID;
>  		scsiio_rep->scsi_status = SAM_STAT_CHECK_CONDITION;
> -		scsi_build_sense(scmd, 0, ILLEGAL_REQUEST,
> -				 LEAPRAID_SCSI_ASC_INVALID_CMD_CODE,
> -				 LEAPRAID_SCSI_ASCQ_DEFAULT);
> +		scsi_set_sense(scmd, 0, ILLEGAL_REQUEST,
> +			       INVALID_COMMAND_OP_CODE);

[Severity: High]
This is a pre-existing issue, but should this code also update scmd->result
with the new status?

Because scmd->result is not updated with SAM_STAT_CHECK_CONDITION in
leapraid_handle_data_underrun(), it retains the initial DID_OK | scsi_status
(which is typically 0 here). 

Doesn't this cause leapraid_scsiio_done_dispatch() to return early, hiding
the synthesized ILLEGAL_REQUEST sense data from the SCSI midlayer and
breaking LUN discovery when a data underrun occurs?

>  	}
>  }

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260831020451.585944-1-dlemoal@kernel.org?part=20