Re: [PATCH 00/37] Use defined 16-bits ASC/ASCQ combinations

[Damien Le Moal <dlemoal@kernel.org>]

On 8/31/26 11:04, Damien Le Moal wrote:
> Martin, James,
> 
> This patch series defines as macros all ASC/ASCQ combinations present in
> https://www.t10.org/lists/asc-num.txt and converts the SCSI core code and
> SCSI low level drivers to use these macros instead of hard-coded
> ASC/ASCQs. To do this, struct scsi_sense_hdr and struct scsi_failure are
> modified to replace the asc and ascq 8-bits fields with a 16-bits
> sense_code field.
> 
> This cleans up the code in many places and makes it easier, and self
> documented, to test sense codes in the case of errors.
> 
> Overall, there should be no functional chnages here.

Sashiko pointed out a couple of valid mistakes in this series that I fixed
locally. I will wait for further comments before sending v2.

Sashiko also pointed out further pre-existing issues that I am not going to
address with this series.


-- 
Damien Le Moal
Western Digital Research