Re: [PATCH 07/37] scsi: core: use 16-bits defined sense codes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `scsi_cmd_done_timeout_template` trace event incorrectly assigns the ASC value to the ASCQ field, causing a loss of ASCQ trace data.
--

commit 18b8d3cbe68a6be05817a223fa4182ba612faa08
Author: Damien Le Moal <dlemoal@kernel.org>
Subject: scsi: core: use 16-bits defined sense codes

This commit refactors the SCSI core code to use the 16-bit sense_code field
of struct scsi_sense_hdr and struct scsi_failure. Hard-coded additional sense
codes and qualifiers are replaced with enum values from scsi_sense.h to
improve clarity.

> diff --git a/include/trace/events/scsi.h b/include/trace/events/scsi.h
> index c36c72ab7f2bf..4d17c9b61e44a 100644
> --- a/include/trace/events/scsi.h
> +++ b/include/trace/events/scsi.h
> @@ -303,8 +303,8 @@ DECLARE_EVENT_CLASS(scsi_cmd_done_timeout_template,
>  		if (cmd->sense_buffer && SCSI_SENSE_VALID(cmd) &&
>  		    scsi_command_normalize_sense(cmd, &sshdr)) {
>  			__entry->sense_key = sshdr.sense_key;
> -			__entry->asc = sshdr.asc;
> -			__entry->ascq = sshdr.ascq;
> +			__entry->asc = scsi_sense_asc(&sshdr);
> +			__entry->ascq = scsi_sense_asc(&sshdr);
                                        ^^^^^^^^^^^^^^

[Severity: Medium]
Does this code assign the wrong value to the ascq field? 

It looks like scsi_sense_asc() is called instead of scsi_sense_ascq(),
which would cause the trace event to duplicate the asc byte and lose
the actual ascq trace data when a SCSI command completes or times out
with valid sense data.

>  		} else {
>  			__entry->sense_key = 0;
>  			__entry->asc = 0;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260831020451.585944-1-dlemoal@kernel.org?part=7