[PATCH] ieee1394: sbp2: remove bogus "emulated" host flag

[PATCH] ieee1394: sbp2: remove bogus "emulated" host flag

[Stefan Richter]

There is no emulation going on here.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
---
Index: linux/drivers/ieee1394/sbp2.c
===================================================================
--- linux.orig/drivers/ieee1394/sbp2.c	2007-01-14 15:45:30.000000000 +0100
+++ linux/drivers/ieee1394/sbp2.c	2007-01-14 18:40:08.000000000 +0100
@@ -304,7 +304,6 @@ static struct scsi_host_template sbp2_sh
 	.use_clustering		 = ENABLE_CLUSTERING,
 	.cmd_per_lun		 = SBP2_MAX_CMDS,
 	.can_queue		 = SBP2_MAX_CMDS,
-	.emulated		 = 1,
 	.sdev_attrs		 = sbp2_sysfs_sdev_attrs,
 };
 

-- 
Stefan Richter
-=====-=-=== ---= -===-
http://arcgraph.de/sr/


-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

Re: [PATCH] ieee1394: sbp2: remove bogus "emulated" host flag

[Kristian Høgsberg]

On 1/14/07, Stefan Richter <stefanr@s5r6.in-berlin.de> wrote:
> There is no emulation going on here.
...

> -       .emulated                = 1,

Not sure what this flag does, but I copied it over to fw-sbp2.c.  If
it's bogus, I guess we should drop it from fw-sbp2.c too.

Kristian

Re: [PATCH] ieee1394: sbp2: remove bogus "emulated" host flag

[Douglas Gilbert]

Kristian Høgsberg wrote:
> On 1/14/07, Stefan Richter <stefanr@s5r6.in-berlin.de> wrote:
>> There is no emulation going on here.
> ...
> 
>> -       .emulated                = 1,
> 
> Not sure what this flag does, but I copied it over to fw-sbp2.c.  If
> it's bogus, I guess we should drop it from fw-sbp2.c too.

Kristian,
The 'emulated' flag dates from the original ide-scsi
driver (lk 2.0 series or earlier) when some app wanted
to know if there was a "real" SCSI cd drive attached
or a fudged one (i.e. ATAPI) via the ide-scsi bridging
driver. So it is unclear to me why the sbp driver
(and USB mass storage) sets emulated.

Hopefully if any app cares these days there are much
better ways to find out what the transport is. Also
now we have the transport the LLD can see
and the transport the device (i.e. logical unit) can
see; and they aren't necessarily the same. In the
case of a CD/DVD drive there is the GET CONFIGURATION
command for finding out what the lu can see:
$ sg_get_config /dev/hdc
  HL-DT-ST  RW/DVD GCC-4242N  0201
  Peripheral device type: cd/dvd
No current profile
Features:
  Profile list feature
    version=0, persist=1, current=1 [0x0]
    available profiles [more recent typically higher in list]:
      profile: DVD-ROM , currentP=0
      profile: CD-ROM , currentP=0
      profile: CD-R , currentP=0
      profile: CD-RW , currentP=0
  Core feature
    version=0, persist=1, current=1 [0x1]
      Physical interface standard: ATAPI
......

So IMO 'emulated' is best retired.

Doug Gilbert

-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ieee1394: sbp2: remove bogus "emulated" host flag

[Kristian Høgsberg]

On 1/15/07, Douglas Gilbert <dougg@torque.net> wrote:
> Kristian Høgsberg wrote:
> > On 1/14/07, Stefan Richter <stefanr@s5r6.in-berlin.de> wrote:
> >> There is no emulation going on here.
> > ...
> >
> >> -       .emulated                = 1,
> >
> > Not sure what this flag does, but I copied it over to fw-sbp2.c.  If
> > it's bogus, I guess we should drop it from fw-sbp2.c too.
>
> Kristian,
> The 'emulated' flag dates from the original ide-scsi
> driver (lk 2.0 series or earlier) when some app wanted
> to know if there was a "real" SCSI cd drive attached
> or a fudged one (i.e. ATAPI) via the ide-scsi bridging
> driver. So it is unclear to me why the sbp driver
> (and USB mass storage) sets emulated.
...
> So IMO 'emulated' is best retired.

Ah, thanks for the explanation.  It sounds like it doesn't do much
harm whatever it's set to.  But if it's deprecated/retired, let's just
get rid of it.

thanks,
Kristian
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
mailing list linux1394-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux1394-devel

Re: [PATCH] ieee1394: sbp2: remove bogus "emulated" host flag

[Stefan Richter]

On 15 Jan, Kristian Høgsberg wrote:
> On 1/14/07, Stefan Richter <stefanr@s5r6.in-berlin.de> wrote:
>> There is no emulation going on here.
> ...
> 
>> -       .emulated                = 1,
> 
> Not sure what this flag does, but I copied it over to fw-sbp2.c.

There is a single use: Userspace application clients can look up the
value of this flag via the sg driver and can then come to whatever
conclusions.

> If it's bogus,

The flag was "half true" back in the times when sbp2 mangled a lot of
commands and responses to account for command sets behind the back of
the SCSI stack. That's not the case any more.

> I guess we should drop it from fw-sbp2.c too.

Yes. I merely didn't ready a patch because I currently want to
concentrate my SBP-2 related work on sbp2 and push relevant bits over to
fw-sbp2 some time later in one go, as far as you didn't do so already.
(I'll send a parallel fw-sbp2 patch too if something earthshaking comes
along.)
-- 
Stefan Richter
-=====-=-=== ---= -====
http://arcgraph.de/sr/

-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html