public inbox for linux-serial@vger.kernel.org
 help / color / mirror / Atom feed
From: ruihongluo <colorsu1922@gmail.com>
To: andriy.shevchenko@linux.intel.com
Cc: colorsu1922@gmail.com, gregkh@linuxfoundation.org,
	ilpo.jarvinen@linux.intel.com, jirislaby@kernel.org,
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
	luoruihong@xiaomi.com, wengjinfei@xiaomi.com,
	weipengliang@xiaomi.com
Subject: [PATCH v2 1/1] serial: 8250: Preserve original value of DLF register
Date: Thu, 29 Jun 2023 17:42:05 +0800	[thread overview]
Message-ID: <20230629094204.60246-1-luoruihong@xiaomi.com> (raw)
In-Reply-To: <ZJ1M5QvyWzgWNlpE@smile.fi.intel.com>

This commit is aimed at preserving the original value of the
DLF(Divisor Latch Fraction Register). When the DLF register is
modified without preservation, it can disrupt the baudrate settings
established by firmware or bootloader , leading to data corruption
and the generation of unreadable or distorted characters.

Fixes: 701c5e73b296 ("serial: 8250_dw: add fractional divisor support")

Signed-off-by: ruihongluo <luoruihong@xiaomi.com>
---
v2:
- added fixes tag
 
 drivers/tty/serial/8250/8250_dwlib.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/tty/serial/8250/8250_dwlib.c b/drivers/tty/serial/8250/8250_dwlib.c
index 75f32f054ebb..d30957722da8 100644
--- a/drivers/tty/serial/8250/8250_dwlib.c
+++ b/drivers/tty/serial/8250/8250_dwlib.c
@@ -244,7 +244,7 @@ void dw8250_setup_port(struct uart_port *p)
 	struct dw8250_port_data *pd = p->private_data;
 	struct dw8250_data *data = to_dw8250_data(pd);
 	struct uart_8250_port *up = up_to_u8250p(p);
-	u32 reg;
+	u32 reg, orig;
 
 	pd->hw_rs485_support = dw8250_detect_rs485_hw(p);
 	if (pd->hw_rs485_support) {
@@ -270,9 +270,11 @@ void dw8250_setup_port(struct uart_port *p)
 	dev_dbg(p->dev, "Designware UART version %c.%c%c\n",
 		(reg >> 24) & 0xff, (reg >> 16) & 0xff, (reg >> 8) & 0xff);
 
+	/* Preserve value written by firmware or bootloader  */
+	orig = dw8250_readl_ext(p, DW_UART_DLF);
 	dw8250_writel_ext(p, DW_UART_DLF, ~0U);
 	reg = dw8250_readl_ext(p, DW_UART_DLF);
-	dw8250_writel_ext(p, DW_UART_DLF, 0);
+	dw8250_writel_ext(p, DW_UART_DLF, orig);
 
 	if (reg) {
 		pd->dlf_size = fls(reg);
-- 
Just wanted to drop a quick note to say thanks for your help with git
send-email and code modifications.
Your assistance on the details was much appreciated.

Best regards,
Ruihong Luo


  reply	other threads:[~2023-06-29  9:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-28 15:21 [PATCH v1 1/1] serial: 8250: Preserve original value of DLF register ruihongluo
2023-06-29  9:20 ` Andy Shevchenko
2023-06-29  9:42   ` ruihongluo [this message]
2023-06-29 11:06     ` [PATCH v2 " Andy Shevchenko
2023-06-29 12:35       ` [PATCH v2] " Ruihong Luo
2023-06-29 13:06         ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230629094204.60246-1-luoruihong@xiaomi.com \
    --to=colorsu1922@gmail.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=jirislaby@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=luoruihong@xiaomi.com \
    --cc=weipengliang@xiaomi.com \
    --cc=wengjinfei@xiaomi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox