Re: [PATCH v1 1/1] serial: 8250: Preserve original value of DLF register

[Andy Shevchenko <andriy.shevchenko@linux.intel.com>]

On Wed, Jun 28, 2023 at 11:21:37PM +0800, ruihongluo wrote:
> This commit is aimed at preserving the original value of the

"This commit is aimed at preserving the original..." -->
"Preserve the original..."

> DLF(Divisor Latch Fraction Register). When the DLF register is
> modified without preservation, it can disrupt the baudrate settings
> established by firmware or bootloader , leading to data corruption
> and the generation of unreadable or distorted characters.

You have From different to SoB. You need to fix this.
It can be done by setting corresponding values in the ~/.gitconfig
of your machine where you are making patches on.

Quick fix is to run

	git commit --amend --author="ruihongluo <luoruihong@xiaomi.com>"

and resend as a v2.

Code wise looks good to me, thank you for fixing this.
Perhaps it needs a Fixes tag, as

Fixes: 701c5e73b296 ("serial: 8250_dw: add fractional divisor support")

added before your SoB line. (Again, use `git commit --amend` to address
this.)

> Signed-off-by: ruihongluo <luoruihong@xiaomi.com>
> ---

Also don't forget to add a changelog here for v2 to describe your changes.

-- 
With Best Regards,
Andy Shevchenko