From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: ruihongluo <colorsu1922@gmail.com>
Cc: gregkh@linuxfoundation.org, ilpo.jarvinen@linux.intel.com,
jirislaby@kernel.org, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org, luoruihong@xiaomi.com,
wengjinfei@xiaomi.com, weipengliang@xiaomi.com
Subject: Re: [PATCH v2 1/1] serial: 8250: Preserve original value of DLF register
Date: Thu, 29 Jun 2023 14:06:19 +0300 [thread overview]
Message-ID: <ZJ1lq8mVU8NbZRcV@smile.fi.intel.com> (raw)
In-Reply-To: <20230629094204.60246-1-luoruihong@xiaomi.com>
On Thu, Jun 29, 2023 at 05:42:05PM +0800, ruihongluo wrote:
> This commit is aimed at preserving the original value of the
> DLF(Divisor Latch Fraction Register). When the DLF register is
> modified without preservation, it can disrupt the baudrate settings
> established by firmware or bootloader , leading to data corruption
> and the generation of unreadable or distorted characters.
> Fixes: 701c5e73b296 ("serial: 8250_dw: add fractional divisor support")
>
To make it a tag you should avoid blank lines in the tag block.
> Signed-off-by: ruihongluo <luoruihong@xiaomi.com>
> ---
> v2:
> - added fixes tag
Actually not. See above.
And what about the rest of the comments?
...
> Just wanted to drop a quick note to say thanks for your help with git
> send-email and code modifications.
> Your assistance on the details was much appreciated.
You're welcome!
> Ruihong Luo
This seems needs to be in your Git config:
$ cat ~/.gitconfig
[user]
name = Ruihong Luo
email = luoruihon@xiaomi.com
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-06-29 11:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-28 15:21 [PATCH v1 1/1] serial: 8250: Preserve original value of DLF register ruihongluo
2023-06-29 9:20 ` Andy Shevchenko
2023-06-29 9:42 ` [PATCH v2 " ruihongluo
2023-06-29 11:06 ` Andy Shevchenko [this message]
2023-06-29 12:35 ` [PATCH v2] " Ruihong Luo
2023-06-29 13:06 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJ1lq8mVU8NbZRcV@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=colorsu1922@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=luoruihong@xiaomi.com \
--cc=weipengliang@xiaomi.com \
--cc=wengjinfei@xiaomi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox