From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Ruihong Luo <colorsu1922@gmail.com>
Cc: gregkh@linuxfoundation.org, ilpo.jarvinen@linux.intel.com,
jirislaby@kernel.org, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org, luoruihong@xiaomi.com,
weipengliang@xiaomi.com, wengjinfei@xiaomi.com
Subject: Re: [PATCH v2] serial: 8250: Preserve original value of DLF register
Date: Thu, 29 Jun 2023 16:06:48 +0300 [thread overview]
Message-ID: <ZJ2B6I+ShqyJJJ+o@smile.fi.intel.com> (raw)
In-Reply-To: <20230629123529.62232-1-luoruihong@xiaomi.com>
On Thu, Jun 29, 2023 at 08:35:30PM +0800, Ruihong Luo wrote:
> This commit is aimed at preserving the original value of the
Preserve the original value...
> DLF(Divisor Latch Fraction Register). When the DLF register is
Divisor Latch Fraction (DLF) register...
> modified without preservation, it can disrupt the baudrate settings
> established by firmware or bootloader , leading to data corruption
...bootloader, leading...
> and the generation of unreadable or distorted characters.
> Fixes: 701c5e73b296 ("serial: 8250_dw: add fractional divisor support")
> Signed-off-by: Ruihong Luo <luoruihong@xiaomi.com>
> ---
> v2:
> - add a tag
It's a v3 and still some comments are not (yet) addressed:
1) your from header in email != SoB;
2) do not use In-reply-to email header for the new patch versions;
3) the commit message should be amended as I pointed out above again.
It will go nowhere if you continue ignoring reviewers' comments.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-06-29 13:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-28 15:21 [PATCH v1 1/1] serial: 8250: Preserve original value of DLF register ruihongluo
2023-06-29 9:20 ` Andy Shevchenko
2023-06-29 9:42 ` [PATCH v2 " ruihongluo
2023-06-29 11:06 ` Andy Shevchenko
2023-06-29 12:35 ` [PATCH v2] " Ruihong Luo
2023-06-29 13:06 ` Andy Shevchenko [this message]
[not found] <tencent_CE78164E0DD743EAA6FD70A1D7F8565F9609@qq.com>
2023-08-09 11:47 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJ2B6I+ShqyJJJ+o@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=colorsu1922@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=luoruihong@xiaomi.com \
--cc=weipengliang@xiaomi.com \
--cc=wengjinfei@xiaomi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox