Linux Serial subsystem development
 help / color / mirror / Atom feed
From: Pan Chuang <panchuang@vivo.com>
To: "Al Cooper" <alcooperx@gmail.com>,
	"Broadcom internal kernel review list"
	<bcm-kernel-feedback-list@broadcom.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Jiri Slaby" <jirislaby@kernel.org>,
	"Frank Li" <Frank.Li@nxp.com>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"Pengutronix Kernel Team" <kernel@pengutronix.de>,
	"Fabio Estevam" <festevam@gmail.com>,
	"Pali Rohár" <pali@kernel.org>,
	"Orson Zhai" <orsonzhai@gmail.com>,
	"Baolin Wang" <baolin.wang@linux.alibaba.com>,
	"Chunyan Zhang" <zhang.lyra@gmail.com>,
	"Sherry Sun" <sherry.sun@nxp.com>,
	"Pan Chuang" <panchuang@vivo.com>,
	"Robin Gong" <yibin.gong@nxp.com>,
	"Cixi Geng" <cixi.geng@linux.dev>,
	"Wenhua Lin" <Wenhua.Lin@unisoc.com>,
	linux-serial@vger.kernel.org (open list:BROADCOM BRCMSTB UART
	DRIVER),
	linux-kernel@vger.kernel.org (open list:TTY LAYER AND SERIAL
	DRIVERS),
	imx@lists.linux.dev (open list:ARM/FREESCALE IMX / MXC ARM
	ARCHITECTURE),
	linux-arm-kernel@lists.infradead.org (moderated
	list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE)
Subject: [PATCH 0/5] serial: Remove redundant error messages on IRQ request failure
Date: Wed, 22 Jul 2026 11:43:28 +0800	[thread overview]
Message-ID: <20260722034342.316755-1-panchuang@vivo.com> (raw)

Commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()") added automatic error logging to
devm_request_threaded_irq() and devm_request_any_context_irq()
via the new devm_request_result() helper, which prints device
name, IRQ number, handler functions, and error code on failure.

Since devm_request_irq() is a static inline wrapper around
devm_request_threaded_irq(), it also benefits from this
automatic logging.

Remove the now-redundant dev_err() and dev_err_probe() calls
in tty drivers that follow these devm_request_*_irq()
functions, as the core now provides more detailed diagnostic
information on failure.

Pan Chuang (5):
  serial: 8250_bcm7271: Remove redundant dev_err_probe()
  serial: imx: Remove redundant dev_err()
  serial: mvebu-uart: Remove redundant dev_err()
  serial: mctrl_gpio: Remove redundant dev_err()
  serial: sprd: Remove redundant dev_err()

 drivers/tty/serial/8250/8250_bcm7271.c |  4 +---
 drivers/tty/serial/imx.c               | 19 ++++---------------
 drivers/tty/serial/mvebu-uart.c        | 12 ++----------
 drivers/tty/serial/serial_mctrl_gpio.c |  3 ---
 drivers/tty/serial/sprd_serial.c       |  5 +----
 5 files changed, 8 insertions(+), 35 deletions(-)

-- 
2.34.1


             reply	other threads:[~2026-07-22  3:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-22  3:43 Pan Chuang [this message]
2026-07-22  3:43 ` [PATCH 1/5] serial: 8250_bcm7271: Remove redundant dev_err_probe() Pan Chuang
2026-07-22  3:43 ` [PATCH 2/5] serial: imx: Remove redundant dev_err() Pan Chuang
2026-07-22  3:43 ` [PATCH 3/5] serial: mvebu-uart: " Pan Chuang
2026-07-22  3:43 ` [PATCH 4/5] serial: mctrl_gpio: " Pan Chuang
2026-07-22  3:43 ` [PATCH 5/5] serial: sprd: " Pan Chuang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260722034342.316755-1-panchuang@vivo.com \
    --to=panchuang@vivo.com \
    --cc=Frank.Li@nxp.com \
    --cc=Wenhua.Lin@unisoc.com \
    --cc=alcooperx@gmail.com \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=cixi.geng@linux.dev \
    --cc=festevam@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=imx@lists.linux.dev \
    --cc=jirislaby@kernel.org \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=orsonzhai@gmail.com \
    --cc=pali@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=sherry.sun@nxp.com \
    --cc=yibin.gong@nxp.com \
    --cc=zhang.lyra@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox