From: Pan Chuang <panchuang@vivo.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>, Frank Li <Frank.Li@nxp.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Sherry Sun <sherry.sun@nxp.com>, Robin Gong <yibin.gong@nxp.com>,
Pan Chuang <panchuang@vivo.com>,
linux-kernel@vger.kernel.org (open list:TTY LAYER AND SERIAL
DRIVERS),
linux-serial@vger.kernel.org (open list:TTY LAYER AND SERIAL
DRIVERS),
imx@lists.linux.dev (open list:ARM/FREESCALE IMX / MXC ARM
ARCHITECTURE),
linux-arm-kernel@lists.infradead.org (moderated
list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE)
Subject: [PATCH 2/5] serial: imx: Remove redundant dev_err()
Date: Wed, 22 Jul 2026 11:43:30 +0800 [thread overview]
Message-ID: <20260722034342.316755-3-panchuang@vivo.com> (raw)
In-Reply-To: <20260722034342.316755-1-panchuang@vivo.com>
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/tty/serial/imx.c | 19 ++++---------------
1 file changed, 4 insertions(+), 15 deletions(-)
diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
index 251a50c8aa38..95fdb60e06a7 100644
--- a/drivers/tty/serial/imx.c
+++ b/drivers/tty/serial/imx.c
@@ -2602,34 +2602,23 @@ static int imx_uart_probe(struct platform_device *pdev)
if (txirq > 0) {
ret = devm_request_irq(&pdev->dev, rxirq, imx_uart_rxint, 0,
dev_name(&pdev->dev), sport);
- if (ret) {
- dev_err(&pdev->dev, "failed to request rx irq: %d\n",
- ret);
+ if (ret)
goto err_clk;
- }
ret = devm_request_irq(&pdev->dev, txirq, imx_uart_txint, 0,
dev_name(&pdev->dev), sport);
- if (ret) {
- dev_err(&pdev->dev, "failed to request tx irq: %d\n",
- ret);
+ if (ret)
goto err_clk;
- }
ret = devm_request_irq(&pdev->dev, rtsirq, imx_uart_rtsint, 0,
dev_name(&pdev->dev), sport);
- if (ret) {
- dev_err(&pdev->dev, "failed to request rts irq: %d\n",
- ret);
+ if (ret)
goto err_clk;
- }
} else {
ret = devm_request_irq(&pdev->dev, rxirq, imx_uart_int, 0,
dev_name(&pdev->dev), sport);
- if (ret) {
- dev_err(&pdev->dev, "failed to request irq: %d\n", ret);
+ if (ret)
goto err_clk;
- }
}
imx_uart_ports[sport->port.line] = sport;
--
2.34.1
next prev parent reply other threads:[~2026-07-22 3:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-22 3:43 [PATCH 0/5] serial: Remove redundant error messages on IRQ request failure Pan Chuang
2026-07-22 3:43 ` [PATCH 1/5] serial: 8250_bcm7271: Remove redundant dev_err_probe() Pan Chuang
2026-07-22 3:43 ` Pan Chuang [this message]
2026-07-22 3:43 ` [PATCH 3/5] serial: mvebu-uart: Remove redundant dev_err() Pan Chuang
2026-07-22 3:43 ` [PATCH 4/5] serial: mctrl_gpio: " Pan Chuang
2026-07-22 3:43 ` [PATCH 5/5] serial: sprd: " Pan Chuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260722034342.316755-3-panchuang@vivo.com \
--to=panchuang@vivo.com \
--cc=Frank.Li@nxp.com \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=imx@lists.linux.dev \
--cc=jirislaby@kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sherry.sun@nxp.com \
--cc=yibin.gong@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox