From: Pan Chuang <panchuang@vivo.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
Orson Zhai <orsonzhai@gmail.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Chunyan Zhang <zhang.lyra@gmail.com>,
Pan Chuang <panchuang@vivo.com>, Cixi Geng <cixi.geng@linux.dev>,
Wenhua Lin <Wenhua.Lin@unisoc.com>,
linux-kernel@vger.kernel.org (open list:TTY LAYER AND SERIAL
DRIVERS),
linux-serial@vger.kernel.org (open list:TTY LAYER AND SERIAL
DRIVERS)
Subject: [PATCH 5/5] serial: sprd: Remove redundant dev_err()
Date: Wed, 22 Jul 2026 11:43:33 +0800 [thread overview]
Message-ID: <20260722034342.316755-6-panchuang@vivo.com> (raw)
In-Reply-To: <20260722034342.316755-1-panchuang@vivo.com>
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() call.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/tty/serial/sprd_serial.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/tty/serial/sprd_serial.c b/drivers/tty/serial/sprd_serial.c
index 092755f35683..3fdf5939a62c 100644
--- a/drivers/tty/serial/sprd_serial.c
+++ b/drivers/tty/serial/sprd_serial.c
@@ -741,11 +741,8 @@ static int sprd_startup(struct uart_port *port)
ret = devm_request_irq(port->dev, port->irq, sprd_handle_irq,
IRQF_SHARED, sp->name, port);
- if (ret) {
- dev_err(port->dev, "fail to request serial irq %d, ret=%d\n",
- port->irq, ret);
+ if (ret)
return ret;
- }
fc = serial_in(port, SPRD_CTL1);
fc |= RX_TOUT_THLD_DEF | RX_HFC_THLD_DEF;
serial_out(port, SPRD_CTL1, fc);
--
2.34.1
prev parent reply other threads:[~2026-07-22 3:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-22 3:43 [PATCH 0/5] serial: Remove redundant error messages on IRQ request failure Pan Chuang
2026-07-22 3:43 ` [PATCH 1/5] serial: 8250_bcm7271: Remove redundant dev_err_probe() Pan Chuang
2026-07-22 3:43 ` [PATCH 2/5] serial: imx: Remove redundant dev_err() Pan Chuang
2026-07-22 3:43 ` [PATCH 3/5] serial: mvebu-uart: " Pan Chuang
2026-07-22 3:43 ` [PATCH 4/5] serial: mctrl_gpio: " Pan Chuang
2026-07-22 3:43 ` Pan Chuang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260722034342.316755-6-panchuang@vivo.com \
--to=panchuang@vivo.com \
--cc=Wenhua.Lin@unisoc.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=cixi.geng@linux.dev \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox