From: Pan Chuang <panchuang@vivo.com>
To: Al Cooper <alcooperx@gmail.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
linux-serial@vger.kernel.org (open list:BROADCOM BRCMSTB UART
DRIVER),
linux-kernel@vger.kernel.org (open list:TTY LAYER AND SERIAL
DRIVERS)
Cc: Pan Chuang <panchuang@vivo.com>
Subject: [PATCH 1/5] serial: 8250_bcm7271: Remove redundant dev_err_probe()
Date: Wed, 22 Jul 2026 11:43:29 +0800 [thread overview]
Message-ID: <20260722034342.316755-2-panchuang@vivo.com> (raw)
In-Reply-To: <20260722034342.316755-1-panchuang@vivo.com>
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err_probe() call.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/tty/serial/8250/8250_bcm7271.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/tty/serial/8250/8250_bcm7271.c b/drivers/tty/serial/8250/8250_bcm7271.c
index 742004d63c6f..cb7d594d263e 100644
--- a/drivers/tty/serial/8250/8250_bcm7271.c
+++ b/drivers/tty/serial/8250/8250_bcm7271.c
@@ -1099,10 +1099,8 @@ static int brcmuart_probe(struct platform_device *pdev)
}
ret = devm_request_irq(dev, dma_irq, brcmuart_isr,
IRQF_SHARED, "uart DMA irq", &new_port->port);
- if (ret) {
- dev_err_probe(dev, ret, "unable to register IRQ handler\n");
+ if (ret)
goto err1;
- }
}
platform_set_drvdata(pdev, priv);
brcmuart_init_debugfs(priv, dev_name(&pdev->dev));
--
2.34.1
next prev parent reply other threads:[~2026-07-22 3:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-22 3:43 [PATCH 0/5] serial: Remove redundant error messages on IRQ request failure Pan Chuang
2026-07-22 3:43 ` Pan Chuang [this message]
2026-07-22 3:43 ` [PATCH 2/5] serial: imx: Remove redundant dev_err() Pan Chuang
2026-07-22 3:43 ` [PATCH 3/5] serial: mvebu-uart: " Pan Chuang
2026-07-22 3:43 ` [PATCH 4/5] serial: mctrl_gpio: " Pan Chuang
2026-07-22 3:43 ` [PATCH 5/5] serial: sprd: " Pan Chuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260722034342.316755-2-panchuang@vivo.com \
--to=panchuang@vivo.com \
--cc=alcooperx@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox