Re: [PATCH] ARM: shmobile: Add Lager clock workarounds for SDHI and MMCIF

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Magnus,

On Wednesday 19 March 2014 10:03:32 Magnus Damm wrote:
> On Tue, Mar 18, 2014 at 10:25 PM, Laurent Pinchart wrote:
> > On Tuesday 18 March 2014 21:52:47 Magnus Damm wrote:
> >> From: Magnus Damm <damm@opensource.se>
> >> 
> >> Add MMCIF1, SDHI0 and SDHI2 to the clock workaround list for
> >> Lager multiplatform. Without these additional lines wakeup
> >> from Suspend-to-RAM never happens.
> > 
> > What about fixing the root cause instead of piling up hacks ?
> 
> -ENOPATCH? =)
> 
> Perhaps we need to learn what the root cause is before making a proper
> patch?

Sure :-) Could you elaborate a bit on what issue the patch fixes ? Is S2R 
broken completely, only with multiplatform kernels, only when runtime PM is 
enabled ? The commit message isn't very explicit about that.

Ben mentioned that he was working on a workaround to use 
drivers/sh/pm_runtime.c as-is with multi-platform kernels. Assuming the S2R 
problem is limited to multi-platform kernels, I would prefer that workaround 
if that's fine with you as well.

-- 
Regards,

Laurent Pinchart