From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] ARM: shmobile: Add Lager clock workarounds for SDHI and MMCIF
Date: Tue, 18 Mar 2014 13:25:53 +0000 [thread overview]
Message-ID: <1920956.JQLZtHPQVp@avalon> (raw)
In-Reply-To: <20140318125247.21670.94176.sendpatchset@w520>
Hi Magnus,
On Tuesday 18 March 2014 21:52:47 Magnus Damm wrote:
> From: Magnus Damm <damm@opensource.se>
>
> Add MMCIF1, SDHI0 and SDHI2 to the clock workaround list for
> Lager multiplatform. Without these additional lines wakeup
> from Suspend-to-RAM never happens.
What about fixing the root cause instead of piling up hacks ?
> Signed-off-by: Magnus Damm <damm@opensource.se>
> ---
>
> Written against renesas-devel-v3.14-rc7-20140318
>
> arch/arm/mach-shmobile/board-lager-reference.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> --- 0001/arch/arm/mach-shmobile/board-lager-reference.c
> +++ work/arch/arm/mach-shmobile/board-lager-reference.c 2014-03-18
> 19:36:34.000000000 +0900 @@ -114,7 +114,10 @@ static const struct clk_name
> clk_names[]
> static const struct clk_name clk_enables[] __initconst = {
> { "ether", NULL, "ee700000.ethernet" },
> { "msiof1", NULL, "e6e10000.spi" },
> + { "mmcif1", NULL, "ee220000.mmc" },
> { "qspi_mod", NULL, "e6b10000.spi" },
> + { "sdhi0", NULL, "ee100000.sd" },
> + { "sdhi2", NULL, "ee140000.sd" },
> { "thermal", NULL, "e61f0000.thermal" },
> };
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2014-03-18 13:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-18 12:52 [PATCH] ARM: shmobile: Add Lager clock workarounds for SDHI and MMCIF Magnus Damm
2014-03-18 13:25 ` Laurent Pinchart [this message]
2014-03-18 13:48 ` Ben Dooks
2014-03-18 13:59 ` Laurent Pinchart
2014-03-18 14:31 ` Ben Dooks
2014-03-18 15:27 ` Geert Uytterhoeven
2014-03-18 16:03 ` Laurent Pinchart
2014-03-19 0:02 ` Simon Horman
2014-03-19 0:07 ` Simon Horman
2014-03-19 1:03 ` Magnus Damm
2014-03-19 10:01 ` Laurent Pinchart
2014-03-19 12:30 ` Magnus Damm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1920956.JQLZtHPQVp@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox