Re: [PATCH] ARM: shmobile: Add Lager clock workarounds for SDHI and MMCIF

[Simon Horman <horms@verge.net.au>]

On Tue, Mar 18, 2014 at 02:25:53PM +0100, Laurent Pinchart wrote:
> Hi Magnus,
> 
> On Tuesday 18 March 2014 21:52:47 Magnus Damm wrote:
> > From: Magnus Damm <damm@opensource.se>
> > 
> > Add MMCIF1, SDHI0 and SDHI2 to the clock workaround list for
> > Lager multiplatform. Without these additional lines wakeup
> > from Suspend-to-RAM never happens.
> 
> What about fixing the root cause instead of piling up hacks ?

Hi Laurent,

I agree that hacks are piling up and that this is not entirely
satisfactory. I also agree that we should fix the root cause.
But in the meantime I think it is appropriate to apply work-arounds
so that the code we have works and can be used.

> 
> > Signed-off-by: Magnus Damm <damm@opensource.se>
> > ---
> > 
> >  Written against renesas-devel-v3.14-rc7-20140318
> > 
> >  arch/arm/mach-shmobile/board-lager-reference.c |    3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > --- 0001/arch/arm/mach-shmobile/board-lager-reference.c
> > +++ work/arch/arm/mach-shmobile/board-lager-reference.c	2014-03-18
> > 19:36:34.000000000 +0900 @@ -114,7 +114,10 @@ static const struct clk_name
> > clk_names[]
> >  static const struct clk_name clk_enables[] __initconst = {
> >  	{ "ether", NULL, "ee700000.ethernet" },
> >  	{ "msiof1", NULL, "e6e10000.spi" },
> > +	{ "mmcif1", NULL, "ee220000.mmc" },
> >  	{ "qspi_mod", NULL, "e6b10000.spi" },
> > +	{ "sdhi0", NULL, "ee100000.sd" },
> > +	{ "sdhi2", NULL, "ee140000.sd" },
> >  	{ "thermal", NULL, "e61f0000.thermal" },
> >  };
> 
> -- 
> Regards,
> 
> Laurent Pinchart
>