Re: [RFC 5/5] watchdog: sh_mobile: add driver

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Wolfram,

On Monday 02 February 2015 14:24:44 Wolfram Sang wrote:
> >> +	sh_wdt_start(&priv->wdev);
> >> +	sh_wdt_write(priv, 0xfff0, RWTCNT);
> > 
> > Is there a reason to set the counter to 0xfff0 instead of 0xffff ?
> 
> Giving serial console some time to push out FIFOs. But yeah, it is an
> arbitrary value.

16 cycles as 32.768 kHz would be 488µs. Assuming a 115200 serial baud rate 
that would allow transmission of a bit less than 6 characters. I wonder if 
it's worth it. Shouldn't the restart core code instead flush the serial FIFOs 
explicitly before calling the restart handler if that behaviour is desired ?

> >> +	priv->restart_handler.notifier_call = sh_mobile_wdt_restart_handler;
> >> +	priv->restart_handler.priority = 192;
> > 
> > Just for my information, how did you choose 192 for the priority ?
> 
> Assuming DA9063 is 128, then I wanted to give this priority since it
> doesn't need I2C access which might be stalled.

-- 
Regards,

Laurent Pinchart