From: Wolfram Sang <wsa@the-dreams.de>
To: linux-sh@vger.kernel.org
Subject: Re: [RFC 5/5] watchdog: sh_mobile: add driver
Date: Mon, 02 Feb 2015 13:24:44 +0000 [thread overview]
Message-ID: <20150202132443.GA1994@katana> (raw)
In-Reply-To: <1422802074-1921-6-git-send-email-wsa@the-dreams.de>
[-- Attachment #1: Type: text/plain, Size: 564 bytes --]
> > + sh_wdt_start(&priv->wdev);
> > + sh_wdt_write(priv, 0xfff0, RWTCNT);
>
> Is there a reason to set the counter to 0xfff0 instead of 0xffff ?
Giving serial console some time to push out FIFOs. But yeah, it is an
arbitrary value.
> > + priv->restart_handler.notifier_call = sh_mobile_wdt_restart_handler;
> > + priv->restart_handler.priority = 192;
>
> Just for my information, how did you choose 192 for the priority ?
Assuming DA9063 is 128, then I wanted to give this priority since it
doesn't need I2C access which might be stalled.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-02-02 13:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-01 14:47 [RFC 5/5] watchdog: sh_mobile: add driver Wolfram Sang
2015-02-02 0:28 ` Simon Horman
2015-02-02 1:02 ` Wolfram Sang
2015-02-02 1:54 ` Simon Horman
2015-02-02 9:54 ` Laurent Pinchart
2015-02-02 10:01 ` Geert Uytterhoeven
2015-02-02 10:06 ` Wolfram Sang
2015-02-02 10:09 ` Laurent Pinchart
2015-02-02 11:25 ` Wolfram Sang
2015-02-02 13:24 ` Wolfram Sang [this message]
2015-02-03 8:52 ` Laurent Pinchart
2015-02-03 9:09 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150202132443.GA1994@katana \
--to=wsa@the-dreams.de \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox