Re: [RFC 5/5] watchdog: sh_mobile: add driver

[Wolfram Sang <wsa@the-dreams.de>]

[-- Attachment #1: Type: text/plain, Size: 1056 bytes --]

On Mon, Feb 02, 2015 at 12:09:59PM +0200, Laurent Pinchart wrote:
> Hi Geert,
> 
> On Monday 02 February 2015 11:01:54 Geert Uytterhoeven wrote:
> > On Mon, Feb 2, 2015 at 10:54 AM, Laurent Pinchart wrote:
> > > How about PM (system and runtime) support ? How does the watchdog behave
> > > during system suspend ? You could then replace the clk_prepare_enable()
> > > and
> > > clk_disable_unprepare() calls with pm_runtime_get_sync() and
> > > pm_runtime_put().
> >
> > That's a good question.
> > 
> > If the RWDT MSTP clock is disabled, it can't count, and thus can't trigger.
> 
> I'd still like to test that. MSTP stands for module stop. While this is 
> probably implemented as clock gates in most cases, there is no guarantee that 
> it will always be the case. All MSTP guarantees is that the module is stopped, 
> but the definition of "stopped" isn't explained. The watchdog counter might 
> behave in a special way.

I'll have a look at the SMP case today. All the PM stuff, I'd see as an
incremental update however...


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]