* [PATCH v5 09/14] ARM: shmobile: koelsch: Enable DU device in DT
@ 2014-10-26 14:11 Laurent Pinchart
2015-12-24 19:54 ` Sergei Shtylyov
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Laurent Pinchart @ 2014-10-26 14:11 UTC (permalink / raw)
To: linux-sh
Specify the DU output topology, enable the DU device and configure the
related pins.
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
arch/arm/boot/dts/r8a7791-koelsch.dts | 16 +++++++++++++---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts b/arch/arm/boot/dts/r8a7791-koelsch.dts
index 53184637f160..0402c498b05b 100644
--- a/arch/arm/boot/dts/r8a7791-koelsch.dts
+++ b/arch/arm/boot/dts/r8a7791-koelsch.dts
@@ -212,14 +212,24 @@
};
};
+&du {
+ pinctrl-0 = <&du_pins>;
+ pinctrl-names = "default";
+ status = "okay";
+
+ ports {
+ port@1 {
+ lvds_connector: endpoint {
+ };
+ };
+ };
+};
+
&extal_clk {
clock-frequency = <20000000>;
};
&pfc {
- pinctrl-0 = <&du_pins>;
- pinctrl-names = "default";
-
i2c2_pins: i2c2 {
renesas,groups = "i2c2";
renesas,function = "i2c2";
--
2.0.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v5 09/14] ARM: shmobile: koelsch: Enable DU device in DT
2014-10-26 14:11 [PATCH v5 09/14] ARM: shmobile: koelsch: Enable DU device in DT Laurent Pinchart
@ 2015-12-24 19:54 ` Sergei Shtylyov
2015-12-25 23:45 ` Sergei Shtylyov
2015-12-26 10:53 ` Laurent Pinchart
2 siblings, 0 replies; 4+ messages in thread
From: Sergei Shtylyov @ 2015-12-24 19:54 UTC (permalink / raw)
To: linux-sh
On 10/26/2014 05:11 PM, Laurent Pinchart wrote:
> Specify the DU output topology, enable the DU device and configure the
> related pins.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
> arch/arm/boot/dts/r8a7791-koelsch.dts | 16 +++++++++++++---
> 1 file changed, 13 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts b/arch/arm/boot/dts/r8a7791-koelsch.dts
> index 53184637f160..0402c498b05b 100644
> --- a/arch/arm/boot/dts/r8a7791-koelsch.dts
> +++ b/arch/arm/boot/dts/r8a7791-koelsch.dts
> @@ -212,14 +212,24 @@
> };
> };
>
> +&du {
> + pinctrl-0 = <&du_pins>;
> + pinctrl-names = "default";
> + status = "okay";
> +
> + ports {
> + port@1 {
> + lvds_connector: endpoint {
I don't understand what this unreferenced label achieves. Also, the
Koelsch schematics tells me LVDS is connected to DU0, not DU1...
[...]
MBR, Sergei
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v5 09/14] ARM: shmobile: koelsch: Enable DU device in DT
2014-10-26 14:11 [PATCH v5 09/14] ARM: shmobile: koelsch: Enable DU device in DT Laurent Pinchart
2015-12-24 19:54 ` Sergei Shtylyov
@ 2015-12-25 23:45 ` Sergei Shtylyov
2015-12-26 10:53 ` Laurent Pinchart
2 siblings, 0 replies; 4+ messages in thread
From: Sergei Shtylyov @ 2015-12-25 23:45 UTC (permalink / raw)
To: linux-sh
Hello.
On 12/24/2015 10:54 PM, Sergei Shtylyov wrote:
>> Specify the DU output topology, enable the DU device and configure the
>> related pins.
>>
>> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
>> ---
>> arch/arm/boot/dts/r8a7791-koelsch.dts | 16 +++++++++++++---
>> 1 file changed, 13 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts
>> b/arch/arm/boot/dts/r8a7791-koelsch.dts
>> index 53184637f160..0402c498b05b 100644
>> --- a/arch/arm/boot/dts/r8a7791-koelsch.dts
>> +++ b/arch/arm/boot/dts/r8a7791-koelsch.dts
>> @@ -212,14 +212,24 @@
>> };
>> };
>>
>> +&du {
>> + pinctrl-0 = <&du_pins>;
>> + pinctrl-names = "default";
>> + status = "okay";
>> +
>> + ports {
>> + port@1 {
>> + lvds_connector: endpoint {
>
> I don't understand what this unreferenced label achieves. Also, the
> Koelsch schematics tells me LVDS is connected to DU0, not DU1...
OK, figured it out now! However in the absence of #include for a LCD panel
this still makes little sense.
> [...]
MBR, Sergei
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v5 09/14] ARM: shmobile: koelsch: Enable DU device in DT
2014-10-26 14:11 [PATCH v5 09/14] ARM: shmobile: koelsch: Enable DU device in DT Laurent Pinchart
2015-12-24 19:54 ` Sergei Shtylyov
2015-12-25 23:45 ` Sergei Shtylyov
@ 2015-12-26 10:53 ` Laurent Pinchart
2 siblings, 0 replies; 4+ messages in thread
From: Laurent Pinchart @ 2015-12-26 10:53 UTC (permalink / raw)
To: linux-sh
Hi Sergei,
On Saturday 26 December 2015 02:45:55 Sergei Shtylyov wrote:
> On 12/24/2015 10:54 PM, Sergei Shtylyov wrote:
> >> Specify the DU output topology, enable the DU device and configure the
> >> related pins.
> >>
> >> Signed-off-by: Laurent Pinchart
> >> <laurent.pinchart+renesas@ideasonboard.com>
> >> ---
> >>
> >> arch/arm/boot/dts/r8a7791-koelsch.dts | 16 +++++++++++++---
> >> 1 file changed, 13 insertions(+), 3 deletions(-)
> >>
> >> diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts
> >> b/arch/arm/boot/dts/r8a7791-koelsch.dts
> >> index 53184637f160..0402c498b05b 100644
> >> --- a/arch/arm/boot/dts/r8a7791-koelsch.dts
> >> +++ b/arch/arm/boot/dts/r8a7791-koelsch.dts
> >> @@ -212,14 +212,24 @@
> >> };
> >> };
> >>
> >> +&du {
> >> + pinctrl-0 = <&du_pins>;
> >> + pinctrl-names = "default";
> >> + status = "okay";
> >> +
> >> + ports {
> >> + port@1 {
> >> + lvds_connector: endpoint {
> >
> > I don't understand what this unreferenced label achieves. Also, the
> > Koelsch schematics tells me LVDS is connected to DU0, not DU1...
>
> OK, figured it out now! However in the absence of #include for a LCD
> panel this still makes little sense.
That's right, but there's no panel mounted directly on the Koelsch board, so
we can't hardcode a particular panel model in r8a7791-koelsch.dts. This is
where DT overlays can be handy.
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-12-26 10:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-26 14:11 [PATCH v5 09/14] ARM: shmobile: koelsch: Enable DU device in DT Laurent Pinchart
2015-12-24 19:54 ` Sergei Shtylyov
2015-12-25 23:45 ` Sergei Shtylyov
2015-12-26 10:53 ` Laurent Pinchart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox