Re: [PATCH 07/15] ASoC: SDCA: Rely less on the ASoC component in IRQ handling

["Liao, Bard" <yung-chuan.liao@linux.intel.com>]

On 9/5/2025 10:31 PM, Charles Keepax wrote:
> In the future some IRQs (mostly File DownLoad) will need to run before
> the soundcard is constructed, as such refactor more of the IRQ handling
> to use raw device and regmap pointers rather than accessing things
> through the component.
> 
> Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
> ---

> -int sdca_irq_data_populate(struct snd_soc_component *component,
> +int sdca_irq_data_populate(struct device *dev, struct regmap *regmap,
> +			   struct snd_soc_component *component,
>  			   struct sdca_function_data *function,
>  			   struct sdca_entity *entity,
>  			   struct sdca_control *control,
>  			   struct sdca_interrupt *interrupt)
>  {
> -	struct device *dev = component->dev;

Previously, we assume 'component' will never be null.

>  	const char *name;
>  
> +	if (!dev && component)

But now we test 'component'. If we don't assume 'component' is not null
any more, we could test 'component' at the very beginning of this function.

> +		dev = component->dev;
> +	if (!dev)
> +		return -ENODEV;
> +
>  	name = devm_kasprintf(dev, GFP_KERNEL, "%s %s %s", function->desc->name,
>  			      entity->label, control->label);
>  	if (!name)
>  		return -ENOMEM;
>  
>  	interrupt->name = name;
> +	interrupt->dev = dev;
> +	if (!regmap && component)
> +		interrupt->function_regmap = component->regmap;
> +	else
> +		interrupt->function_regmap = regmap;
>  	interrupt->component = component;
>  	interrupt->function = function;
>  	interrupt->entity = entity;
> @@ -394,8 +406,9 @@ int sdca_irq_populate(struct sdca_function_data *function,
>  			else if (!interrupt)
>  				continue;
>  
> -			ret = sdca_irq_data_populate(component, function, entity,
> -						     control, interrupt);
> +			ret = sdca_irq_data_populate(dev, NULL, component,
> +						     function, entity, control,
> +						     interrupt);
>  			if (ret)
>  				return ret;
>