Re: [PATCH 04/15] ASoC: SDCA: Pass device register map from IRQ alloc to handlers

[Charles Keepax <ckeepax@opensource.cirrus.com>]

On Tue, Sep 09, 2025 at 03:05:40PM +0200, Pierre-Louis Bossart wrote:
> On 9/8/25 14:56, Charles Keepax wrote:
> > On Mon, Sep 08, 2025 at 01:49:43PM +0200, Pierre-Louis Bossart wrote:
> >> On 9/5/25 16:31, Charles Keepax wrote:
> >> Lost on this one as well. A child device could support multiple
> >> interrupts, e.g. for buttons and jack, not sure why each interrupt
> >> needs a separate pointer to the same identical information.
> > 
> > Most IRQs don't need custom handling so the core can handle those
> > IRQs. In the case of custom IRQs the driver would register some
> > private data structure that would contain necessary information
> > for the handler such as regmaps. This array of interrupt
> > structures is basically that private data. A pointer to this
> > structure will be passed to the IRQ when it fires and it needs to
> > contain all the stuff the IRQ handler needs, one of those things
> > might be the device level register map.
> 
> I think I am still looking at interrupts with the standard
> non-SDCA interrupts in mind. In the existing SoundWire handling,
> all interrupts are handled one after the other in the same
> handler. The only case where we could customize the handler is
> for the 'vendor-defined' interrupt.
> 
> But for SDCA we are moving to a different design, aren't
> we? Each interrupt is handled separately with its own handler,
> either provided by the core or customized by a vendor, and that
> handler must be provided with enough context information to
> access registers. If that description is correct then yes no
> objection to this copy of the information.

Yeah exactly correct, each IRQ gets it own handler and that needs
all the necessary context to handle the IRQ.

Thanks,
Charles