Re: [PATCH 07/15] ASoC: SDCA: Rely less on the ASoC component in IRQ handling

[Charles Keepax <ckeepax@opensource.cirrus.com>]

On Mon, Sep 08, 2025 at 06:27:40PM +0800, Liao, Bard wrote:
> 
> 
> On 9/5/2025 10:31 PM, Charles Keepax wrote:
> > In the future some IRQs (mostly File DownLoad) will need to run before
> > the soundcard is constructed, as such refactor more of the IRQ handling
> > to use raw device and regmap pointers rather than accessing things
> > through the component.
> > 
> > Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
> > ---
> 
> > -int sdca_irq_data_populate(struct snd_soc_component *component,
> > +int sdca_irq_data_populate(struct device *dev, struct regmap *regmap,
> > +			   struct snd_soc_component *component,
> >  			   struct sdca_function_data *function,
> >  			   struct sdca_entity *entity,
> >  			   struct sdca_control *control,
> >  			   struct sdca_interrupt *interrupt)
> >  {
> > -	struct device *dev = component->dev;
> 
> Previously, we assume 'component' will never be null.
> 
> >  	const char *name;
> >  
> > +	if (!dev && component)
> 
> But now we test 'component'. If we don't assume 'component' is not null
> any more, we could test 'component' at the very beginning of this function.
> 

Good spot, that was missed when moving from an older version of
the code. I will get that fixed up.

Thanks,
Charles