Linux Sound subsystem development
 help / color / mirror / Atom feed
From: "Shuming [范書銘]" <shumingf@realtek.com>
To: Cezary Rojewski <cezary.rojewski@intel.com>,
	"broonie@kernel.org" <broonie@kernel.org>
Cc: "tiwai@suse.com" <tiwai@suse.com>,
	"perex@perex.cz" <perex@perex.cz>,
	"amadeuszx.slawinski@linux.intel.com"
	<amadeuszx.slawinski@linux.intel.com>,
	"linux-sound@vger.kernel.org" <linux-sound@vger.kernel.org>,
	Oder Chiou <oder_chiou@realtek.com>,
	"Flove(HsinFu)" <flove@realtek.com>,
	"andriy.shevchenko@linux.intel.com"
	<andriy.shevchenko@linux.intel.com>
Subject: RE: [PATCH 24/24] ASoC: codecs: rt5682s: Update definition of device_id tables
Date: Fri, 21 Feb 2025 02:08:38 +0000	[thread overview]
Message-ID: <121d215bcc3746ddae410f2f9c80e654@realtek.com> (raw)
In-Reply-To: <20250220112643.3813295-25-cezary.rojewski@intel.com>

> Follow PCI-based format (10ECxxxx) for ACPI IDs by adding relevant entries to
> the existing table.
> 
> While at it, there shall be no comma after the terminator entry and initializing
> fields with 0 for statically defined structs is redundant.
> 
> Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
> ---
>  sound/soc/codecs/rt5682s.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/sound/soc/codecs/rt5682s.c b/sound/soc/codecs/rt5682s.c index
> ce2e88e066f3..5ad0cc3fab7f 100644
> --- a/sound/soc/codecs/rt5682s.c
> +++ b/sound/soc/codecs/rt5682s.c
> @@ -3310,13 +3310,14 @@ static void rt5682s_i2c_remove(struct i2c_client
> *client)
> 
>  static const struct of_device_id rt5682s_of_match[] = {
>         {.compatible = "realtek,rt5682s"},
> -       {},
> +       {}
>  };
>  MODULE_DEVICE_TABLE(of, rt5682s_of_match);
> 
>  static const struct acpi_device_id rt5682s_acpi_match[] = {
> -       {"RTL5682", 0,},
> -       {},
> +       { "RTL5682" },
> +       { "10EC5682" },
> +       {}

The rt5682s and rt5682 are different codec drivers.
The rt5682s uses RTL5682 APCI ID and rt5682 uses 10EC5682.

>  };
>  MODULE_DEVICE_TABLE(acpi, rt5682s_acpi_match);
> 
> --
> 2.25.1
> 


  reply	other threads:[~2025-02-21  2:09 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-20 11:26 [PATCH 00/24] ASoC: codecs: Update device_id tables for Realtek drivers Cezary Rojewski
2025-02-20 11:26 ` [PATCH 01/24] ASoC: codecs: rt1011: Fix definition of device_id tables Cezary Rojewski
2025-02-20 11:26 ` [PATCH 02/24] ASoC: codecs: rt1015: " Cezary Rojewski
2025-02-20 11:26 ` [PATCH 03/24] ASoC: codecs: rt1016: " Cezary Rojewski
2025-02-20 11:26 ` [PATCH 04/24] ASoC: codecs: rt1019: " Cezary Rojewski
2025-02-20 11:26 ` [PATCH 05/24] ASoC: codecs: rt1305: " Cezary Rojewski
2025-02-20 11:26 ` [PATCH 06/24] ASoC: codecs: rt1308: " Cezary Rojewski
2025-02-20 14:11   ` Andy Shevchenko
2025-02-20 15:37     ` Cezary Rojewski
2025-02-20 11:26 ` [PATCH 07/24] ASoC: codecs: rt1318: " Cezary Rojewski
2025-02-20 11:26 ` [PATCH 08/24] ASoC: codecs: rt274: " Cezary Rojewski
2025-02-20 11:26 ` [PATCH 09/24] ASoC: codecs: rt5514: " Cezary Rojewski
2025-02-20 11:26 ` [PATCH 10/24] ASoC: codecs: rt5640: " Cezary Rojewski
2025-02-20 11:26 ` [PATCH 11/24] ASoC: codecs: rt5645: " Cezary Rojewski
2025-02-20 11:26 ` [PATCH 12/24] ASoC: codecs: rt5651: " Cezary Rojewski
2025-02-20 11:26 ` [PATCH 13/24] ASoC: codecs: rt5659: " Cezary Rojewski
2025-02-20 11:26 ` [PATCH 14/24] ASoC: codecs: rt5660: " Cezary Rojewski
2025-02-20 14:13   ` Andy Shevchenko
2025-02-20 15:42     ` Cezary Rojewski
2025-02-20 11:26 ` [PATCH 15/24] ASoC: codecs: rt5663: " Cezary Rojewski
2025-02-20 11:26 ` [PATCH 16/24] ASoC: codecs: rt5665: " Cezary Rojewski
2025-02-20 11:26 ` [PATCH 17/24] ASoC: codecs: rt5668: " Cezary Rojewski
2025-02-20 11:26 ` [PATCH 18/24] ASoC: codecs: rt5670: " Cezary Rojewski
2025-02-20 11:26 ` [PATCH 19/24] ASoC: codecs: rt5682: " Cezary Rojewski
2025-02-20 11:26 ` [PATCH 20/24] ASoC: codecs: rt1015p: Update " Cezary Rojewski
2025-02-21  2:38   ` Oder Chiou
2025-02-26  9:42     ` Cezary Rojewski
2025-02-27  5:11       ` Oder Chiou
2025-02-27 12:43         ` Cezary Rojewski
2025-02-20 11:26 ` [PATCH 21/24] ASoC: codecs: rt286: " Cezary Rojewski
2025-02-20 11:26 ` [PATCH 22/24] ASoC: codecs: rt298: " Cezary Rojewski
2025-02-20 11:26 ` [PATCH 23/24] ASoC: codecs: rt5677: " Cezary Rojewski
2025-02-20 11:26 ` [PATCH 24/24] ASoC: codecs: rt5682s: " Cezary Rojewski
2025-02-21  2:08   ` Shuming [范書銘] [this message]
2025-02-26  9:47     ` Cezary Rojewski
2025-02-20 14:09 ` [PATCH 00/24] ASoC: codecs: Update device_id tables for Realtek drivers Andy Shevchenko
2025-02-20 14:15 ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=121d215bcc3746ddae410f2f9c80e654@realtek.com \
    --to=shumingf@realtek.com \
    --cc=amadeuszx.slawinski@linux.intel.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=broonie@kernel.org \
    --cc=cezary.rojewski@intel.com \
    --cc=flove@realtek.com \
    --cc=linux-sound@vger.kernel.org \
    --cc=oder_chiou@realtek.com \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox