Re: [PATCH 00/24] ASoC: codecs: Update device_id tables for Realtek drivers

[Andy Shevchenko <andriy.shevchenko@linux.intel.com>]

On Thu, Feb 20, 2025 at 12:26:19PM +0100, Cezary Rojewski wrote:
> The series aims to streamline the formatting for ACPI IDs so that a
> single pattern can be used to identify the device.
> 
> Work implicitly suggested by Andy Shevchenko - reading and learning from
> number of his reviews on the Linux mailing lists.
> 
> Several formats do exists, however, after technical discussion PCI-based
> format has been selected as the recommended one. For Realtek devices, it
> is going to be 10ECxxxx where 10EC unambiguously identifies Realtek
> company whereas the following 4 hexes specify the PART_ID i.e.: the
> device.
> 
> While at it, there shall be no comma after the terminator entry and
> initializing fields with 0 for statically defined structs is redundant.

I briefly looked at them all and found two issues I commented on in a couple of
cases as an example (you need to go through whole series) and one side note.

If you address those comments, I will give you a tag.

-- 
With Best Regards,
Andy Shevchenko