Re: [PATCH 14/24] ASoC: codecs: rt5660: Fix definition of device_id tables

[Cezary Rojewski <cezary.rojewski@intel.com>]

On 2025-02-20 3:13 PM, Andy Shevchenko wrote:
> On Thu, Feb 20, 2025 at 12:26:33PM +0100, Cezary Rojewski wrote:
>> There shall be no comma after the terminator entry and initializing
>> fields with 0 for statically defined structs is redundant.
> 
> ...
> 
>>   static const struct acpi_device_id rt5660_acpi_match[] = {
>> -	{ "10EC5660", 0 },
>> -	{ "10EC3277", 0 },
>> -	{ },
>> +	{ "10EC5660" },
>> +	{ "10EC3277" },
>> +	{}
>>   };
> 
> While at it, can you sort them alphabetically?

Ack.

> Also, a side note: perhaps at some point you are going to remove those ugly
> ifdeffery around them along with unuseful ACPI_PTR() / of_match_ptr() calls.
> With that in some cases we can get rid of unneeded of.h and/or acpi.h inclusions
> (the ID table definitions come from mod_devicetable.h).

I do not see a reason not to. We'll do so in a separate series to not 
mix the subjects though. This will probably also scale beyond 'just' rt*.

Czarek