From: Cezary Rojewski <cezary.rojewski@intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: <broonie@kernel.org>, <tiwai@suse.com>, <perex@perex.cz>,
<amadeuszx.slawinski@linux.intel.com>,
<linux-sound@vger.kernel.org>, <oder_chiou@realtek.com>,
<flove@realtek.com>
Subject: Re: [PATCH 06/24] ASoC: codecs: rt1308: Fix definition of device_id tables
Date: Thu, 20 Feb 2025 16:37:39 +0100 [thread overview]
Message-ID: <fc0cbb0f-699c-4b1d-b238-ad733d2a5632@intel.com> (raw)
In-Reply-To: <Z7c4BaI8XgOoY7hz@smile.fi.intel.com>
On 2025-02-20 3:11 PM, Andy Shevchenko wrote:
> On Thu, Feb 20, 2025 at 12:26:25PM +0100, Cezary Rojewski wrote:
>> There shall be no comma after the terminator entry and initializing
>> fields with 0 for statically defined structs is redundant.
>
> ...
>
>> + { }
>
>> + {}
>
> I think you want a bit of consistency in the style of the terminator.
> Preferable (by majority) is with space inside, but some are okay without it.
> I have no preferences, just one style for all in the same driver.
Ack. What happened is: in some cases I just updated the line according
to the standard whereas in others I did remove ',' and other stuff while
aligning with my spacing preference. Will pick one for v2.
Czarek
next prev parent reply other threads:[~2025-02-20 15:37 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-20 11:26 [PATCH 00/24] ASoC: codecs: Update device_id tables for Realtek drivers Cezary Rojewski
2025-02-20 11:26 ` [PATCH 01/24] ASoC: codecs: rt1011: Fix definition of device_id tables Cezary Rojewski
2025-02-20 11:26 ` [PATCH 02/24] ASoC: codecs: rt1015: " Cezary Rojewski
2025-02-20 11:26 ` [PATCH 03/24] ASoC: codecs: rt1016: " Cezary Rojewski
2025-02-20 11:26 ` [PATCH 04/24] ASoC: codecs: rt1019: " Cezary Rojewski
2025-02-20 11:26 ` [PATCH 05/24] ASoC: codecs: rt1305: " Cezary Rojewski
2025-02-20 11:26 ` [PATCH 06/24] ASoC: codecs: rt1308: " Cezary Rojewski
2025-02-20 14:11 ` Andy Shevchenko
2025-02-20 15:37 ` Cezary Rojewski [this message]
2025-02-20 11:26 ` [PATCH 07/24] ASoC: codecs: rt1318: " Cezary Rojewski
2025-02-20 11:26 ` [PATCH 08/24] ASoC: codecs: rt274: " Cezary Rojewski
2025-02-20 11:26 ` [PATCH 09/24] ASoC: codecs: rt5514: " Cezary Rojewski
2025-02-20 11:26 ` [PATCH 10/24] ASoC: codecs: rt5640: " Cezary Rojewski
2025-02-20 11:26 ` [PATCH 11/24] ASoC: codecs: rt5645: " Cezary Rojewski
2025-02-20 11:26 ` [PATCH 12/24] ASoC: codecs: rt5651: " Cezary Rojewski
2025-02-20 11:26 ` [PATCH 13/24] ASoC: codecs: rt5659: " Cezary Rojewski
2025-02-20 11:26 ` [PATCH 14/24] ASoC: codecs: rt5660: " Cezary Rojewski
2025-02-20 14:13 ` Andy Shevchenko
2025-02-20 15:42 ` Cezary Rojewski
2025-02-20 11:26 ` [PATCH 15/24] ASoC: codecs: rt5663: " Cezary Rojewski
2025-02-20 11:26 ` [PATCH 16/24] ASoC: codecs: rt5665: " Cezary Rojewski
2025-02-20 11:26 ` [PATCH 17/24] ASoC: codecs: rt5668: " Cezary Rojewski
2025-02-20 11:26 ` [PATCH 18/24] ASoC: codecs: rt5670: " Cezary Rojewski
2025-02-20 11:26 ` [PATCH 19/24] ASoC: codecs: rt5682: " Cezary Rojewski
2025-02-20 11:26 ` [PATCH 20/24] ASoC: codecs: rt1015p: Update " Cezary Rojewski
2025-02-21 2:38 ` Oder Chiou
2025-02-26 9:42 ` Cezary Rojewski
2025-02-27 5:11 ` Oder Chiou
2025-02-27 12:43 ` Cezary Rojewski
2025-02-20 11:26 ` [PATCH 21/24] ASoC: codecs: rt286: " Cezary Rojewski
2025-02-20 11:26 ` [PATCH 22/24] ASoC: codecs: rt298: " Cezary Rojewski
2025-02-20 11:26 ` [PATCH 23/24] ASoC: codecs: rt5677: " Cezary Rojewski
2025-02-20 11:26 ` [PATCH 24/24] ASoC: codecs: rt5682s: " Cezary Rojewski
2025-02-21 2:08 ` Shuming [范書銘]
2025-02-26 9:47 ` Cezary Rojewski
2025-02-20 14:09 ` [PATCH 00/24] ASoC: codecs: Update device_id tables for Realtek drivers Andy Shevchenko
2025-02-20 14:15 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc0cbb0f-699c-4b1d-b238-ad733d2a5632@intel.com \
--to=cezary.rojewski@intel.com \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=flove@realtek.com \
--cc=linux-sound@vger.kernel.org \
--cc=oder_chiou@realtek.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox