From: "Jarosław Janik" <jaroslaw.janik@gmail.com>
To: Takashi Iwai <tiwai@suse.com>
Cc: linux-sound@vger.kernel.org, "Jarosław Janik" <jaroslaw.janik@gmail.com>
Subject: [PATCH 1/2] Revert "ALSA: hda/conexant: Mute speakers at suspend / shutdown"
Date: Wed, 30 Oct 2024 18:18:12 +0100 [thread overview]
Message-ID: <20241030171813.18941-2-jaroslaw.janik@gmail.com> (raw)
In-Reply-To: <20241030171813.18941-1-jaroslaw.janik@gmail.com>
Commit 4f61c8fe3520 ("ALSA: hda/conexant: Mute speakers at suspend /
shutdown") mutes speakers on system shutdown or whenever HDA controller
is suspended by PM; this however interacts badly with Thinkpad's ACPI
firmware behavior which uses beeps to signal various events (enter/leave
suspend or hibernation, AC power connect/disconnect, low battery, etc.);
now those beeps are either muted altogether (for suspend/hibernate/
shutdown related events) or work more or less randomly (eg. AC
plug/unplug is only audible when you are playing music at the moment,
because HDA device is likely in suspend mode otherwise).
Since the original bug report mentioned in 4f61c8fe3520 complained about
Lenovo's Thinkpad laptop - revert this commit altogether.
Fixes: 4f61c8fe3520 ("ALSA: hda/conexant: Mute speakers at suspend / shutdown")
Signed-off-by: Jarosław Janik <jaroslaw.janik@gmail.com>
---
sound/pci/hda/patch_conexant.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/sound/pci/hda/patch_conexant.c b/sound/pci/hda/patch_conexant.c
index c74f6742c359..b2bcdf76da30 100644
--- a/sound/pci/hda/patch_conexant.c
+++ b/sound/pci/hda/patch_conexant.c
@@ -205,8 +205,6 @@ static void cx_auto_shutdown(struct hda_codec *codec)
{
struct conexant_spec *spec = codec->spec;
- snd_hda_gen_shutup_speakers(codec);
-
/* Turn the problematic codec into D3 to avoid spurious noises
from the internal speaker during (and after) reboot */
cx_auto_turn_eapd(codec, spec->num_eapds, spec->eapds, false);
--
2.39.5
next prev parent reply other threads:[~2024-10-30 17:18 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-30 17:18 [PATCH 0/2] Fix beep notifications by Thinkpad's ACPI firmware Jarosław Janik
2024-10-30 17:18 ` Jarosław Janik [this message]
2024-10-30 17:18 ` [PATCH 2/2] Revert "ALSA: hda/generic: Add a helper to mute speakers at suspend/shutdown" Jarosław Janik
2024-10-31 9:15 ` [PATCH 0/2] Fix beep notifications by Thinkpad's ACPI firmware Takashi Iwai
2024-10-31 16:12 ` Jarosław Janik
2024-10-31 16:21 ` Takashi Iwai
2024-10-31 16:43 ` Jarosław Janik
2024-11-01 8:18 ` Takashi Iwai
2024-11-01 23:15 ` Jarosław Janik
2024-11-02 8:27 ` Takashi Iwai
2024-11-02 22:45 ` Jarosław Janik
2024-11-08 14:17 ` Takashi Iwai
2024-11-14 0:04 ` Jarosław Janik
2024-11-14 13:42 ` Takashi Iwai
2024-11-15 4:34 ` Jarosław Janik
2024-11-19 15:21 ` Takashi Iwai
2024-11-20 1:29 ` Jarosław Janik
2024-11-20 7:04 ` Takashi Iwai
2024-11-20 15:00 ` Jarosław Janik
2024-11-20 15:09 ` Takashi Iwai
2024-11-21 1:15 ` Jarosław Janik
2024-11-21 15:39 ` Takashi Iwai
2024-10-31 18:53 ` Thorsten Leemhuis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241030171813.18941-2-jaroslaw.janik@gmail.com \
--to=jaroslaw.janik@gmail.com \
--cc=linux-sound@vger.kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox