Linux Sound subsystem development
 help / color / mirror / Atom feed
From: "Jarosław Janik" <jaroslaw.janik@gmail.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: Takashi Iwai <tiwai@suse.com>, linux-sound@vger.kernel.org
Subject: Re: [PATCH 0/2] Fix beep notifications by Thinkpad's ACPI firmware
Date: Thu, 31 Oct 2024 17:12:53 +0100	[thread overview]
Message-ID: <5683a485-5a5e-473c-a82c-d5c8817742bf@gmail.com> (raw)
In-Reply-To: <87r07wws4j.wl-tiwai@suse.de>

On 31.10.2024 10:15, Takashi Iwai wrote:

> Per reading the patch description, though, the behavior appears to be
> pretty unreliable, as it depends on the runtime suspend.  We may
> control the runtime PM better if we know that the beep must be
> submitted; or it's even possible to runtime resume/re-suspend upon
> beeping, too.  But it's maybe too complex than needed.

You must have misunderstood that, this unreliable behavior is what
happens with your patch applied, once this patch is reverted everything
works perfectly fine (again). Perhaps the commit message should be
rewritten to indicate it more clearly, e.g. replace:
> now those beeps are either muted altogether
with
> since 4f61c8fe3520 those beeps are either muted altogether

... or perhaps it should be just left as it is...

Thanks anyway!

-- 
Regards!
Jarosław Janik


  reply	other threads:[~2024-10-31 16:12 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-30 17:18 [PATCH 0/2] Fix beep notifications by Thinkpad's ACPI firmware Jarosław Janik
2024-10-30 17:18 ` [PATCH 1/2] Revert "ALSA: hda/conexant: Mute speakers at suspend / shutdown" Jarosław Janik
2024-10-30 17:18 ` [PATCH 2/2] Revert "ALSA: hda/generic: Add a helper to mute speakers at suspend/shutdown" Jarosław Janik
2024-10-31  9:15 ` [PATCH 0/2] Fix beep notifications by Thinkpad's ACPI firmware Takashi Iwai
2024-10-31 16:12   ` Jarosław Janik [this message]
2024-10-31 16:21     ` Takashi Iwai
2024-10-31 16:43       ` Jarosław Janik
2024-11-01  8:18         ` Takashi Iwai
2024-11-01 23:15           ` Jarosław Janik
2024-11-02  8:27             ` Takashi Iwai
2024-11-02 22:45               ` Jarosław Janik
2024-11-08 14:17                 ` Takashi Iwai
2024-11-14  0:04                   ` Jarosław Janik
2024-11-14 13:42                     ` Takashi Iwai
2024-11-15  4:34                       ` Jarosław Janik
2024-11-19 15:21                         ` Takashi Iwai
2024-11-20  1:29                           ` Jarosław Janik
2024-11-20  7:04                             ` Takashi Iwai
2024-11-20 15:00                               ` Jarosław Janik
2024-11-20 15:09                                 ` Takashi Iwai
2024-11-21  1:15                                   ` Jarosław Janik
2024-11-21 15:39                                     ` Takashi Iwai
2024-10-31 18:53   ` Thorsten Leemhuis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5683a485-5a5e-473c-a82c-d5c8817742bf@gmail.com \
    --to=jaroslaw.janik@gmail.com \
    --cc=linux-sound@vger.kernel.org \
    --cc=tiwai@suse.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox