[PATCH] spi: bcm63xx-hsspi: fix error code in probe

[PATCH] spi: bcm63xx-hsspi: fix error code in probe

[Dan Carpenter]

This code accidentally returns success instead of a negative error code.

Fixes: 50a6620dd1fb ("spi: bcm63xx-hsspi: Add polling mode support")
Signed-off-by: Dan Carpenter <error27@gmail.com>
---
 drivers/spi/spi-bcm63xx-hsspi.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/spi/spi-bcm63xx-hsspi.c b/drivers/spi/spi-bcm63xx-hsspi.c
index 1e9e906d297c..e481c8d5e5d6 100644
--- a/drivers/spi/spi-bcm63xx-hsspi.c
+++ b/drivers/spi/spi-bcm63xx-hsspi.c
@@ -847,7 +847,8 @@ static int bcm63xx_hsspi_probe(struct platform_device *pdev)
 
 	pm_runtime_enable(&pdev->dev);
 
-	if (sysfs_create_group(&pdev->dev.kobj, &bcm63xx_hsspi_group)) {
+	ret = sysfs_create_group(&pdev->dev.kobj, &bcm63xx_hsspi_group);
+	if (ret) {
 		dev_err(&pdev->dev, "couldn't register sysfs group\n");
 		goto out_pm_disable;
 	}
-- 
2.35.1

Re: [PATCH] spi: bcm63xx-hsspi: fix error code in probe

[William Zhang]

[-- Attachment #1: Type: text/plain, Size: 992 bytes --]



On 02/15/2023 06:05 AM, Dan Carpenter wrote:
> This code accidentally returns success instead of a negative error code.
> 
> Fixes: 50a6620dd1fb ("spi: bcm63xx-hsspi: Add polling mode support")
> Signed-off-by: Dan Carpenter <error27@gmail.com>
> ---
>   drivers/spi/spi-bcm63xx-hsspi.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/spi/spi-bcm63xx-hsspi.c b/drivers/spi/spi-bcm63xx-hsspi.c
> index 1e9e906d297c..e481c8d5e5d6 100644
> --- a/drivers/spi/spi-bcm63xx-hsspi.c
> +++ b/drivers/spi/spi-bcm63xx-hsspi.c
> @@ -847,7 +847,8 @@ static int bcm63xx_hsspi_probe(struct platform_device *pdev)
>   
>   	pm_runtime_enable(&pdev->dev);
>   
> -	if (sysfs_create_group(&pdev->dev.kobj, &bcm63xx_hsspi_group)) {
> +	ret = sysfs_create_group(&pdev->dev.kobj, &bcm63xx_hsspi_group);
> +	if (ret) {
>   		dev_err(&pdev->dev, "couldn't register sysfs group\n");
>   		goto out_pm_disable;
>   	}
> 

Reviewed-by: William Zhang <william.zhang@broadcom.com>

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4212 bytes --]

Re: [PATCH] spi: bcm63xx-hsspi: fix error code in probe

[Florian Fainelli]

On 2/15/23 06:05, Dan Carpenter wrote:
> This code accidentally returns success instead of a negative error code.
> 
> Fixes: 50a6620dd1fb ("spi: bcm63xx-hsspi: Add polling mode support")
> Signed-off-by: Dan Carpenter <error27@gmail.com>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian

Re: [PATCH] spi: bcm63xx-hsspi: fix error code in probe

[Mark Brown]

On Wed, 15 Feb 2023 17:05:20 +0300, Dan Carpenter wrote:
> This code accidentally returns success instead of a negative error code.
> 
> 

Applied to

   broonie/spi.git for-next

Thanks!

[1/1] spi: bcm63xx-hsspi: fix error code in probe
      commit: 97b7cea04f52c3263a74b945a4738f678181b117

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark