[PATCH 1/1] spi: cadence-quadspi: fix cleanup of rx_chan on failure paths

[PATCH 1/1] spi: cadence-quadspi: fix cleanup of rx_chan on failure paths

[khairul.anuar.romli]

From: Khairul Anuar Romli <khairul.anuar.romli@altera.com>

Remove incorrect checks on cqspi->rx_chan that cause driver breakage
during failure cleanup. Ensure proper resource freeing on the success
path when operating in cqspi->use_direct_mode, preventing leaks and
improving stability.

Signed-off-by: Khairul Anuar Romli <khairul.anuar.romli@altera.com>
---
 drivers/spi/spi-cadence-quadspi.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/spi/spi-cadence-quadspi.c b/drivers/spi/spi-cadence-quadspi.c
index aa1932ba17cb..d3c78f59b22c 100644
--- a/drivers/spi/spi-cadence-quadspi.c
+++ b/drivers/spi/spi-cadence-quadspi.c
@@ -1960,11 +1960,6 @@ static int cqspi_probe(struct platform_device *pdev)
 
 	pm_runtime_enable(dev);
 
-	if (cqspi->rx_chan) {
-		dma_release_channel(cqspi->rx_chan);
-		goto probe_setup_failed;
-	}
-
 	pm_runtime_set_autosuspend_delay(dev, CQSPI_AUTOSUSPEND_TIMEOUT);
 	pm_runtime_use_autosuspend(dev);
 	pm_runtime_get_noresume(dev);
-- 
2.35.3

Re: [PATCH 1/1] spi: cadence-quadspi: fix cleanup of rx_chan on failure paths

[Santhosh Kumar K]

Hello Khairul,

On 30/06/25 14:41, khairul.anuar.romli@altera.com wrote:
> From: Khairul Anuar Romli <khairul.anuar.romli@altera.com>
> 
> Remove incorrect checks on cqspi->rx_chan that cause driver breakage
> during failure cleanup. Ensure proper resource freeing on the success
> path when operating in cqspi->use_direct_mode, preventing leaks and
> improving stability.
> 
> Signed-off-by: Khairul Anuar Romli <khairul.anuar.romli@altera.com>

Please add 'Fixes' tag and add stable in cc.

Regards,
Santhosh.

> ---
>   drivers/spi/spi-cadence-quadspi.c | 5 -----
>   1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/spi/spi-cadence-quadspi.c b/drivers/spi/spi-cadence-quadspi.c
> index aa1932ba17cb..d3c78f59b22c 100644
> --- a/drivers/spi/spi-cadence-quadspi.c
> +++ b/drivers/spi/spi-cadence-quadspi.c
> @@ -1960,11 +1960,6 @@ static int cqspi_probe(struct platform_device *pdev)
>   
>   	pm_runtime_enable(dev);
>   
> -	if (cqspi->rx_chan) {
> -		dma_release_channel(cqspi->rx_chan);
> -		goto probe_setup_failed;
> -	}
> -
>   	pm_runtime_set_autosuspend_delay(dev, CQSPI_AUTOSUSPEND_TIMEOUT);
>   	pm_runtime_use_autosuspend(dev);
>   	pm_runtime_get_noresume(dev);

Re: [PATCH 1/1] spi: cadence-quadspi: fix cleanup of rx_chan on failure paths

[Dan Carpenter]

On Mon, Jun 30, 2025 at 05:11:56PM +0800, khairul.anuar.romli@altera.com wrote:
> From: Khairul Anuar Romli <khairul.anuar.romli@altera.com>
> 
> Remove incorrect checks on cqspi->rx_chan that cause driver breakage
> during failure cleanup. Ensure proper resource freeing on the success
> path when operating in cqspi->use_direct_mode, preventing leaks and
> improving stability.
> 
> Signed-off-by: Khairul Anuar Romli <khairul.anuar.romli@altera.com>

Thanks.

Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>

Mark asked me to fix this and I wrote a fix but apparently I didn't
hit send because it's still in my outbox.  Sorry about that.  :(

regards,
dan carpenter

RE: [PATCH 1/1] spi: cadence-quadspi: fix cleanup of rx_chan on failure paths

[Romli, Khairul Anuar]

> On Mon, Jun 30, 2025 at 05:11:56PM +0800,
> khairul.anuar.romli@altera.com wrote:
> > From: Khairul Anuar Romli <khairul.anuar.romli@altera.com>
> >
> > Remove incorrect checks on cqspi->rx_chan that cause driver breakage
> > during failure cleanup. Ensure proper resource freeing on the success
> > path when operating in cqspi->use_direct_mode, preventing leaks and
> > improving stability.
> >
> > Signed-off-by: Khairul Anuar Romli <khairul.anuar.romli@altera.com>
> 
> Thanks.
> 
> Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
> 
> Mark asked me to fix this and I wrote a fix but apparently I didn't hit send
> because it's still in my outbox.  Sorry about that.  :(
> 
> regards,
> dan carpenter

Sorry for sending the fix on your behalf. 

Re: [PATCH 1/1] spi: cadence-quadspi: fix cleanup of rx_chan on failure paths

[Dan Carpenter]

On Tue, Jul 01, 2025 at 12:39:24AM +0000, Romli, Khairul Anuar wrote:
> > On Mon, Jun 30, 2025 at 05:11:56PM +0800,
> > khairul.anuar.romli@altera.com wrote:
> > > From: Khairul Anuar Romli <khairul.anuar.romli@altera.com>
> > >
> > > Remove incorrect checks on cqspi->rx_chan that cause driver breakage
> > > during failure cleanup. Ensure proper resource freeing on the success
> > > path when operating in cqspi->use_direct_mode, preventing leaks and
> > > improving stability.
> > >
> > > Signed-off-by: Khairul Anuar Romli <khairul.anuar.romli@altera.com>
> > 
> > Thanks.
> > 
> > Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
> > 
> > Mark asked me to fix this and I wrote a fix but apparently I didn't hit send
> > because it's still in my outbox.  Sorry about that.  :(
> > 
> > regards,
> > dan carpenter
> 
> Sorry for sending the fix on your behalf.

No no.  You did the right thing.  It's me who messed up.

regards,
dan carpenter

Re: [PATCH 1/1] spi: cadence-quadspi: fix cleanup of rx_chan on failure paths

[Mark Brown]

On Mon, 30 Jun 2025 17:11:56 +0800, khairul.anuar.romli@altera.com wrote:
> Remove incorrect checks on cqspi->rx_chan that cause driver breakage
> during failure cleanup. Ensure proper resource freeing on the success
> path when operating in cqspi->use_direct_mode, preventing leaks and
> improving stability.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: cadence-quadspi: fix cleanup of rx_chan on failure paths
      commit: 04a8ff1bc3514808481ddebd454342ad902a3f60

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark