[PATCH v3] staging: rtl8712: style fix multiple line dereference

[PATCH v3] staging: rtl8712: style fix multiple line dereference

[Cruzer-S]

From: Moon Yeounsu <yyyynoom@gmail.com>

It fix the following checkpatch.pl warning:
Avoid multiple line dereference - prefer %s

Suggested-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Moon Yeounsu <yyyynoom@gmail.com>
---
v2: Fix email address and checkpatch.pl warning
v3: Fix incorrect commit index, start with new thread for new version of patch,
	place notes below the cutoff line, provide appropriate CC,
	include 'Suggested-by' sign for those who gives good guideline.

 drivers/staging/rtl8712/rtl871x_cmd.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c
index bbd4a13c7bb9..ffeb91dd28c4 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.c
+++ b/drivers/staging/rtl8712/rtl871x_cmd.c
@@ -528,8 +528,9 @@ void r8712_setstakey_cmd(struct _adapter *padapter, u8 *psta, u8 unicast_key)
 	if (unicast_key)
 		memcpy(&psetstakey_para->key, &sta->x_UncstKey, 16);
 	else
-		memcpy(&psetstakey_para->key, &psecuritypriv->XGrpKey[psecuritypriv->XGrpKeyid - 1].
-		       skey, 16);
+		memcpy(&psetstakey_para->key,
+		       &psecuritypriv->XGrpKey[psecuritypriv->XGrpKeyid - 1].skey,
+		       16);
 	r8712_enqueue_cmd(pcmdpriv, ph2c);
 }
--
2.43.5

Re: [PATCH v3] staging: rtl8712: style fix multiple line dereference

[문연수]

2024년 7월 21일 (일) 오후 1:06, Moon Yeounsu <yyyynoom@gmail.com>님이 작성:
>
> From: Moon Yeounsu <yyyynoom@gmail.com>
>
> It fix the following checkpatch.pl warning:
> Avoid multiple line dereference - prefer %s
>
> Suggested-by: Dan Carpenter <dan.carpenter@linaro.org>
> Signed-off-by: Moon Yeounsu <yyyynoom@gmail.com>
> ---
> v2: Fix email address and checkpatch.pl warning
> v3: Fix incorrect commit index, start with new thread for new version of patch,
>         place notes below the cutoff line, provide appropriate CC,
>         include 'Suggested-by' sign for those who gives good guideline.
>
>  drivers/staging/rtl8712/rtl871x_cmd.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c
> index bbd4a13c7bb9..ffeb91dd28c4 100644
> --- a/drivers/staging/rtl8712/rtl871x_cmd.c
> +++ b/drivers/staging/rtl8712/rtl871x_cmd.c
> @@ -528,8 +528,9 @@ void r8712_setstakey_cmd(struct _adapter *padapter, u8 *psta, u8 unicast_key)
>         if (unicast_key)
>                 memcpy(&psetstakey_para->key, &sta->x_UncstKey, 16);
>         else
> -               memcpy(&psetstakey_para->key, &psecuritypriv->XGrpKey[psecuritypriv->XGrpKeyid - 1].
> -                      skey, 16);
> +               memcpy(&psetstakey_para->key,
> +                      &psecuritypriv->XGrpKey[psecuritypriv->XGrpKeyid - 1].skey,
> +                      16);
>         r8712_enqueue_cmd(pcmdpriv, ph2c);
>  }
> --
> 2.43.5
>

Sorry and thank you to all of the reviewers and maintainers who take
care of my patch.
I make a new problem... I think I check my patch and email over and
over and over.
but, again, I sent the patch incorrectly. The body of the patch
contains improper content,
and also sends the email as my nickname, not a real name.

Sorry for making spam and taking your invaluable time.
Next time, I'll send a right and valuable patch.

Re: [PATCH v3] staging: rtl8712: style fix multiple line dereference

[Nam Cao]

On Sun, Jul 21, 2024 at 01:43:37PM +0900, 문연수 wrote:
> 2024년 7월 21일 (일) 오후 1:06, Moon Yeounsu <yyyynoom@gmail.com>님이 작성:
> > From: Moon Yeounsu <yyyynoom@gmail.com>
> >
> > It fix the following checkpatch.pl warning:
> > Avoid multiple line dereference - prefer %s
> >
> > Suggested-by: Dan Carpenter <dan.carpenter@linaro.org>
> > Signed-off-by: Moon Yeounsu <yyyynoom@gmail.com>
> > ---
> > v2: Fix email address and checkpatch.pl warning
> > v3: Fix incorrect commit index, start with new thread for new version of patch,
> >         place notes below the cutoff line, provide appropriate CC,
> >         include 'Suggested-by' sign for those who gives good guideline.

The "Suggested-by:" thingy is for patch idea, not for "guideline". Have a
look at Documentation/process/submitting-patches.rst.

...
> Sorry and thank you to all of the reviewers and maintainers who take
> care of my patch.
> I make a new problem... I think I check my patch and email over and
> over and over.
> but, again, I sent the patch incorrectly. The body of the patch
> contains improper content,
> and also sends the email as my nickname, not a real name.
> 
> Sorry for making spam and taking your invaluable time.
> Next time, I'll send a right and valuable patch.

Oh no worry, I'm sure people are happy to help. Linux's email-based
workflow is not the easiest to get right.

If you worry about "making spam", you could send the patch to yourself and
try "git am" the email. If it works then send it out for real.

Good luck,
Nam

Re: [PATCH v3] staging: rtl8712: style fix multiple line dereference

[Moon Yeounsu]

On Sun, Jul 21, 2024 at 2:07 PM Nam Cao <namcao@linutronix.de> wrote:
>
> On Sun, Jul 21, 2024 at 01:43:37PM +0900, 문연수 wrote:
> > 2024년 7월 21일 (일) 오후 1:06, Moon Yeounsu <yyyynoom@gmail.com>님이 작성:
> > > From: Moon Yeounsu <yyyynoom@gmail.com>
> > >
> > > It fix the following checkpatch.pl warning:
> > > Avoid multiple line dereference - prefer %s
> > >
> > > Suggested-by: Dan Carpenter <dan.carpenter@linaro.org>
> > > Signed-off-by: Moon Yeounsu <yyyynoom@gmail.com>
> > > ---
> > > v2: Fix email address and checkpatch.pl warning
> > > v3: Fix incorrect commit index, start with new thread for new version of patch,
> > >         place notes below the cutoff line, provide appropriate CC,
> > >         include 'Suggested-by' sign for those who gives good guideline.
>
> The "Suggested-by:" thingy is for patch idea, not for "guideline". Have a
> look at Documentation/process/submitting-patches.rst.

Then, I think "Suggested-by" have to be inserted.
There are some misleading by my poor english skill.
He literally gave me a "patch idea", not a "guideline".
Reference: https://lore.kernel.org/linux-staging/20240718132607.13634-1-yyyynoom@gmail.com/T/#m631c138006ea7e834d6ab4c950cf00f1a0d0e3e3

>
> ...
> > Sorry and thank you to all of the reviewers and maintainers who take
> > care of my patch.
> > I make a new problem... I think I check my patch and email over and
> > over and over.
> > but, again, I sent the patch incorrectly. The body of the patch
> > contains improper content,
> > and also sends the email as my nickname, not a real name.
> >
> > Sorry for making spam and taking your invaluable time.
> > Next time, I'll send a right and valuable patch.
>
> Oh no worry, I'm sure people are happy to help. Linux's email-based
> workflow is not the easiest to get right.
>
> If you worry about "making spam", you could send the patch to yourself and
> try "git am" the email. If it works then send it out for real.

Why didn't I think of that? It is a brilliant idea in order to
double-check patch and email.
Thank you for your advice! I'll do so.

>
> Good luck,
> Nam

Re: [PATCH v3] staging: rtl8712: style fix multiple line dereference

[Dan Carpenter]

The patch still doesn't apply.  Sorry.

cat ~/tmp/yyyynoom | patch -p1
patching file drivers/staging/rtl8712/rtl871x_cmd.c
patch: **** malformed patch at line 132: 2.43.5

The 2.43.5 thing is the git version.  Not sure what went wrong there.

regards,
dan carpenter

Re: [PATCH v3] staging: rtl8712: style fix multiple line dereference

[Dan Carpenter]

On Tue, Jul 23, 2024 at 10:22:32AM -0500, Dan Carpenter wrote:
> The patch still doesn't apply.  Sorry.
> 
> cat ~/tmp/yyyynoom | patch -p1
> patching file drivers/staging/rtl8712/rtl871x_cmd.c
> patch: **** malformed patch at line 132: 2.43.5
> 
> The 2.43.5 thing is the git version.  Not sure what went wrong there.
> 

It must have applied for Greg because he applied it.  I don't know why
it didn't work for me.  I tried using patch to apply it and I tried
git am as well and neither worked.  But it must be something on my end
if it works for Greg.

regards,
dan carpenter

Re: [PATCH v3] staging: rtl8712: style fix multiple line dereference

[Greg KH]

On Tue, Jul 23, 2024 at 11:02:15AM -0500, Dan Carpenter wrote:
> On Tue, Jul 23, 2024 at 10:22:32AM -0500, Dan Carpenter wrote:
> > The patch still doesn't apply.  Sorry.
> > 
> > cat ~/tmp/yyyynoom | patch -p1
> > patching file drivers/staging/rtl8712/rtl871x_cmd.c
> > patch: **** malformed patch at line 132: 2.43.5
> > 
> > The 2.43.5 thing is the git version.  Not sure what went wrong there.
> > 
> 
> It must have applied for Greg because he applied it.  I don't know why
> it didn't work for me.  I tried using patch to apply it and I tried
> git am as well and neither worked.  But it must be something on my end
> if it works for Greg.

I edited it by hand :(