* [PATCH 1/2] arm64: tegra: Sort properties more logically
@ 2023-06-09 10:55 Thierry Reding
2023-06-09 10:55 ` [PATCH 2/2] arm64: tegra: Add a few blank lines for better readability Thierry Reding
2023-06-09 11:04 ` [PATCH 1/2] arm64: tegra: Sort properties more logically Jon Hunter
0 siblings, 2 replies; 4+ messages in thread
From: Thierry Reding @ 2023-06-09 10:55 UTC (permalink / raw)
To: Thierry Reding; +Cc: Jon Hunter, Shubhi Garg, linux-tegra
From: Thierry Reding <treding@nvidia.com>
We typically sort the "compatible" property first because it defines
what the remainder of the properties can be. For the sound node on the
Jetson AGX Orin this wasn't done, so fix that up.
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts b/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts
index ac64dac287de..e499010fc673 100644
--- a/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts
+++ b/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts
@@ -2345,9 +2345,8 @@ serial {
};
sound {
- status = "okay";
-
compatible = "nvidia,tegra186-audio-graph-card";
+ status = "okay";
dais = /* ADMAIF (FE) Ports */
<&admaif0_port>, <&admaif1_port>, <&admaif2_port>, <&admaif3_port>,
--
2.40.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] arm64: tegra: Add a few blank lines for better readability
2023-06-09 10:55 [PATCH 1/2] arm64: tegra: Sort properties more logically Thierry Reding
@ 2023-06-09 10:55 ` Thierry Reding
2023-06-09 11:04 ` Jon Hunter
2023-06-09 11:04 ` [PATCH 1/2] arm64: tegra: Sort properties more logically Jon Hunter
1 sibling, 1 reply; 4+ messages in thread
From: Thierry Reding @ 2023-06-09 10:55 UTC (permalink / raw)
To: Thierry Reding; +Cc: Jon Hunter, Shubhi Garg, linux-tegra
From: Thierry Reding <treding@nvidia.com>
Surround device tree nodes with blank lines for increased readability.
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
.../boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts b/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts
index e499010fc673..5f3d6dcf10a2 100644
--- a/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts
+++ b/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts
@@ -2247,6 +2247,7 @@ TEGRA234_AON_GPIO(AA, 4)
i2c@c240000 {
status = "okay";
+
typec@8 {
compatible = "cypress,cypd4226";
reg = <0x08>;
@@ -2254,22 +2255,27 @@ typec@8 {
interrupts = <TEGRA234_MAIN_GPIO(Y, 4) IRQ_TYPE_LEVEL_LOW>;
firmware-name = "nvidia,jetson-agx-xavier";
status = "okay";
+
#address-cells = <1>;
#size-cells = <0>;
+
ccg_typec_con0: connector@0 {
compatible = "usb-c-connector";
reg = <0>;
label = "USB-C";
data-role = "host";
+
ports {
#address-cells = <1>;
#size-cells = <0>;
+
port@0 {
reg = <0>;
hs_ucsi_ccg_p0: endpoint {
remote-endpoint = <&hs_typec_p0>;
};
};
+
port@1 {
reg = <1>;
ss_ucsi_ccg_p0: endpoint {
@@ -2278,20 +2284,24 @@ ss_ucsi_ccg_p0: endpoint {
};
};
};
+
ccg_typec_con1: connector@1 {
compatible = "usb-c-connector";
reg = <1>;
label = "USB-C";
data-role = "dual";
+
ports {
#address-cells = <1>;
#size-cells = <0>;
+
port@0 {
reg = <0>;
hs_ucsi_ccg_p1: endpoint {
remote-endpoint = <&hs_typec_p1>;
};
};
+
port@1 {
reg = <1>;
ss_ucsi_ccg_p1: endpoint {
--
2.40.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] arm64: tegra: Sort properties more logically
2023-06-09 10:55 [PATCH 1/2] arm64: tegra: Sort properties more logically Thierry Reding
2023-06-09 10:55 ` [PATCH 2/2] arm64: tegra: Add a few blank lines for better readability Thierry Reding
@ 2023-06-09 11:04 ` Jon Hunter
1 sibling, 0 replies; 4+ messages in thread
From: Jon Hunter @ 2023-06-09 11:04 UTC (permalink / raw)
To: Thierry Reding; +Cc: Shubhi Garg, linux-tegra
On 09/06/2023 11:55, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> We typically sort the "compatible" property first because it defines
> what the remainder of the properties can be. For the sound node on the
> Jetson AGX Orin this wasn't done, so fix that up.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts b/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts
> index ac64dac287de..e499010fc673 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts
> +++ b/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts
> @@ -2345,9 +2345,8 @@ serial {
> };
>
> sound {
> - status = "okay";
> -
> compatible = "nvidia,tegra186-audio-graph-card";
> + status = "okay";
>
> dais = /* ADMAIF (FE) Ports */
> <&admaif0_port>, <&admaif1_port>, <&admaif2_port>, <&admaif3_port>,
Acked-by: Jon Hunter <jonathanh@nvidia.com>
Jon
--
nvpublic
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] arm64: tegra: Add a few blank lines for better readability
2023-06-09 10:55 ` [PATCH 2/2] arm64: tegra: Add a few blank lines for better readability Thierry Reding
@ 2023-06-09 11:04 ` Jon Hunter
0 siblings, 0 replies; 4+ messages in thread
From: Jon Hunter @ 2023-06-09 11:04 UTC (permalink / raw)
To: Thierry Reding; +Cc: Shubhi Garg, linux-tegra
On 09/06/2023 11:55, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> Surround device tree nodes with blank lines for increased readability.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> .../boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts b/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts
> index e499010fc673..5f3d6dcf10a2 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts
> +++ b/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts
> @@ -2247,6 +2247,7 @@ TEGRA234_AON_GPIO(AA, 4)
>
> i2c@c240000 {
> status = "okay";
> +
> typec@8 {
> compatible = "cypress,cypd4226";
> reg = <0x08>;
> @@ -2254,22 +2255,27 @@ typec@8 {
> interrupts = <TEGRA234_MAIN_GPIO(Y, 4) IRQ_TYPE_LEVEL_LOW>;
> firmware-name = "nvidia,jetson-agx-xavier";
> status = "okay";
> +
> #address-cells = <1>;
> #size-cells = <0>;
> +
> ccg_typec_con0: connector@0 {
> compatible = "usb-c-connector";
> reg = <0>;
> label = "USB-C";
> data-role = "host";
> +
> ports {
> #address-cells = <1>;
> #size-cells = <0>;
> +
> port@0 {
> reg = <0>;
> hs_ucsi_ccg_p0: endpoint {
> remote-endpoint = <&hs_typec_p0>;
> };
> };
> +
> port@1 {
> reg = <1>;
> ss_ucsi_ccg_p0: endpoint {
> @@ -2278,20 +2284,24 @@ ss_ucsi_ccg_p0: endpoint {
> };
> };
> };
> +
> ccg_typec_con1: connector@1 {
> compatible = "usb-c-connector";
> reg = <1>;
> label = "USB-C";
> data-role = "dual";
> +
> ports {
> #address-cells = <1>;
> #size-cells = <0>;
> +
> port@0 {
> reg = <0>;
> hs_ucsi_ccg_p1: endpoint {
> remote-endpoint = <&hs_typec_p1>;
> };
> };
> +
> port@1 {
> reg = <1>;
> ss_ucsi_ccg_p1: endpoint {
Acked-by: Jon Hunter <jonathanh@nvidia.com>
Jon
--
nvpublic
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-06-09 11:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-09 10:55 [PATCH 1/2] arm64: tegra: Sort properties more logically Thierry Reding
2023-06-09 10:55 ` [PATCH 2/2] arm64: tegra: Add a few blank lines for better readability Thierry Reding
2023-06-09 11:04 ` Jon Hunter
2023-06-09 11:04 ` [PATCH 1/2] arm64: tegra: Sort properties more logically Jon Hunter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox