From: Krzysztof Kozlowski <krzk@kernel.org>
To: Ketan Patil <ketanp@nvidia.com>,
thierry.reding@gmail.com, jonathanh@nvidia.com
Cc: linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH v4 1/4] memory: tegra: Group mc-err related registers
Date: Thu, 18 Dec 2025 17:17:34 +0100 [thread overview]
Message-ID: <c43abae8-c160-4798-9f24-d37af59351fa@kernel.org> (raw)
In-Reply-To: <20251124173510.2602663-2-ketanp@nvidia.com>
On 24/11/2025 18:35, Ketan Patil wrote:
> Group MC error related registers into a struct as they could have soc
> specific values.
I do not understand the goal. The values already have "soc specific
values". Your commit msg should explain why you are doing this and based
on that explanation that's a no. There is no point in doing this.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-12-18 16:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-24 17:35 [PATCH v4 0/4] memory: tegra: Add MC error logging support for Tegra264 SoC Ketan Patil
2025-11-24 17:35 ` [PATCH v4 1/4] memory: tegra: Group mc-err related registers Ketan Patil
2025-12-18 16:17 ` Krzysztof Kozlowski [this message]
2025-12-18 16:51 ` Jon Hunter
2025-12-19 5:43 ` Ketan Patil
2025-11-24 17:35 ` [PATCH v4 2/4] memory: tegra: Group register and fields Ketan Patil
2025-11-24 17:35 ` [PATCH v4 3/4] memory: tegra: Add support for multiple irqs Ketan Patil
2025-12-18 16:54 ` Jon Hunter
2025-11-24 17:35 ` [PATCH v4 4/4] memory: tegra: Add MC error logging support for Tegra264 Ketan Patil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c43abae8-c160-4798-9f24-d37af59351fa@kernel.org \
--to=krzk@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=ketanp@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox