Linux Trace Kernel
 help / color / mirror / Atom feed
From: Gabriele Monaco <gmonaco@redhat.com>
To: linux-kernel@vger.kernel.org,
	Steven Rostedt <rostedt@goodmis.org>,
	Gabriele Monaco <gmonaco@redhat.com>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	linux-trace-kernel@vger.kernel.org
Cc: Nam Cao <namcao@linutronix.de>, Wen Yang <wen.yang@linux.dev>
Subject: [PATCH v3 10/13] rv: Use 0 to check preemption enabled in opid
Date: Sat, 30 May 2026 16:16:49 +0200	[thread overview]
Message-ID: <20260530141652.58084-11-gmonaco@redhat.com> (raw)
In-Reply-To: <20260530141652.58084-1-gmonaco@redhat.com>

Tracepoint handlers no longer run with preemption disabled by default
since a46023d5616 ("tracing: Guard __DECLARE_TRACE() use of
__DO_TRACE_CALL() with SRCU-fast"), the opid monitor should now count 1
in the preemption count as preemption disabled.

Change the rule for preempt_off to preempt > 0.

Signed-off-by: Gabriele Monaco <gmonaco@redhat.com>
---
 kernel/trace/rv/monitors/opid/opid.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/kernel/trace/rv/monitors/opid/opid.c b/kernel/trace/rv/monitors/opid/opid.c
index 2922318c6..3b6a85e81 100644
--- a/kernel/trace/rv/monitors/opid/opid.c
+++ b/kernel/trace/rv/monitors/opid/opid.c
@@ -22,14 +22,8 @@ static u64 ha_get_env(struct ha_monitor *ha_mon, enum envs_opid env, u64 time_ns
 	if (env == irq_off_opid)
 		return irqs_disabled();
 	else if (env == preempt_off_opid) {
-		/*
-		 * If CONFIG_PREEMPTION is enabled, then the tracepoint itself disables
-		 * preemption (adding one to the preempt_count). Since we are
-		 * interested in the preempt_count at the time the tracepoint was
-		 * hit, we consider 1 as still enabled.
-		 */
 		if (IS_ENABLED(CONFIG_PREEMPTION))
-			return (preempt_count() & PREEMPT_MASK) > 1;
+			return (preempt_count() & PREEMPT_MASK) > 0;
 		return true;
 	}
 	return ENV_INVALID_VALUE;
-- 
2.54.0


  parent reply	other threads:[~2026-05-30 14:17 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-30 14:16 [PATCH v3 00/13] rv: Fixes on Deterministic and Hybrid Automata Gabriele Monaco
2026-05-30 14:16 ` [PATCH v3 01/13] rv: Fix __user specifier usage in extract_params() Gabriele Monaco
2026-05-30 14:16 ` [PATCH v3 02/13] rv: Reset per-task DA monitors before releasing the slot Gabriele Monaco
2026-05-30 14:16 ` [PATCH v3 03/13] rv: Prevent in-flight per-task handlers from using invalid slots Gabriele Monaco
2026-05-30 14:16 ` [PATCH v3 04/13] rv: Ensure all pending probes terminate on per-obj monitor destroy Gabriele Monaco
2026-05-30 14:16 ` [PATCH v3 05/13] rv: Fix monitor start ordering and memory ordering for monitoring flag Gabriele Monaco
2026-06-01  6:55   ` Nam Cao
2026-06-01  7:15     ` Gabriele Monaco
2026-06-01  7:29       ` Nam Cao
2026-05-30 14:16 ` [PATCH v3 06/13] rv: Do not rely on clean monitor when initialising HA Gabriele Monaco
2026-06-01  7:24   ` Nam Cao
2026-06-01  7:31     ` Nam Cao
2026-06-01  8:07       ` Gabriele Monaco
2026-05-30 14:16 ` [PATCH v3 07/13] rv: Add automatic cleanup handlers for per-task HA monitors Gabriele Monaco
2026-06-01  7:39   ` Nam Cao
2026-06-01  7:51     ` Gabriele Monaco
2026-06-01  7:58   ` Nam Cao
2026-05-30 14:16 ` [PATCH v3 08/13] rv: Ensure synchronous cleanup for " Gabriele Monaco
2026-06-01  7:52   ` Nam Cao
2026-06-01  8:05     ` Gabriele Monaco
2026-05-30 14:16 ` [PATCH v3 09/13] rv: Prevent task migration while handling per-CPU events Gabriele Monaco
2026-05-30 14:16 ` Gabriele Monaco [this message]
2026-06-01  7:56   ` [PATCH v3 10/13] rv: Use 0 to check preemption enabled in opid Nam Cao
2026-05-30 14:16 ` [PATCH v3 11/13] verification/rvgen: Fix suffix strip in dot2k Gabriele Monaco
2026-06-01  8:00   ` Nam Cao
2026-05-30 14:16 ` [PATCH v3 12/13] rv: Fix read_lock scope in per-task DA cleanup Gabriele Monaco
2026-05-30 14:16 ` [PATCH v3 13/13] verification/rvgen: Generate cleanup hook for per-obj monitor Gabriele Monaco
2026-06-01  8:01   ` Nam Cao
2026-05-31 15:17 ` [PATCH v3 00/13] rv: Fixes on Deterministic and Hybrid Automata Wen Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260530141652.58084-11-gmonaco@redhat.com \
    --to=gmonaco@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=namcao@linutronix.de \
    --cc=rostedt@goodmis.org \
    --cc=wen.yang@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox