From: Gabriele Monaco <gmonaco@redhat.com>
To: linux-kernel@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>,
Gabriele Monaco <gmonaco@redhat.com>,
linux-trace-kernel@vger.kernel.org
Cc: Nam Cao <namcao@linutronix.de>, Wen Yang <wen.yang@linux.dev>
Subject: [PATCH v3 11/13] verification/rvgen: Fix suffix strip in dot2k
Date: Sat, 30 May 2026 16:16:50 +0200 [thread overview]
Message-ID: <20260530141652.58084-12-gmonaco@redhat.com> (raw)
In-Reply-To: <20260530141652.58084-1-gmonaco@redhat.com>
__start_to_invariant_check() and __get_constraint_env() parse the
environment variable's name from sources that have it padded with the
monitor name. This is removed using rstrip(), which is not meant to
strip a substring but rather a set of characters.
Use removesuffix() to actually get rid of the trailing _<monitor name>.
Fixes: a82adadb16894 ("verification/rvgen: Add support for Hybrid Automata")
Signed-off-by: Gabriele Monaco <gmonaco@redhat.com>
---
tools/verification/rvgen/rvgen/dot2k.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/verification/rvgen/rvgen/dot2k.py b/tools/verification/rvgen/rvgen/dot2k.py
index e6f476b90..110cfd69e 100644
--- a/tools/verification/rvgen/rvgen/dot2k.py
+++ b/tools/verification/rvgen/rvgen/dot2k.py
@@ -215,14 +215,14 @@ class ha2k(dot2k):
def __get_constraint_env(self, constr: str) -> str:
"""Extract the second argument from an ha_ function"""
env = constr.split("(")[1].split()[1].rstrip(")").rstrip(",")
- assert env.rstrip(f"_{self.name}") in self.envs
+ assert env.removesuffix(f"_{self.name}") in self.envs
return env
def __start_to_invariant_check(self, constr: str) -> str:
# by default assume the timer has ns expiration
env = self.__get_constraint_env(constr)
clock_type = "ns"
- if self.env_types.get(env.rstrip(f"_{self.name}")) == "j":
+ if self.env_types.get(env.removesuffix(f"_{self.name}")) == "j":
clock_type = "jiffy"
return f"return ha_check_invariant_{clock_type}(ha_mon, {env}, time_ns)"
--
2.54.0
next prev parent reply other threads:[~2026-05-30 14:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-30 14:16 [PATCH v3 00/13] rv: Fixes on Deterministic and Hybrid Automata Gabriele Monaco
2026-05-30 14:16 ` [PATCH v3 01/13] rv: Fix __user specifier usage in extract_params() Gabriele Monaco
2026-05-30 14:16 ` [PATCH v3 02/13] rv: Reset per-task DA monitors before releasing the slot Gabriele Monaco
2026-05-30 14:16 ` [PATCH v3 03/13] rv: Prevent in-flight per-task handlers from using invalid slots Gabriele Monaco
2026-05-30 14:16 ` [PATCH v3 04/13] rv: Ensure all pending probes terminate on per-obj monitor destroy Gabriele Monaco
2026-05-30 14:16 ` [PATCH v3 05/13] rv: Fix monitor start ordering and memory ordering for monitoring flag Gabriele Monaco
2026-05-30 14:16 ` [PATCH v3 06/13] rv: Do not rely on clean monitor when initialising HA Gabriele Monaco
2026-05-30 14:16 ` [PATCH v3 07/13] rv: Add automatic cleanup handlers for per-task HA monitors Gabriele Monaco
2026-05-30 14:16 ` [PATCH v3 08/13] rv: Ensure synchronous cleanup for " Gabriele Monaco
2026-05-30 14:16 ` [PATCH v3 09/13] rv: Prevent task migration while handling per-CPU events Gabriele Monaco
2026-05-30 14:16 ` [PATCH v3 10/13] rv: Use 0 to check preemption enabled in opid Gabriele Monaco
2026-05-30 14:16 ` Gabriele Monaco [this message]
2026-05-30 14:16 ` [PATCH v3 12/13] rv: Fix read_lock scope in per-task DA cleanup Gabriele Monaco
2026-05-30 14:16 ` [PATCH v3 13/13] verification/rvgen: Generate cleanup hook for per-obj monitor Gabriele Monaco
2026-05-31 15:17 ` [PATCH v3 00/13] rv: Fixes on Deterministic and Hybrid Automata Wen Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260530141652.58084-12-gmonaco@redhat.com \
--to=gmonaco@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=namcao@linutronix.de \
--cc=rostedt@goodmis.org \
--cc=wen.yang@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox