From: Gabriele Monaco <gmonaco@redhat.com>
To: linux-kernel@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>,
Gabriele Monaco <gmonaco@redhat.com>,
linux-trace-kernel@vger.kernel.org
Cc: stable@vger.kernel.org, Wen Yang <wen.yang@linux.dev>,
Nam Cao <namcao@linutronix.de>
Subject: [PATCH v3 02/13] rv: Reset per-task DA monitors before releasing the slot
Date: Sat, 30 May 2026 16:16:41 +0200 [thread overview]
Message-ID: <20260530141652.58084-3-gmonaco@redhat.com> (raw)
In-Reply-To: <20260530141652.58084-1-gmonaco@redhat.com>
Per-task monitors use task_mon_slot to determine which slot in the array
to use for the monitor. During destruction, this slot is returned but
this is done before resetting the monitor. As a result, the monitor's
reset is in fact resetting a slot that is outside of the array
(RV_PER_TASK_MONITOR_INIT).
Release the slot only after the reset to avoid out-of-bound memory
access.
Fixes: f5587d1b6ec93 ("rv: Add Hybrid Automata monitor type")
Cc: stable@vger.kernel.org
Suggested-by: Wen Yang <wen.yang@linux.dev>
Reviewed-by: Wen Yang <wen.yang@linux.dev>
Reviewed-by: Nam Cao <namcao@linutronix.de>
Signed-off-by: Gabriele Monaco <gmonaco@redhat.com>
---
include/rv/da_monitor.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/include/rv/da_monitor.h b/include/rv/da_monitor.h
index 39765ff6f..1459fb3df 100644
--- a/include/rv/da_monitor.h
+++ b/include/rv/da_monitor.h
@@ -309,10 +309,11 @@ static inline void da_monitor_destroy(void)
WARN_ONCE(1, "Disabling a disabled monitor: " __stringify(MONITOR_NAME));
return;
}
- rv_put_task_monitor_slot(task_mon_slot);
- task_mon_slot = RV_PER_TASK_MONITOR_INIT;
da_monitor_reset_all();
+
+ rv_put_task_monitor_slot(task_mon_slot);
+ task_mon_slot = RV_PER_TASK_MONITOR_INIT;
}
#elif RV_MON_TYPE == RV_MON_PER_OBJ
--
2.54.0
next prev parent reply other threads:[~2026-05-30 14:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-30 14:16 [PATCH v3 00/13] rv: Fixes on Deterministic and Hybrid Automata Gabriele Monaco
2026-05-30 14:16 ` [PATCH v3 01/13] rv: Fix __user specifier usage in extract_params() Gabriele Monaco
2026-05-30 14:16 ` Gabriele Monaco [this message]
2026-05-30 14:16 ` [PATCH v3 03/13] rv: Prevent in-flight per-task handlers from using invalid slots Gabriele Monaco
2026-05-30 14:16 ` [PATCH v3 04/13] rv: Ensure all pending probes terminate on per-obj monitor destroy Gabriele Monaco
2026-05-30 14:16 ` [PATCH v3 05/13] rv: Fix monitor start ordering and memory ordering for monitoring flag Gabriele Monaco
2026-05-30 14:16 ` [PATCH v3 06/13] rv: Do not rely on clean monitor when initialising HA Gabriele Monaco
2026-05-30 14:16 ` [PATCH v3 07/13] rv: Add automatic cleanup handlers for per-task HA monitors Gabriele Monaco
2026-05-30 14:16 ` [PATCH v3 08/13] rv: Ensure synchronous cleanup for " Gabriele Monaco
2026-05-30 14:16 ` [PATCH v3 09/13] rv: Prevent task migration while handling per-CPU events Gabriele Monaco
2026-05-30 14:16 ` [PATCH v3 10/13] rv: Use 0 to check preemption enabled in opid Gabriele Monaco
2026-05-30 14:16 ` [PATCH v3 11/13] verification/rvgen: Fix suffix strip in dot2k Gabriele Monaco
2026-05-30 14:16 ` [PATCH v3 12/13] rv: Fix read_lock scope in per-task DA cleanup Gabriele Monaco
2026-05-30 14:16 ` [PATCH v3 13/13] verification/rvgen: Generate cleanup hook for per-obj monitor Gabriele Monaco
2026-05-31 15:17 ` [PATCH v3 00/13] rv: Fixes on Deterministic and Hybrid Automata Wen Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260530141652.58084-3-gmonaco@redhat.com \
--to=gmonaco@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=namcao@linutronix.de \
--cc=rostedt@goodmis.org \
--cc=stable@vger.kernel.org \
--cc=wen.yang@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox