Linux Trace Kernel
 help / color / mirror / Atom feed
From: Gabriele Monaco <gmonaco@redhat.com>
To: linux-kernel@vger.kernel.org,
	Steven Rostedt <rostedt@goodmis.org>,
	Gabriele Monaco <gmonaco@redhat.com>,
	linux-trace-kernel@vger.kernel.org
Cc: Wen Yang <wen.yang@linux.dev>, Nam Cao <namcao@linutronix.de>
Subject: [PATCH v3 12/13] rv: Fix read_lock scope in per-task DA cleanup
Date: Sat, 30 May 2026 16:16:51 +0200	[thread overview]
Message-ID: <20260530141652.58084-13-gmonaco@redhat.com> (raw)
In-Reply-To: <20260530141652.58084-1-gmonaco@redhat.com>

The da_monitor_reset_all() function for per-task monitors takes
tasklist_lock while iterating over tasks, then keeps it also while
iterating over idle tasks (one per CPU). The latter is not necessary
since the lock needs to guard only for_each_process_thread().

Use a scoped_guard for more compact syntax and adjust the scope only
where the lock is necessary.

Reviewed-by: Wen Yang <wen.yang@linux.dev>
Reviewed-by: Nam Cao <namcao@linutronix.de>
Signed-off-by: Gabriele Monaco <gmonaco@redhat.com>
---
 include/rv/da_monitor.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/include/rv/da_monitor.h b/include/rv/da_monitor.h
index ae8c35fcb..f4fc22cac 100644
--- a/include/rv/da_monitor.h
+++ b/include/rv/da_monitor.h
@@ -294,12 +294,12 @@ static void da_monitor_reset_all(void)
 	struct task_struct *g, *p;
 	int cpu;
 
-	read_lock(&tasklist_lock);
-	for_each_process_thread(g, p)
-		da_monitor_reset(da_get_monitor(p));
+	scoped_guard(read_lock, &tasklist_lock) {
+		for_each_process_thread(g, p)
+			da_monitor_reset(da_get_monitor(p));
+	}
 	for_each_present_cpu(cpu)
 		da_monitor_reset(da_get_monitor(idle_task(cpu)));
-	read_unlock(&tasklist_lock);
 }
 
 /*
-- 
2.54.0


  parent reply	other threads:[~2026-05-30 14:17 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-30 14:16 [PATCH v3 00/13] rv: Fixes on Deterministic and Hybrid Automata Gabriele Monaco
2026-05-30 14:16 ` [PATCH v3 01/13] rv: Fix __user specifier usage in extract_params() Gabriele Monaco
2026-05-30 14:16 ` [PATCH v3 02/13] rv: Reset per-task DA monitors before releasing the slot Gabriele Monaco
2026-05-30 14:16 ` [PATCH v3 03/13] rv: Prevent in-flight per-task handlers from using invalid slots Gabriele Monaco
2026-05-30 14:16 ` [PATCH v3 04/13] rv: Ensure all pending probes terminate on per-obj monitor destroy Gabriele Monaco
2026-05-30 14:16 ` [PATCH v3 05/13] rv: Fix monitor start ordering and memory ordering for monitoring flag Gabriele Monaco
2026-05-30 14:16 ` [PATCH v3 06/13] rv: Do not rely on clean monitor when initialising HA Gabriele Monaco
2026-05-30 14:16 ` [PATCH v3 07/13] rv: Add automatic cleanup handlers for per-task HA monitors Gabriele Monaco
2026-05-30 14:16 ` [PATCH v3 08/13] rv: Ensure synchronous cleanup for " Gabriele Monaco
2026-05-30 14:16 ` [PATCH v3 09/13] rv: Prevent task migration while handling per-CPU events Gabriele Monaco
2026-05-30 14:16 ` [PATCH v3 10/13] rv: Use 0 to check preemption enabled in opid Gabriele Monaco
2026-05-30 14:16 ` [PATCH v3 11/13] verification/rvgen: Fix suffix strip in dot2k Gabriele Monaco
2026-05-30 14:16 ` Gabriele Monaco [this message]
2026-05-30 14:16 ` [PATCH v3 13/13] verification/rvgen: Generate cleanup hook for per-obj monitor Gabriele Monaco
2026-05-31 15:17 ` [PATCH v3 00/13] rv: Fixes on Deterministic and Hybrid Automata Wen Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260530141652.58084-13-gmonaco@redhat.com \
    --to=gmonaco@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=namcao@linutronix.de \
    --cc=rostedt@goodmis.org \
    --cc=wen.yang@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox