[uml-devel] [PATCH] um, x86: Fix vDSO build

[uml-devel] [PATCH] um, x86: Fix vDSO build

[Richard Weinberger]

Commit "x86: Delete non-required instances of include <linux/init.h>"
broke the UML build.

arch/x86/um/vdso/vdso.S: Assembler messages:
arch/x86/um/vdso/vdso.S:2: Error: no such instruction: `__initdata'
arch/x86/um/vdso/vdso.S:9: Error: no such instruction: `__finit'

UML's vDSO needs linux/init.h.

Signed-off-by: Richard Weinberger <richard@nod.at>
---
 arch/x86/um/vdso/vdso.S | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/x86/um/vdso/vdso.S b/arch/x86/um/vdso/vdso.S
index 4b4bd4c..1cb468a 100644
--- a/arch/x86/um/vdso/vdso.S
+++ b/arch/x86/um/vdso/vdso.S
@@ -1,3 +1,4 @@
+#include <linux/init.h>
 
 __INITDATA
 
-- 
1.8.1.4


------------------------------------------------------------------------------
CenturyLink Cloud: The Leader in Enterprise Cloud Services.
Learn Why More Businesses Are Choosing CenturyLink Cloud For
Critical Workloads, Development Environments & Everything In Between.
Get a Quote or Start a Free Trial Today.
http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] [PATCH] um, x86: Fix vDSO build

[H. Peter Anvin]

On 01/12/2014 06:52 AM, Richard Weinberger wrote:
> Commit "x86: Delete non-required instances of include <linux/init.h>"
> broke the UML build.
> 
> arch/x86/um/vdso/vdso.S: Assembler messages:
> arch/x86/um/vdso/vdso.S:2: Error: no such instruction: `__initdata'
> arch/x86/um/vdso/vdso.S:9: Error: no such instruction: `__finit'
> 
> UML's vDSO needs linux/init.h.
> 
> Signed-off-by: Richard Weinberger <richard@nod.at>
> ---
>  arch/x86/um/vdso/vdso.S | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/x86/um/vdso/vdso.S b/arch/x86/um/vdso/vdso.S
> index 4b4bd4c..1cb468a 100644
> --- a/arch/x86/um/vdso/vdso.S
> +++ b/arch/x86/um/vdso/vdso.S
> @@ -1,3 +1,4 @@
> +#include <linux/init.h>
>  
>  __INITDATA
>  

So more bits that got "cleaned up" but never actually tested.  Sigh.

Fengguang, could we get UM builds added to the test robot?

	-hpa



------------------------------------------------------------------------------
CenturyLink Cloud: The Leader in Enterprise Cloud Services.
Learn Why More Businesses Are Choosing CenturyLink Cloud For
Critical Workloads, Development Environments & Everything In Between.
Get a Quote or Start a Free Trial Today.
http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] [PATCH] um, x86: Fix vDSO build

[Richard Weinberger]

Am Sonntag, 12. Januar 2014, 09:02:06 schrieb H. Peter Anvin:
> On 01/12/2014 06:52 AM, Richard Weinberger wrote:
> > Commit "x86: Delete non-required instances of include <linux/init.h>"
> > broke the UML build.
> > 
> > arch/x86/um/vdso/vdso.S: Assembler messages:
> > arch/x86/um/vdso/vdso.S:2: Error: no such instruction: `__initdata'
> > arch/x86/um/vdso/vdso.S:9: Error: no such instruction: `__finit'
> > 
> > UML's vDSO needs linux/init.h.
> > 
> > Signed-off-by: Richard Weinberger <richard@nod.at>
> > ---
> > 
> >  arch/x86/um/vdso/vdso.S | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/arch/x86/um/vdso/vdso.S b/arch/x86/um/vdso/vdso.S
> > index 4b4bd4c..1cb468a 100644
> > --- a/arch/x86/um/vdso/vdso.S
> > +++ b/arch/x86/um/vdso/vdso.S
> > @@ -1,3 +1,4 @@
> > +#include <linux/init.h>
> > 
> >  __INITDATA
> 
> So more bits that got "cleaned up" but never actually tested.  Sigh.
> 
> Fengguang, could we get UM builds added to the test robot?

Would be great!

Fengguang, please make sure that you build both UML/i386 and UML/x86_64.
i.e. make defconfig ARCH=um SUBARCH=i386 && make linux ARCH=um
and make defconfig ARCH=um SUBARCH=x86 && make linux ARCH=um

Thanks,
//richard

------------------------------------------------------------------------------
CenturyLink Cloud: The Leader in Enterprise Cloud Services.
Learn Why More Businesses Are Choosing CenturyLink Cloud For
Critical Workloads, Development Environments & Everything In Between.
Get a Quote or Start a Free Trial Today.
http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] [PATCH] um, x86: Fix vDSO build

[Paul Gortmaker]

[[PATCH] um, x86: Fix vDSO build] On 12/01/2014 (Sun 15:52) Richard Weinberger wrote:

> Commit "x86: Delete non-required instances of include <linux/init.h>"
> broke the UML build.
> 
> arch/x86/um/vdso/vdso.S: Assembler messages:
> arch/x86/um/vdso/vdso.S:2: Error: no such instruction: `__initdata'
> arch/x86/um/vdso/vdso.S:9: Error: no such instruction: `__finit'
> 
> UML's vDSO needs linux/init.h.
> 
> Signed-off-by: Richard Weinberger <richard@nod.at>

Thanks Richard & Ingo.  I did these cleanups last fall but never got
around to submitting them until now;  I think the false positives for
removal crept in when I manually started the process, before realizing
the scale of it needed automatic selection/application and verification.

And without me doing uml testing, I never got a chance to see the
breakage and undo it.  I'll definitely add uml to my regular testing.

I see hpa has already put this on x86/cleanups, but for the record:

Acked-by: Paul Gortmaker <paul.gortmaker@windriver.com>

Thanks again and sorry for the inconvenience.
P.
--

> ---
>  arch/x86/um/vdso/vdso.S | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/x86/um/vdso/vdso.S b/arch/x86/um/vdso/vdso.S
> index 4b4bd4c..1cb468a 100644
> --- a/arch/x86/um/vdso/vdso.S
> +++ b/arch/x86/um/vdso/vdso.S
> @@ -1,3 +1,4 @@
> +#include <linux/init.h>
>  
>  __INITDATA
>  
> -- 
> 1.8.1.4
> 

------------------------------------------------------------------------------
CenturyLink Cloud: The Leader in Enterprise Cloud Services.
Learn Why More Businesses Are Choosing CenturyLink Cloud For
Critical Workloads, Development Environments & Everything In Between.
Get a Quote or Start a Free Trial Today.
http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] [PATCH] um, x86: Fix vDSO build

[Geert Uytterhoeven]

On Sun, Jan 12, 2014 at 6:17 PM, Richard Weinberger <richard@nod.at> wrote:
> Fengguang, please make sure that you build both UML/i386 and UML/x86_64.
> i.e. make defconfig ARCH=um SUBARCH=i386 && make linux ARCH=um
> and make defconfig ARCH=um SUBARCH=x86 && make linux ARCH=um

x86 or x86_64?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [uml-devel] [PATCH] um, x86: Fix vDSO build

[Richard Weinberger]

Am Sonntag, 12. Januar 2014, 19:58:06 schrieb Geert Uytterhoeven:
> On Sun, Jan 12, 2014 at 6:17 PM, Richard Weinberger <richard@nod.at> wrote:
> > Fengguang, please make sure that you build both UML/i386 and UML/x86_64.
> > i.e. make defconfig ARCH=um SUBARCH=i386 && make linux ARCH=um
> > and make defconfig ARCH=um SUBARCH=x86 && make linux ARCH=um
> 
> x86 or x86_64?

Both x86 and x86_64 will create a CONFIG_64BIT=y .config.

Thanks,
//richard

Re: [uml-devel] [PATCH] um, x86: Fix vDSO build

[Fengguang Wu]

> Fengguang, could we get UM builds added to the test robot?

Yes, sure. Just added UML i386/x86_64 to the build tests.

Thanks,
Fengguang

------------------------------------------------------------------------------
CenturyLink Cloud: The Leader in Enterprise Cloud Services.
Learn Why More Businesses Are Choosing CenturyLink Cloud For
Critical Workloads, Development Environments & Everything In Between.
Get a Quote or Start a Free Trial Today. 
http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] [PATCH] um, x86: Fix vDSO build

[H. Peter Anvin]

On 01/13/2014 04:50 AM, Fengguang Wu wrote:
>> Fengguang, could we get UM builds added to the test robot?
> 
> Yes, sure. Just added UML i386/x86_64 to the build tests.
> 

Thank you!  That will be highly useful.

	-hpa



------------------------------------------------------------------------------
CenturyLink Cloud: The Leader in Enterprise Cloud Services.
Learn Why More Businesses Are Choosing CenturyLink Cloud For
Critical Workloads, Development Environments & Everything In Between.
Get a Quote or Start a Free Trial Today. 
http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel