* [uml-devel] [PATCH] um, x86: Fix vDSO build [not found] <20140112120305.GA13076@gmail.com> @ 2014-01-12 14:52 ` Richard Weinberger 2014-01-12 17:02 ` H. Peter Anvin 2014-01-12 17:18 ` Paul Gortmaker 0 siblings, 2 replies; 8+ messages in thread From: Richard Weinberger @ 2014-01-12 14:52 UTC (permalink / raw) To: mingo Cc: user-mode-linux-devel, linux-tip-commits, Richard Weinberger, paul.gortmaker, hpa, tglx Commit "x86: Delete non-required instances of include <linux/init.h>" broke the UML build. arch/x86/um/vdso/vdso.S: Assembler messages: arch/x86/um/vdso/vdso.S:2: Error: no such instruction: `__initdata' arch/x86/um/vdso/vdso.S:9: Error: no such instruction: `__finit' UML's vDSO needs linux/init.h. Signed-off-by: Richard Weinberger <richard@nod.at> --- arch/x86/um/vdso/vdso.S | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/x86/um/vdso/vdso.S b/arch/x86/um/vdso/vdso.S index 4b4bd4c..1cb468a 100644 --- a/arch/x86/um/vdso/vdso.S +++ b/arch/x86/um/vdso/vdso.S @@ -1,3 +1,4 @@ +#include <linux/init.h> __INITDATA -- 1.8.1.4 ------------------------------------------------------------------------------ CenturyLink Cloud: The Leader in Enterprise Cloud Services. Learn Why More Businesses Are Choosing CenturyLink Cloud For Critical Workloads, Development Environments & Everything In Between. Get a Quote or Start a Free Trial Today. http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk _______________________________________________ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [uml-devel] [PATCH] um, x86: Fix vDSO build 2014-01-12 14:52 ` [uml-devel] [PATCH] um, x86: Fix vDSO build Richard Weinberger @ 2014-01-12 17:02 ` H. Peter Anvin 2014-01-12 17:17 ` Richard Weinberger 2014-01-13 12:50 ` Fengguang Wu 2014-01-12 17:18 ` Paul Gortmaker 1 sibling, 2 replies; 8+ messages in thread From: H. Peter Anvin @ 2014-01-12 17:02 UTC (permalink / raw) To: Richard Weinberger, mingo, Fengguang Wu Cc: paul.gortmaker, tglx, user-mode-linux-devel, linux-tip-commits On 01/12/2014 06:52 AM, Richard Weinberger wrote: > Commit "x86: Delete non-required instances of include <linux/init.h>" > broke the UML build. > > arch/x86/um/vdso/vdso.S: Assembler messages: > arch/x86/um/vdso/vdso.S:2: Error: no such instruction: `__initdata' > arch/x86/um/vdso/vdso.S:9: Error: no such instruction: `__finit' > > UML's vDSO needs linux/init.h. > > Signed-off-by: Richard Weinberger <richard@nod.at> > --- > arch/x86/um/vdso/vdso.S | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/x86/um/vdso/vdso.S b/arch/x86/um/vdso/vdso.S > index 4b4bd4c..1cb468a 100644 > --- a/arch/x86/um/vdso/vdso.S > +++ b/arch/x86/um/vdso/vdso.S > @@ -1,3 +1,4 @@ > +#include <linux/init.h> > > __INITDATA > So more bits that got "cleaned up" but never actually tested. Sigh. Fengguang, could we get UM builds added to the test robot? -hpa ------------------------------------------------------------------------------ CenturyLink Cloud: The Leader in Enterprise Cloud Services. Learn Why More Businesses Are Choosing CenturyLink Cloud For Critical Workloads, Development Environments & Everything In Between. Get a Quote or Start a Free Trial Today. http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk _______________________________________________ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [uml-devel] [PATCH] um, x86: Fix vDSO build 2014-01-12 17:02 ` H. Peter Anvin @ 2014-01-12 17:17 ` Richard Weinberger 2014-01-12 18:58 ` Geert Uytterhoeven 2014-01-13 12:50 ` Fengguang Wu 1 sibling, 1 reply; 8+ messages in thread From: Richard Weinberger @ 2014-01-12 17:17 UTC (permalink / raw) To: H. Peter Anvin Cc: user-mode-linux-devel, linux-tip-commits, paul.gortmaker, mingo, tglx, Fengguang Wu Am Sonntag, 12. Januar 2014, 09:02:06 schrieb H. Peter Anvin: > On 01/12/2014 06:52 AM, Richard Weinberger wrote: > > Commit "x86: Delete non-required instances of include <linux/init.h>" > > broke the UML build. > > > > arch/x86/um/vdso/vdso.S: Assembler messages: > > arch/x86/um/vdso/vdso.S:2: Error: no such instruction: `__initdata' > > arch/x86/um/vdso/vdso.S:9: Error: no such instruction: `__finit' > > > > UML's vDSO needs linux/init.h. > > > > Signed-off-by: Richard Weinberger <richard@nod.at> > > --- > > > > arch/x86/um/vdso/vdso.S | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/x86/um/vdso/vdso.S b/arch/x86/um/vdso/vdso.S > > index 4b4bd4c..1cb468a 100644 > > --- a/arch/x86/um/vdso/vdso.S > > +++ b/arch/x86/um/vdso/vdso.S > > @@ -1,3 +1,4 @@ > > +#include <linux/init.h> > > > > __INITDATA > > So more bits that got "cleaned up" but never actually tested. Sigh. > > Fengguang, could we get UM builds added to the test robot? Would be great! Fengguang, please make sure that you build both UML/i386 and UML/x86_64. i.e. make defconfig ARCH=um SUBARCH=i386 && make linux ARCH=um and make defconfig ARCH=um SUBARCH=x86 && make linux ARCH=um Thanks, //richard ------------------------------------------------------------------------------ CenturyLink Cloud: The Leader in Enterprise Cloud Services. Learn Why More Businesses Are Choosing CenturyLink Cloud For Critical Workloads, Development Environments & Everything In Between. Get a Quote or Start a Free Trial Today. http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk _______________________________________________ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [uml-devel] [PATCH] um, x86: Fix vDSO build 2014-01-12 17:17 ` Richard Weinberger @ 2014-01-12 18:58 ` Geert Uytterhoeven 2014-01-12 19:01 ` Richard Weinberger 0 siblings, 1 reply; 8+ messages in thread From: Geert Uytterhoeven @ 2014-01-12 18:58 UTC (permalink / raw) To: Richard Weinberger Cc: H. Peter Anvin, uml-devel, linux-tip-commits, Paul Gortmaker, Ingo Molnar, Thomas Gleixner, Fengguang Wu On Sun, Jan 12, 2014 at 6:17 PM, Richard Weinberger <richard@nod.at> wrote: > Fengguang, please make sure that you build both UML/i386 and UML/x86_64. > i.e. make defconfig ARCH=um SUBARCH=i386 && make linux ARCH=um > and make defconfig ARCH=um SUBARCH=x86 && make linux ARCH=um x86 or x86_64? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [uml-devel] [PATCH] um, x86: Fix vDSO build 2014-01-12 18:58 ` Geert Uytterhoeven @ 2014-01-12 19:01 ` Richard Weinberger 0 siblings, 0 replies; 8+ messages in thread From: Richard Weinberger @ 2014-01-12 19:01 UTC (permalink / raw) To: Geert Uytterhoeven Cc: H. Peter Anvin, uml-devel, linux-tip-commits, Paul Gortmaker, Ingo Molnar, Thomas Gleixner, Fengguang Wu Am Sonntag, 12. Januar 2014, 19:58:06 schrieb Geert Uytterhoeven: > On Sun, Jan 12, 2014 at 6:17 PM, Richard Weinberger <richard@nod.at> wrote: > > Fengguang, please make sure that you build both UML/i386 and UML/x86_64. > > i.e. make defconfig ARCH=um SUBARCH=i386 && make linux ARCH=um > > and make defconfig ARCH=um SUBARCH=x86 && make linux ARCH=um > > x86 or x86_64? Both x86 and x86_64 will create a CONFIG_64BIT=y .config. Thanks, //richard ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [uml-devel] [PATCH] um, x86: Fix vDSO build 2014-01-12 17:02 ` H. Peter Anvin 2014-01-12 17:17 ` Richard Weinberger @ 2014-01-13 12:50 ` Fengguang Wu 2014-01-13 20:01 ` H. Peter Anvin 1 sibling, 1 reply; 8+ messages in thread From: Fengguang Wu @ 2014-01-13 12:50 UTC (permalink / raw) To: H. Peter Anvin Cc: user-mode-linux-devel, linux-tip-commits, Richard Weinberger, paul.gortmaker, mingo, tglx > Fengguang, could we get UM builds added to the test robot? Yes, sure. Just added UML i386/x86_64 to the build tests. Thanks, Fengguang ------------------------------------------------------------------------------ CenturyLink Cloud: The Leader in Enterprise Cloud Services. Learn Why More Businesses Are Choosing CenturyLink Cloud For Critical Workloads, Development Environments & Everything In Between. Get a Quote or Start a Free Trial Today. http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk _______________________________________________ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [uml-devel] [PATCH] um, x86: Fix vDSO build 2014-01-13 12:50 ` Fengguang Wu @ 2014-01-13 20:01 ` H. Peter Anvin 0 siblings, 0 replies; 8+ messages in thread From: H. Peter Anvin @ 2014-01-13 20:01 UTC (permalink / raw) To: Fengguang Wu Cc: user-mode-linux-devel, linux-tip-commits, Richard Weinberger, paul.gortmaker, mingo, tglx On 01/13/2014 04:50 AM, Fengguang Wu wrote: >> Fengguang, could we get UM builds added to the test robot? > > Yes, sure. Just added UML i386/x86_64 to the build tests. > Thank you! That will be highly useful. -hpa ------------------------------------------------------------------------------ CenturyLink Cloud: The Leader in Enterprise Cloud Services. Learn Why More Businesses Are Choosing CenturyLink Cloud For Critical Workloads, Development Environments & Everything In Between. Get a Quote or Start a Free Trial Today. http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk _______________________________________________ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [uml-devel] [PATCH] um, x86: Fix vDSO build 2014-01-12 14:52 ` [uml-devel] [PATCH] um, x86: Fix vDSO build Richard Weinberger 2014-01-12 17:02 ` H. Peter Anvin @ 2014-01-12 17:18 ` Paul Gortmaker 1 sibling, 0 replies; 8+ messages in thread From: Paul Gortmaker @ 2014-01-12 17:18 UTC (permalink / raw) To: Richard Weinberger Cc: linux-tip-commits, tglx, mingo, user-mode-linux-devel, hpa [[PATCH] um, x86: Fix vDSO build] On 12/01/2014 (Sun 15:52) Richard Weinberger wrote: > Commit "x86: Delete non-required instances of include <linux/init.h>" > broke the UML build. > > arch/x86/um/vdso/vdso.S: Assembler messages: > arch/x86/um/vdso/vdso.S:2: Error: no such instruction: `__initdata' > arch/x86/um/vdso/vdso.S:9: Error: no such instruction: `__finit' > > UML's vDSO needs linux/init.h. > > Signed-off-by: Richard Weinberger <richard@nod.at> Thanks Richard & Ingo. I did these cleanups last fall but never got around to submitting them until now; I think the false positives for removal crept in when I manually started the process, before realizing the scale of it needed automatic selection/application and verification. And without me doing uml testing, I never got a chance to see the breakage and undo it. I'll definitely add uml to my regular testing. I see hpa has already put this on x86/cleanups, but for the record: Acked-by: Paul Gortmaker <paul.gortmaker@windriver.com> Thanks again and sorry for the inconvenience. P. -- > --- > arch/x86/um/vdso/vdso.S | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/x86/um/vdso/vdso.S b/arch/x86/um/vdso/vdso.S > index 4b4bd4c..1cb468a 100644 > --- a/arch/x86/um/vdso/vdso.S > +++ b/arch/x86/um/vdso/vdso.S > @@ -1,3 +1,4 @@ > +#include <linux/init.h> > > __INITDATA > > -- > 1.8.1.4 > ------------------------------------------------------------------------------ CenturyLink Cloud: The Leader in Enterprise Cloud Services. Learn Why More Businesses Are Choosing CenturyLink Cloud For Critical Workloads, Development Environments & Everything In Between. Get a Quote or Start a Free Trial Today. http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk _______________________________________________ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2014-01-13 20:01 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20140112120305.GA13076@gmail.com>
2014-01-12 14:52 ` [uml-devel] [PATCH] um, x86: Fix vDSO build Richard Weinberger
2014-01-12 17:02 ` H. Peter Anvin
2014-01-12 17:17 ` Richard Weinberger
2014-01-12 18:58 ` Geert Uytterhoeven
2014-01-12 19:01 ` Richard Weinberger
2014-01-13 12:50 ` Fengguang Wu
2014-01-13 20:01 ` H. Peter Anvin
2014-01-12 17:18 ` Paul Gortmaker
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).