[uml-devel] PATCH [00/03]: allow building of UML with skas headers installed via `make headers_install'

[uml-devel] PATCH [00/03]: allow building of UML with skas headers installed via `make headers_install'

[Nix]

I recently upgraded my glibc to 2.5, and upgraded the userspace headers
at the same time. As a result, I've had several problems with UML.

One of these Jeff has seen reported and fixed, although the correct
cause was not described (the #inclusion of <linux/stddef.h> instead of
<stddef.h> in user-offsets.c).

However, other problems are so-far undescribed. There's one trivial one
(fixed in patch 3 in this series, should be uncontroversial).

And then there's this:

  CC      arch/um/os-Linux/process.o
In file included from arch/um/include/skas_ptrace.h:12,
                 from arch/um/os-Linux/process.c:23:
arch/um/include/sysdep/skas_ptrace.h:9: error: redefinition of `struct ptrace_faultinfo'
arch/um/include/sysdep/skas_ptrace.h:14: error: redefinition of `struct ptrace_ldt'

The problem is that I installed my host kernel's headers, and that
kernel has the skas patch installed, so the skas ptrace structures
are already defined in <asm/ptrace.h>. Thankfully it's guarded by a
#define that we can test, but even so we need to split that SKAS
section out into a new header. (diff attached, not gitted since
the SKAS part isn't maintained in git anyway.)

So the following patches are a terribly provisional way to fix this:
it works but it may not maintain the separation between skas and
mainline that you want. At least it points up the existence of the
problems.

There are two patches in this series: one which splits the skas part of
ptrace.h into its own header, so that UML can use it, and one that
uses that header instead of skas_ptrace.h.

(All diffs against 2.6.18.x: I can respin against 2.6.19-pre if you
want, but, again, this area changes little so I'd expect things to
apply reasonably well anyway.)

-- 
`The main high-level difference between Emacs and (say) UNIX, Windows,
 or BeOS... is that Emacs boots quicker.' --- PdS

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] PATCH [00/03]: allow building of UML with skas headers installed via `make headers_install'

[Blaisorblade]

On Sunday 26 November 2006 22:02, Nix wrote:
> I recently upgraded my glibc to 2.5, and upgraded the userspace headers
> at the same time. As a result, I've had several problems with UML.
>
> One of these Jeff has seen reported and fixed, although the correct
> cause was not described (the #inclusion of <linux/stddef.h> instead of
> <stddef.h> in user-offsets.c).
>
> However, other problems are so-far undescribed. There's one trivial one
> (fixed in patch 3 in this series, should be uncontroversial).
Agreed.

> And then there's this:
>
>   CC      arch/um/os-Linux/process.o
> In file included from arch/um/include/skas_ptrace.h:12,
>                  from arch/um/os-Linux/process.c:23:
> arch/um/include/sysdep/skas_ptrace.h:9: error: redefinition of `struct
> ptrace_faultinfo' arch/um/include/sysdep/skas_ptrace.h:14: error:
> redefinition of `struct ptrace_ldt'

> The problem is that I installed my host kernel's headers, and that
> kernel has the skas patch installed, so the skas ptrace structures
> are already defined in <asm/ptrace.h>. Thankfully it's guarded by a
> #define that we can test, but even so we need to split that SKAS
> section out into a new header. (diff attached, not gitted since
> the SKAS part isn't maintained in git anyway.)

> So the following patches are a terribly provisional way to fix this:
> it works but it may not maintain the separation between skas and
> mainline that you want.
You maybe refer to the problem that without SKAS in host headers the resulting 
UML tree does not compile? Yes, it is a problem. You are trying to remove all 
duplications, and probably you should avoid them. Define a macro to test with 
a more reasonable name (say __UML_SKAS_SUPPORT ...).

> At least it points up the existence of the 
> problems.

> There are two patches in this series: one which splits the skas part of
> ptrace.h into its own header, so that UML can use it, and one that
> uses that header instead of skas_ptrace.h.
>
> (All diffs against 2.6.18.x: I can respin against 2.6.19-pre if you
> want, but, again, this area changes little so I'd expect things to
> apply reasonably well anyway.)

-- 
Inform me of my mistakes, so I can add them to my list!
Paolo Giarrusso, aka Blaisorblade
http://www.user-mode-linux.org/~blaisorblade

Chiacchiera con i tuoi amici in tempo reale! 
 http://it.yahoo.com/mail_it/foot/*http://it.messenger.yahoo.com 


-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] PATCH [00/03]: allow building of UML with skas headers installed via `make headers_install'

[Nix]

On 29 Nov 2006, blaisorblade@yahoo.it verbalised:
> On Sunday 26 November 2006 22:02, Nix wrote:
>> However, other problems are so-far undescribed. There's one trivial one
>> (fixed in patch 3 in this series, should be uncontroversial).
> Agreed.

Oh good, that's the only one I was confident of.

>> And then there's this:
>>
>>   CC      arch/um/os-Linux/process.o
>> In file included from arch/um/include/skas_ptrace.h:12,
>>                  from arch/um/os-Linux/process.c:23:
>> arch/um/include/sysdep/skas_ptrace.h:9: error: redefinition of `struct
>> ptrace_faultinfo' arch/um/include/sysdep/skas_ptrace.h:14: error:
>> redefinition of `struct ptrace_ldt'
>
>> The problem is that I installed my host kernel's headers, and that
>> kernel has the skas patch installed, so the skas ptrace structures
>> are already defined in <asm/ptrace.h>. Thankfully it's guarded by a
>> #define that we can test, but even so we need to split that SKAS
>> section out into a new header. (diff attached, not gitted since
>> the SKAS part isn't maintained in git anyway.)
>
>> So the following patches are a terribly provisional way to fix this:
>> it works but it may not maintain the separation between skas and
>> mainline that you want.
> 
> You maybe refer to the problem that without SKAS in host headers the resulting 
> UML tree does not compile?

I *have* SKAS in the host headers. That's the problem (and it arguably
shouldn't be).

>                             Yes, it is a problem. You are trying to remove all 
> duplications, and probably you should avoid them. Define a macro to test with 
> a more reasonable name (say __UML_SKAS_SUPPORT ...).

OK, will do. I just thought that cutting the skas-ptrace stuff into its
own header, rather than duplicating pieces of it between arch/ and
include/um/, seemed more immediately reasonable.

-- 
`The main high-level difference between Emacs and (say) UNIX, Windows,
 or BeOS... is that Emacs boots quicker.' --- PdS

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] PATCH [00/03]: allow building of UML with skas headers installed via `make headers_install'

[Blaisorblade]

On Friday 01 December 2006 16:15, Nix wrote:
> On 29 Nov 2006, blaisorblade@yahoo.it verbalised:
> > On Sunday 26 November 2006 22:02, Nix wrote:
> >> However, other problems are so-far undescribed. There's one trivial one
> >> (fixed in patch 3 in this series, should be uncontroversial).
> >
> > Agreed.
>
> Oh good, that's the only one I was confident of.
>
> >> And then there's this:
> >>
> >>   CC      arch/um/os-Linux/process.o
> >> In file included from arch/um/include/skas_ptrace.h:12,
> >>                  from arch/um/os-Linux/process.c:23:
> >> arch/um/include/sysdep/skas_ptrace.h:9: error: redefinition of `struct
> >> ptrace_faultinfo' arch/um/include/sysdep/skas_ptrace.h:14: error:
> >> redefinition of `struct ptrace_ldt'
> >>
> >> The problem is that I installed my host kernel's headers, and that
> >> kernel has the skas patch installed, so the skas ptrace structures
> >> are already defined in <asm/ptrace.h>. Thankfully it's guarded by a
> >> #define that we can test, but even so we need to split that SKAS
> >> section out into a new header. (diff attached, not gitted since
> >> the SKAS part isn't maintained in git anyway.)
> >>
> >> So the following patches are a terribly provisional way to fix this:
> >> it works but it may not maintain the separation between skas and
> >> mainline that you want.
> >
> > You maybe refer to the problem that without SKAS in host headers the
> > resulting UML tree does not compile?
>
> I *have* SKAS in the host headers. That's the problem (and it arguably
> shouldn't be).

Yes, I understood this, but with your patches the set of people having a 
problem is complemented (whoever _hasn't_ SKAS in host headers has a 
problem).

> >                             Yes, it is a problem. You are trying to
> > remove all duplications, and probably you should avoid them. Define a
> > macro to test with a more reasonable name (say __UML_SKAS_SUPPORT ...).
>
> OK, will do. I just thought that cutting the skas-ptrace stuff into its
> own header, rather than duplicating pieces of it between arch/ and
> include/um/, seemed more immediately reasonable.

-- 
Inform me of my mistakes, so I can add them to my list!
Paolo Giarrusso, aka Blaisorblade
http://www.user-mode-linux.org/~blaisorblade
Chiacchiera con i tuoi amici in tempo reale! 
 http://it.yahoo.com/mail_it/foot/*http://it.messenger.yahoo.com 


-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel