Linux USB
 help / color / mirror / Atom feed
* [v2,1/1] r8152: sync sa_family with the media type of network device
@ 2019-04-22  5:03 crag0715
  2019-04-22  5:03 ` [PATCH v2 1/1] " crag0715
                   ` (3 more replies)
  0 siblings, 4 replies; 14+ messages in thread
From: crag0715 @ 2019-04-22  5:03 UTC (permalink / raw)
  To: linux-usb, netdev
  Cc: linux-kernel, hayeswang, mario_limonciello, crag0715, Crag.Wang,
	David S. Miller, Simon Glass, Grant Grundler, Sean Paul,
	David Chen, Kai-Heng Feng, Gustavo A. R. Silva, Charles Hyde,
	Sebastian Andrzej Siewior, zhong jiang

From: "Crag.Wang" <crag.wang@dell.com>

Without this patch the socket address family sporadically gets wrong
value ends up the dev_set_mac_address() fails to set the desired MAC
address.

Signed-off-by: Crag.Wang <crag.wang@dell.com>
---
 drivers/net/usb/r8152.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
index 4c63b40d5e00..41fb39ce69c9 100644
--- a/drivers/net/usb/r8152.c
+++ b/drivers/net/usb/r8152.c
@@ -1225,6 +1225,8 @@ static int determine_ethernet_addr(struct r8152 *tp, struct sockaddr *sa)
 	struct net_device *dev = tp->netdev;
 	int ret;
 
+	sa->sa_family = dev->type;
+
 	if (tp->version == RTL_VER_01) {
 		ret = pla_ocp_read(tp, PLA_IDR, 8, sa->sa_data);
 	} else {

^ permalink raw reply related	[flat|nested] 14+ messages in thread
* [v2,1/1] r8152: sync sa_family with the media type of network device
@ 2019-04-22  4:48 David Miller
  0 siblings, 0 replies; 14+ messages in thread
From: David Miller @ 2019-04-22  4:48 UTC (permalink / raw)
  To: crag0715
  Cc: netdev, linux-usb, linux-kernel, hayeswang, mario_limonciello,
	crag.wang, sjg, seanpaul, grundler, david.chen7, f.fainelli,
	jslaby, gustavo, charles.hyde, bigeasy, zhongjiang

From: Crag Wang <crag0715@gmail.com>
Date: Mon, 22 Apr 2019 11:17:49 +0800

> On Mon, Apr 22, 2019 at 10:44 AM David Miller <davem@davemloft.net> wrote:
>>
>>
>> Networking driver patches not sent to netdev@vger.kernel.org are very unlikely
>> to be integrated.
>>
>> Thank you.
> 
> Adding netdev@vger.kernel.org to this email, sorry about missing the
> recipient in the first place.

This does not get the patch queued up in patchwork, nor allow other readers of
netdev to see the patch so that it can be properly reviewed.

You must make a new, fresh, posting of your patch.

^ permalink raw reply	[flat|nested] 14+ messages in thread
* [v2,1/1] r8152: sync sa_family with the media type of network device
@ 2019-04-22  3:17 crag0715
  0 siblings, 0 replies; 14+ messages in thread
From: crag0715 @ 2019-04-22  3:17 UTC (permalink / raw)
  To: David Miller, netdev
  Cc: linux-usb, linux-kernel, hayeswang, Mario Limonciello, crag.wang,
	sjg, seanpaul, grundler, david.chen7, f.fainelli, jslaby, gustavo,
	charles.hyde, bigeasy, zhongjiang

On Mon, Apr 22, 2019 at 10:44 AM David Miller <davem@davemloft.net> wrote:
>
>
> Networking driver patches not sent to netdev@vger.kernel.org are very unlikely
> to be integrated.
>
> Thank you.

Adding netdev@vger.kernel.org to this email, sorry about missing the
recipient in the first place.

Thanks,
Crag

^ permalink raw reply	[flat|nested] 14+ messages in thread
* [v2,1/1] r8152: sync sa_family with the media type of network device
@ 2019-04-22  2:44 David Miller
  0 siblings, 0 replies; 14+ messages in thread
From: David Miller @ 2019-04-22  2:44 UTC (permalink / raw)
  To: crag0715
  Cc: linux-usb, linux-kernel, hayeswang, mario_limonciello, crag.wang,
	sjg, seanpaul, grundler, david.chen7, f.fainelli, jslaby, gustavo,
	charles.hyde, bigeasy, zhongjiang

Networking driver patches not sent to netdev@vger.kernel.org are very unlikely
to be integrated.

Thank you.

^ permalink raw reply	[flat|nested] 14+ messages in thread
* [v2,1/1] r8152: sync sa_family with the media type of network device
@ 2019-04-22  2:23 crag0715
  0 siblings, 0 replies; 14+ messages in thread
From: crag0715 @ 2019-04-22  2:23 UTC (permalink / raw)
  To: linux-usb
  Cc: linux-kernel, hayeswang, mario_limonciello, crag0715, Crag.Wang,
	David S. Miller, Simon Glass, Sean Paul, Grant Grundler,
	David Chen, Florian Fainelli, Jiri Slaby, Gustavo A. R. Silva,
	Charles Hyde, Sebastian Andrzej Siewior, zhong jiang

From: "Crag.Wang" <crag.wang@dell.com>

Without this patch the socket address family sporadically gets wrong
value ends up the dev_set_mac_address() fails to set the desired MAC
address.

Signed-off-by: Crag.Wang <crag.wang@dell.com>
---
 drivers/net/usb/r8152.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
index 4c63b40d5e00..41fb39ce69c9 100644
--- a/drivers/net/usb/r8152.c
+++ b/drivers/net/usb/r8152.c
@@ -1225,6 +1225,8 @@ static int determine_ethernet_addr(struct r8152 *tp, struct sockaddr *sa)
 	struct net_device *dev = tp->netdev;
 	int ret;
 
+	sa->sa_family = dev->type;
+
 	if (tp->version == RTL_VER_01) {
 		ret = pla_ocp_read(tp, PLA_IDR, 8, sa->sa_data);
 	} else {

^ permalink raw reply related	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2019-04-23  5:15 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-22  5:03 [v2,1/1] r8152: sync sa_family with the media type of network device crag0715
2019-04-22  5:03 ` [PATCH v2 1/1] " crag0715
2019-04-22 20:39 ` [v2,1/1] " Jakub Kicinski
2019-04-22 20:39   ` [PATCH v2 1/1] " Jakub Kicinski
2019-04-23  2:52   ` [v2,1/1] " crag0715
2019-04-23  2:52     ` [PATCH v2 1/1] " Crag Wang
2019-04-22 21:29 ` [v2,1/1] " Mario Limonciello
2019-04-22 21:29   ` [PATCH v2 1/1] " Mario.Limonciello
2019-04-23  5:15 ` [v2,1/1] " David Miller
2019-04-23  5:15   ` [PATCH v2 1/1] " David Miller
  -- strict thread matches above, loose matches on Subject: below --
2019-04-22  4:48 [v2,1/1] " David Miller
2019-04-22  3:17 crag0715
2019-04-22  2:44 David Miller
2019-04-22  2:23 crag0715

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox