* [PATCH v2] usb: musb: remove dead select of USB_MUSB_DUAL_ROLE
@ 2026-07-14 11:20 Julian Braha
2026-07-14 11:20 ` Julian Braha
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Julian Braha @ 2026-07-14 11:20 UTC (permalink / raw)
To: b-liu, gregkh
Cc: conor, arnd, linux-usb, linux-kernel, daire.mcnamara,
valentina.fernandezalanis, mturquette, sboyd, claudiu.beznea,
jassisinghbrar, a.zummo, alexandre.belloni, wsa, ben.dooks,
heinrich.schuchardt, Julian Braha
'select' does not work on config options in a 'choice', so currently it is
possible to enable USB_MUSB_POLARFIRE_SOC without USB_MUSB_DUAL_ROLE.
Remove the dead select, as it is unnecessary, from this conversation:
https://lore.kernel.org/all/20260712-parole-stoning-d7e66a0961a8@spud/
This dead select was found by kconfirm, a static analysis tool for Kconfig.
Suggested-by: Conor Dooley <conor@kernel.org>
Signed-off-by: Julian Braha <julianbraha@gmail.com>
---
Changes since v1: remove 'select' instead of changing to dependency
Link: https://lore.kernel.org/all/20260711130349.592545-1-julianbraha@gmail.com/
drivers/usb/musb/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig
index f56929267eaa..1b0d27d8e02f 100644
--- a/drivers/usb/musb/Kconfig
+++ b/drivers/usb/musb/Kconfig
@@ -116,7 +116,6 @@ config USB_MUSB_POLARFIRE_SOC
tristate "Microchip PolarFire SoC platforms"
depends on ARCH_MICROCHIP_POLARFIRE || COMPILE_TEST
depends on NOP_USB_XCEIV
- select USB_MUSB_DUAL_ROLE
help
Say Y here to enable support for USB on Microchip's PolarFire SoC.
--
2.54.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH v2] usb: musb: remove dead select of USB_MUSB_DUAL_ROLE
2026-07-14 11:20 [PATCH v2] usb: musb: remove dead select of USB_MUSB_DUAL_ROLE Julian Braha
@ 2026-07-14 11:20 ` Julian Braha
2026-07-14 11:57 ` Arnd Bergmann
2026-07-14 17:00 ` Conor Dooley
2 siblings, 0 replies; 4+ messages in thread
From: Julian Braha @ 2026-07-14 11:20 UTC (permalink / raw)
To: b-liu, gregkh
Cc: conor, arnd, linux-usb, linux-kernel, daire.mcnamara,
valentina.fernandezalanis, mturquette, sboyd, claudiu.beznea,
jassisinghbrar, a.zummo, alexandre.belloni, wsa, ben.dooks,
heinrich.schuchardt, Julian Braha
'select' does not work on config options in a 'choice', so currently it is
possible to enable USB_MUSB_POLARFIRE_SOC without USB_MUSB_DUAL_ROLE.
Remove the dead select, as it is unnecessary, from this conversation:
https://lore.kernel.org/all/20260712-parole-stoning-d7e66a0961a8@spud/
This dead select was found by kconfirm, a static analysis tool for Kconfig.
Suggested-by: Conor Dooley <conor@kernel.org>
Signed-off-by: Julian Braha <julianbraha@gmail.com>
---
Changes since v1: remove 'select' instead of changing to dependency
Link: https://lore.kernel.org/all/20260711130349.592545-1-julianbraha@gmail.com/
drivers/usb/musb/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig
index f56929267eaa..1b0d27d8e02f 100644
--- a/drivers/usb/musb/Kconfig
+++ b/drivers/usb/musb/Kconfig
@@ -116,7 +116,6 @@ config USB_MUSB_POLARFIRE_SOC
tristate "Microchip PolarFire SoC platforms"
depends on ARCH_MICROCHIP_POLARFIRE || COMPILE_TEST
depends on NOP_USB_XCEIV
- select USB_MUSB_DUAL_ROLE
help
Say Y here to enable support for USB on Microchip's PolarFire SoC.
--
2.54.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] usb: musb: remove dead select of USB_MUSB_DUAL_ROLE
2026-07-14 11:20 [PATCH v2] usb: musb: remove dead select of USB_MUSB_DUAL_ROLE Julian Braha
2026-07-14 11:20 ` Julian Braha
@ 2026-07-14 11:57 ` Arnd Bergmann
2026-07-14 17:00 ` Conor Dooley
2 siblings, 0 replies; 4+ messages in thread
From: Arnd Bergmann @ 2026-07-14 11:57 UTC (permalink / raw)
To: Julian Braha, Bin Liu, Greg Kroah-Hartman
Cc: Conor Dooley, linux-usb, linux-kernel, Daire McNamara,
valentina.fernandezalanis, Michael Turquette, Stephen Boyd,
Claudiu Beznea, Jassi Brar, Alessandro Zummo, Alexandre Belloni,
Wolfram Sang, Ben Dooks, Heinrich Schuchardt
On Tue, Jul 14, 2026, at 13:20, Julian Braha wrote:
> 'select' does not work on config options in a 'choice', so currently it is
> possible to enable USB_MUSB_POLARFIRE_SOC without USB_MUSB_DUAL_ROLE.
>
> Remove the dead select, as it is unnecessary, from this conversation:
> https://lore.kernel.org/all/20260712-parole-stoning-d7e66a0961a8@spud/
>
> This dead select was found by kconfirm, a static analysis tool for Kconfig.
>
> Suggested-by: Conor Dooley <conor@kernel.org>
> Signed-off-by: Julian Braha <julianbraha@gmail.com>
> ---
Acked-by: Arnd Bergmann <arnd@arndb.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] usb: musb: remove dead select of USB_MUSB_DUAL_ROLE
2026-07-14 11:20 [PATCH v2] usb: musb: remove dead select of USB_MUSB_DUAL_ROLE Julian Braha
2026-07-14 11:20 ` Julian Braha
2026-07-14 11:57 ` Arnd Bergmann
@ 2026-07-14 17:00 ` Conor Dooley
2 siblings, 0 replies; 4+ messages in thread
From: Conor Dooley @ 2026-07-14 17:00 UTC (permalink / raw)
To: Julian Braha
Cc: b-liu, gregkh, arnd, linux-usb, linux-kernel, daire.mcnamara,
valentina.fernandezalanis, mturquette, sboyd, claudiu.beznea,
jassisinghbrar, a.zummo, alexandre.belloni, wsa, ben.dooks,
heinrich.schuchardt
[-- Attachment #1: Type: text/plain, Size: 61 bytes --]
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-07-14 17:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-14 11:20 [PATCH v2] usb: musb: remove dead select of USB_MUSB_DUAL_ROLE Julian Braha
2026-07-14 11:20 ` Julian Braha
2026-07-14 11:57 ` Arnd Bergmann
2026-07-14 17:00 ` Conor Dooley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox