Thoughts on Sashiko reviews for linux-usb

Thoughts on Sashiko reviews for linux-usb

[Thinh Nguyen]

Hi all,

I'd like to get your thoughts on having Sashiko send review results to
linux-usb for patches posted to the list.

I started looking into this after receiving a reference to a Sashiko
review for a dwc3 patch that I wasn't Cc'd on, which required me to
track down the review separately to understand the feedback.

Sashiko is currently configured per mailing list, so any change would
apply to all patches sent to linux-usb rather than a specific subsystem.

Would anyone object to enabling Sashiko reviews on linux-usb?

Thanks,
Thinh

Re: Thoughts on Sashiko reviews for linux-usb

[Alan Stern]

On Tue, Oct 06, 2026 at 12:45:15AM +0000, Thinh Nguyen wrote:
> Hi all,
> 
> I'd like to get your thoughts on having Sashiko send review results to
> linux-usb for patches posted to the list.
> 
> I started looking into this after receiving a reference to a Sashiko
> review for a dwc3 patch that I wasn't Cc'd on, which required me to
> track down the review separately to understand the feedback.
> 
> Sashiko is currently configured per mailing list, so any change would
> apply to all patches sent to linux-usb rather than a specific subsystem.
> 
> Would anyone object to enabling Sashiko reviews on linux-usb?

I think it's a great idea.  Properly reviewing patches isn't easy; we 
could benefit from a little AI assistance.  Well worth the extra 
exercise involved in hitting "delete" a few dozen extra times every day 
for reviews we're not personally interested in.

Alan Stern

Re: Thoughts on Sashiko reviews for linux-usb

[Greg Kroah-Hartman]

On Tue, Oct 06, 2026 at 12:45:15AM +0000, Thinh Nguyen wrote:
> Hi all,
> 
> I'd like to get your thoughts on having Sashiko send review results to
> linux-usb for patches posted to the list.
> 
> I started looking into this after receiving a reference to a Sashiko
> review for a dwc3 patch that I wasn't Cc'd on, which required me to
> track down the review separately to understand the feedback.
> 
> Sashiko is currently configured per mailing list, so any change would
> apply to all patches sent to linux-usb rather than a specific subsystem.
> 
> Would anyone object to enabling Sashiko reviews on linux-usb?

Not at all, want to submit the pull request to the repo to add it, or do
you need/want me to?

thanks,

greg k-h

Re: Thoughts on Sashiko reviews for linux-usb

[Greg Kroah-Hartman]

On Tue, Oct 06, 2026 at 07:03:14AM +0200, Greg Kroah-Hartman wrote:
> On Tue, Oct 06, 2026 at 12:45:15AM +0000, Thinh Nguyen wrote:
> > Hi all,
> > 
> > I'd like to get your thoughts on having Sashiko send review results to
> > linux-usb for patches posted to the list.
> > 
> > I started looking into this after receiving a reference to a Sashiko
> > review for a dwc3 patch that I wasn't Cc'd on, which required me to
> > track down the review separately to understand the feedback.
> > 
> > Sashiko is currently configured per mailing list, so any change would
> > apply to all patches sent to linux-usb rather than a specific subsystem.
> > 
> > Would anyone object to enabling Sashiko reviews on linux-usb?
> 
> Not at all, want to submit the pull request to the repo to add it, or do
> you need/want me to?

Now done:
	https://github.com/sashiko-dev/sashiko/pull/651
but I don't know if that adds a "will email back the review" workflow
for patches sent to linux-usb@vger.

Roman, it looks like the sashiko.dev/email_policy.toml file isn't in the
repo anymore, or at least it's not in the git checkout that I can see.
Does the linux-usb list need to be configured anywhere else as well?

thanks,

greg k-h

Re: Thoughts on Sashiko reviews for linux-usb

[Roman Gushchin]

Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes:

> On Tue, Oct 06, 2026 at 07:03:14AM +0200, Greg Kroah-Hartman wrote:
>> On Tue, Oct 06, 2026 at 12:45:15AM +0000, Thinh Nguyen wrote:
>> > Hi all,
>> > 
>> > I'd like to get your thoughts on having Sashiko send review results to
>> > linux-usb for patches posted to the list.
>> > 
>> > I started looking into this after receiving a reference to a Sashiko
>> > review for a dwc3 patch that I wasn't Cc'd on, which required me to
>> > track down the review separately to understand the feedback.
>> > 
>> > Sashiko is currently configured per mailing list, so any change would
>> > apply to all patches sent to linux-usb rather than a specific subsystem.
>> > 
>> > Would anyone object to enabling Sashiko reviews on linux-usb?
>> 
>> Not at all, want to submit the pull request to the repo to add it, or do
>> you need/want me to?
>
> Now done:
> 	https://github.com/sashiko-dev/sashiko/pull/651
> but I don't know if that adds a "will email back the review" workflow
> for patches sent to linux-usb@vger.
>
> Roman, it looks like the sashiko.dev/email_policy.toml file isn't in the
> repo anymore, or at least it's not in the git checkout that I can see.
> Does the linux-usb list need to be configured anywhere else as well?

I moved it to deployment/sashiko.dev/email_policy.toml while preparing
to support other projects.

You need to define the email policy to receive reviews over the email.
I can help with that, just let me know who it should to/cc?
It seems that the most popular option is to reply to the author and cc
the mailing list.

Your PR is merged, thanks!

Re: Thoughts on Sashiko reviews for linux-usb

[Greg Kroah-Hartman]

On Tue, Oct 06, 2026 at 05:51:20AM +0000, Roman Gushchin wrote:
> Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes:
> 
> > On Tue, Oct 06, 2026 at 07:03:14AM +0200, Greg Kroah-Hartman wrote:
> >> On Tue, Oct 06, 2026 at 12:45:15AM +0000, Thinh Nguyen wrote:
> >> > Hi all,
> >> > 
> >> > I'd like to get your thoughts on having Sashiko send review results to
> >> > linux-usb for patches posted to the list.
> >> > 
> >> > I started looking into this after receiving a reference to a Sashiko
> >> > review for a dwc3 patch that I wasn't Cc'd on, which required me to
> >> > track down the review separately to understand the feedback.
> >> > 
> >> > Sashiko is currently configured per mailing list, so any change would
> >> > apply to all patches sent to linux-usb rather than a specific subsystem.
> >> > 
> >> > Would anyone object to enabling Sashiko reviews on linux-usb?
> >> 
> >> Not at all, want to submit the pull request to the repo to add it, or do
> >> you need/want me to?
> >
> > Now done:
> > 	https://github.com/sashiko-dev/sashiko/pull/651
> > but I don't know if that adds a "will email back the review" workflow
> > for patches sent to linux-usb@vger.
> >
> > Roman, it looks like the sashiko.dev/email_policy.toml file isn't in the
> > repo anymore, or at least it's not in the git checkout that I can see.
> > Does the linux-usb list need to be configured anywhere else as well?
> 
> I moved it to deployment/sashiko.dev/email_policy.toml while preparing
> to support other projects.
> 
> You need to define the email policy to receive reviews over the email.
> I can help with that, just let me know who it should to/cc?
> It seems that the most popular option is to reply to the author and cc
> the mailing list.

Ah, issed that file, sorry about that.  I've submitted:
	https://github.com/sashiko-dev/sashiko/pull/652
to add the default policy (to match what we have on linux-serial as that
seems the most sane for now.)

thanks,

greg k-h

Re: Thoughts on Sashiko reviews for linux-usb

[Roman Gushchin]

Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes:

> On Tue, Oct 06, 2026 at 05:51:20AM +0000, Roman Gushchin wrote:
>> Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes:
>> 
>> > On Tue, Oct 06, 2026 at 07:03:14AM +0200, Greg Kroah-Hartman wrote:
>> >> On Tue, Oct 06, 2026 at 12:45:15AM +0000, Thinh Nguyen wrote:
>> >> > Hi all,
>> >> > 
>> >> > I'd like to get your thoughts on having Sashiko send review results to
>> >> > linux-usb for patches posted to the list.
>> >> > 
>> >> > I started looking into this after receiving a reference to a Sashiko
>> >> > review for a dwc3 patch that I wasn't Cc'd on, which required me to
>> >> > track down the review separately to understand the feedback.
>> >> > 
>> >> > Sashiko is currently configured per mailing list, so any change would
>> >> > apply to all patches sent to linux-usb rather than a specific subsystem.
>> >> > 
>> >> > Would anyone object to enabling Sashiko reviews on linux-usb?
>> >> 
>> >> Not at all, want to submit the pull request to the repo to add it, or do
>> >> you need/want me to?
>> >
>> > Now done:
>> > 	https://github.com/sashiko-dev/sashiko/pull/651
>> > but I don't know if that adds a "will email back the review" workflow
>> > for patches sent to linux-usb@vger.
>> >
>> > Roman, it looks like the sashiko.dev/email_policy.toml file isn't in the
>> > repo anymore, or at least it's not in the git checkout that I can see.
>> > Does the linux-usb list need to be configured anywhere else as well?
>> 
>> I moved it to deployment/sashiko.dev/email_policy.toml while preparing
>> to support other projects.
>> 
>> You need to define the email policy to receive reviews over the email.
>> I can help with that, just let me know who it should to/cc?
>> It seems that the most popular option is to reply to the author and cc
>> the mailing list.
>
> Ah, issed that file, sorry about that.  I've submitted:
> 	https://github.com/sashiko-dev/sashiko/pull/652
> to add the default policy (to match what we have on linux-serial as that
> seems the most sane for now.)

Awesome, thanks! Applied.

I'll roll out sashiko later today; it won't be effective until that.

Thanks